Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React Dash: Add multisite conditional for backup AAG card #14657

Merged
merged 1 commit into from
Feb 14, 2020
Merged

React Dash: Add multisite conditional for backup AAG card #14657

merged 1 commit into from
Feb 14, 2020

Conversation

kraftbj
Copy link
Contributor

@kraftbj kraftbj commented Feb 12, 2020

Fixes #14656

Changes proposed in this Pull Request:

  • Adds a conditional so we don't show the backups component on the AAG page for multisite installs.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • No.

Testing instructions:

  • Spin up a new multisite (JN can do this).
  • Activate/connect Jetpack. Free plan is fine.
  • Confirm there is not a backups card on the AAG page of the Jetpack Dashboard

Proposed changelog entry for your changes:

  • Admin Dashboard: Remove Backups information for multisites. They are not supported at this time.

@kraftbj kraftbj added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. Admin Page React-powered dashboard under the Jetpack menu [Feature] Backup & Scan Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" labels Feb 12, 2020
@kraftbj kraftbj added this to the 8.3 milestone Feb 12, 2020
@kraftbj kraftbj requested a review from a team February 12, 2020 23:05
@kraftbj kraftbj self-assigned this Feb 12, 2020
@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: March 3, 2020.
Scheduled code freeze: February 25, 2020

Generated by 🚫 dangerJS against 33ff0c9

brbrr
brbrr approved these changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@brbrr brbrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well in my tests! :shipit:

Worth noting that we still show Backups upgrade nudge in the settings page.

Jetpack ‹ Curious House — WordPress 2020-02-13 10-30-25

@brbrr brbrr mentioned this pull request Feb 13, 2020
Merged
jeherve
jeherve reviewed Feb 13, 2020
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to remove the card in all scenarios? Should we display the card for folks aiming to use VaultPress for their backups, since that's still an option for Multisite networks?

Maybe we shouldn't display the card for free sites, but should continue to display it for sites that are already using VaultPress and a standalone backup plan from VP or a Jetpack plan?

@jeherve jeherve added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Feb 13, 2020
@kraftbj
Copy link
Contributor Author

kraftbj commented Feb 13, 2020

While we allow VaultPress to be installed on a multisite, it is still a really bad experience, we don't suggest it ( https://help.vaultpress.com/multisite/ ), and will still run into issues as legacy systems migrate to JP Backups.

I'm open to it for sites where VaultPress is installed. Looking at the Site Profiler, we're talking about 600 multisite blogs with VaultPress installed, so I don't know if the added complexity to conditionally display it is worth it when VaultPress' dashboard will still be present under the top-level Jetpack menu.

@kraftbj kraftbj added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Feb 13, 2020
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Feb 14, 2020
jeherve
jeherve approved these changes Feb 14, 2020
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're talking about 600 multisite blogs with VaultPress installed, so I don't know if the added complexity to conditionally display it is worth it when VaultPress' dashboard will still be present under the top-level Jetpack menu.

Thanks for looking into it. I agree that it may not be worth taking those into account.

@kraftbj kraftbj merged commit 861ab14 into master Feb 14, 2020
@kraftbj kraftbj deleted the hide/jetpack-backups-multisite branch February 14, 2020 15:40
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Feb 14, 2020
jeherve added a commit that referenced this pull request Feb 25, 2020
@jeherve
Changelog: add #14657
c67b994
jeherve added a commit that referenced this pull request Feb 25, 2020
@jeherve
Changelog: 8.3 running changelog (#14642)
8797bea 
* 8.3 release: changelog

* Changelog: add #14516

* Changelog: add #14574

* Bring in changes from 8.2.1 and 8.2.2

* Update stable version

* Bring in 8.2.3 changes

* Changelog: add #14714

* Changelog: add #14639

* Changelog: add #14678

* Changelog: add #14673

* Changelog: add #14687

* Changelog: add #14704

* Changelog: add #14702

* Changelog: add #14541

* Changelog: add #14657

* Changelog: add #14622

* Changelog: add #14582

* Changelog: add #14638

* Changelog: add #14633

* Changelog: add #14571

* Changelog: add #14592

* Changelog: add #14539

* Changelog: add #14514

* Changelog: add #14643

* Changelog: add #14494

* Changelog: add #13739

* Changelog: add #14707

* Changelog: add #14736

* Changelog: add #14706

* Changelog: add #14730

* Changelog: add #14685

* Changelog: add #14727

* Changelog: add #14711

* Changelog: add #14742

* Changelog: add #14746

* Changelog: add #14725

* Changelog: add #13999

* Changelog: add #14740

* Changelog: add #14759

* Changelog: add #14703

* Changelog: add #14753

* Changelog: add #14754

* Changelog: add #14645

* Cahngelog: add #14599
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brbrr brbrr brbrr approved these changes

@jeherve jeherve jeherve approved these changes

Assignees

@kraftbj kraftbj

Labels
Admin Page React-powered dashboard under the Jetpack menu Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" [Feature] Backup & Scan [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
8.3
Development

Successfully merging this pull request may close these issues.

React Dash: Do not show backups AAG on Multisite
5 participants
@kraftbj @jetpackbot @jeherve @brbrr @matticbot