-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
๐ [REQUEST] - Improve handling cookie #78
Labels
feature-request
feature request ๐
Comments
ymw0407
added a commit
that referenced
this issue
Oct 4, 2023
- need to improve handling cookie at refreshing main page
4 tasks
bentshrimp
added a commit
that referenced
this issue
Oct 5, 2023
Signed-off-by: bentshrimp <[email protected]>
Merged
11 tasks
bentshrimp
added a commit
that referenced
this issue
Oct 5, 2023
Signed-off-by: bentshrimp <[email protected]>
ymw0407
added a commit
that referenced
this issue
Oct 5, 2023
* Fix : Improving cookie handling tech #78 - need to improve handling cookie at refreshing main page * Fix : vulnerability alert resolved #77 - https://github.com/AgainIoT/Open-Set-Go_client/security/dependabot/3 Signed-off-by: bentshrimp <[email protected]> * Fix : MainPage isLogin state works well #78 Signed-off-by: bentshrimp <[email protected]> * Fix : changed unnecessary if-else into single return statement #78 Signed-off-by: bentshrimp <[email protected]> --------- Signed-off-by: bentshrimp <[email protected]> Co-authored-by: ymw0407 <[email protected]>
ymw0407
added a commit
that referenced
this issue
Oct 7, 2023
* Feat : add meta data #65 Signed-off-by: bentshrimp <[email protected]> * Bump @adobe/css-tools from 4.2.0 to 4.3.1 Bumps [@adobe/css-tools](https://github.com/adobe/css-tools) from 4.2.0 to 4.3.1. - [Changelog](https://github.com/adobe/css-tools/blob/main/History.md) - [Commits](https://github.com/adobe/css-tools/commits) --- updated-dependencies: - dependency-name: "@adobe/css-tools" dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * Fix : Security Priblem occured by nth-check resolved at #71 Signed-off-by: ymw0407 <[email protected]> * Update : rename title from "Open Set Go" to "Open-Set-Go" #65 Signed-off-by: bentshrimp <[email protected]> * Update : manifest.json updated with proper icon images #65 Signed-off-by: bentshrimp <[email protected]> * Remove : unnecessary file, favicon.svg removed #65 Signed-off-by: bentshrimp <[email protected]> * Fix : icon size setting fixed #65 Signed-off-by: bentshrimp <[email protected]> * Chore : remove .vscode Signed-off-by: Yun Min Woo <[email protected]> * Add : _redirects for netlify CD Signed-off-by: Yun Min Woo <[email protected]> * Fix : Improving cookie handling tech #78 - need to improve handling cookie at refreshing main page * Fix : vulnerability alert resolved #77 - https://github.com/AgainIoT/Open-Set-Go_client/security/dependabot/3 Signed-off-by: bentshrimp <[email protected]> * Fix : MainPage isLogin state works well #78 Signed-off-by: bentshrimp <[email protected]> * Fix : changed unnecessary if-else into single return statement #78 Signed-off-by: bentshrimp <[email protected]> * update staging branch (#81) * Fix : Improving cookie handling tech #78 - need to improve handling cookie at refreshing main page * Fix : vulnerability alert resolved #77 - https://github.com/AgainIoT/Open-Set-Go_client/security/dependabot/3 Signed-off-by: bentshrimp <[email protected]> * Fix : MainPage isLogin state works well #78 Signed-off-by: bentshrimp <[email protected]> * Fix : changed unnecessary if-else into single return statement #78 Signed-off-by: bentshrimp <[email protected]> --------- Signed-off-by: bentshrimp <[email protected]> Co-authored-by: ymw0407 <[email protected]> * Fix : remove user info in local storage #83 - correct the icon src - remove user info every time user revisit after automatic loggout Signed-off-by: bentshrimp <[email protected]> * Add : add react script 'yarn start:win' & 'yarn start:linux' #85 * Feat : Security Policy Updated #87 Signed-off-by: Yun Min Woo <[email protected]> * Fix : blog -> docs, docs domain changed #88 * Fix : Logo.svg changed to logo.svg(typo error) Co-authored-by : bent_shrimp <[email protected]> Signed-off-by: Yun Min Woo <[email protected]> * Fix : render profile image when only login #83 Signed-off-by: bentshrimp <[email protected]> * Chore : remove unnecessary import #83 Signed-off-by: bentshrimp <[email protected]> * Revert "Unexpected bugs fixed" * Fix : manage login state only in Header #83 Signed-off-by: bentshrimp <[email protected]> * Chore : remove unused state variable #83 Signed-off-by: bentshrimp <[email protected]> * Correct old docs url (#100) Fix : old docs url corrected #98 Signed-off-by: bentshrimp <[email protected]> Co-authored-by: Yun Min Woo <[email protected]> --------- Signed-off-by: bentshrimp <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: ymw0407 <[email protected]> Signed-off-by: Yun Min Woo <[email protected]> Co-authored-by: bentshrimp <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: bent_shrimp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe
Remove the react-cookie module and check whether there is a cookie through the auth/checkToken API on the server.
react-cookie ๋ชจ๋์ ์ ๊ฑฐํ๊ณ , cookie์ ์ฌ๋ถ ํ์ธ์ ์๋ฒ์ auth/checkToken API๋ฅผ ํตํด ์งํํ๋ค.
Reasons
Previously, cookies with http-only false have been directly dealt with using the react-cookie module to deal with cookies. However, as the domain between client and server changes, there is a need to improve the part.
๊ธฐ์กด์๋ cookie๋ฅผ ๋ค๋ฃจ๊ธฐ ์ํด react-cookie ๋ชจ๋์ ํ์ฉํด์ http-only๊ฐ false์ธ ์ฟ ํค๋ฅผ ์ง์ ์ ์ผ๋ก ๋ค๋ฃจ์ด์๋ค. ํ์ง๋ง client์ server๊ฐ์ ๋๋ฉ์ธ์ด ๋ฌ๋ผ์ง์ ๋ฐ๋ผ ํด๋น ๋ถ๋ถ์ด ๊ฐ์ ๋์ด์ผ ํ ํ์์ฑ์ด ์๊ฒผ๋ค.
How to Implement Features
No response
Additional Explanation
AgainIoT/Open-Set-Go_server#120
Connection
The text was updated successfully, but these errors were encountered: