Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿš€ [REQUEST] - Improve handling cookie #78

Closed
1 of 2 tasks
ymw0407 opened this issue Oct 4, 2023 · 0 comments ยท Fixed by #80
Closed
1 of 2 tasks

๐Ÿš€ [REQUEST] - Improve handling cookie #78

ymw0407 opened this issue Oct 4, 2023 · 0 comments ยท Fixed by #80
Assignees
Labels
feature-request feature request ๐Ÿš€

Comments

@ymw0407
Copy link
Member

ymw0407 commented Oct 4, 2023

Describe

Remove the react-cookie module and check whether there is a cookie through the auth/checkToken API on the server.
react-cookie ๋ชจ๋“ˆ์„ ์ œ๊ฑฐํ•˜๊ณ , cookie์˜ ์—ฌ๋ถ€ ํ™•์ธ์„ ์„œ๋ฒ„์˜ auth/checkToken API๋ฅผ ํ†ตํ•ด ์ง„ํ–‰ํ•œ๋‹ค.

Reasons

Previously, cookies with http-only false have been directly dealt with using the react-cookie module to deal with cookies. However, as the domain between client and server changes, there is a need to improve the part.
๊ธฐ์กด์—๋Š” cookie๋ฅผ ๋‹ค๋ฃจ๊ธฐ ์œ„ํ•ด react-cookie ๋ชจ๋“ˆ์„ ํ™œ์šฉํ•ด์„œ http-only๊ฐ€ false์ธ ์ฟ ํ‚ค๋ฅผ ์ง์ ‘์ ์œผ๋กœ ๋‹ค๋ฃจ์–ด์™”๋‹ค. ํ•˜์ง€๋งŒ client์™€ server๊ฐ„์˜ ๋„๋ฉ”์ธ์ด ๋‹ฌ๋ผ์ง์— ๋”ฐ๋ผ ํ•ด๋‹น ๋ถ€๋ถ„์ด ๊ฐœ์„ ๋˜์–ด์•ผ ํ•  ํ•„์š”์„ฑ์ด ์ƒ๊ฒผ๋‹ค.

How to Implement Features

No response

Additional Explanation

AgainIoT/Open-Set-Go_server#120

Connection

  • Have no effect on other functions
  • Other functions need to be changed
@ymw0407 ymw0407 added the feature-request feature request ๐Ÿš€ label Oct 4, 2023
ymw0407 added a commit that referenced this issue Oct 4, 2023
- need to improve handling cookie at refreshing main page
bentshrimp added a commit that referenced this issue Oct 5, 2023
@bentshrimp bentshrimp mentioned this issue Oct 5, 2023
11 tasks
@bentshrimp bentshrimp linked a pull request Oct 5, 2023 that will close this issue
11 tasks
bentshrimp added a commit that referenced this issue Oct 5, 2023
ymw0407 added a commit that referenced this issue Oct 5, 2023
* Fix : Improving cookie handling tech #78

- need to improve handling cookie at refreshing main page

* Fix : vulnerability alert resolved  #77

- https://github.com/AgainIoT/Open-Set-Go_client/security/dependabot/3

Signed-off-by: bentshrimp <[email protected]>

* Fix : MainPage isLogin state works well  #78

Signed-off-by: bentshrimp <[email protected]>

* Fix : changed unnecessary if-else into single return statement #78

Signed-off-by: bentshrimp <[email protected]>

---------

Signed-off-by: bentshrimp <[email protected]>
Co-authored-by: ymw0407 <[email protected]>
@ymw0407 ymw0407 mentioned this issue Oct 6, 2023
11 tasks
ymw0407 added a commit that referenced this issue Oct 7, 2023
* Feat : add meta data #65

Signed-off-by: bentshrimp <[email protected]>

* Bump @adobe/css-tools from 4.2.0 to 4.3.1

Bumps [@adobe/css-tools](https://github.com/adobe/css-tools) from 4.2.0 to 4.3.1.
- [Changelog](https://github.com/adobe/css-tools/blob/main/History.md)
- [Commits](https://github.com/adobe/css-tools/commits)

---
updated-dependencies:
- dependency-name: "@adobe/css-tools"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* Fix : Security Priblem occured by nth-check resolved at #71

Signed-off-by: ymw0407 <[email protected]>

* Update : rename title from "Open Set Go" to "Open-Set-Go" #65

Signed-off-by: bentshrimp <[email protected]>

* Update : manifest.json updated with proper icon images #65

Signed-off-by: bentshrimp <[email protected]>

* Remove : unnecessary file, favicon.svg removed #65

Signed-off-by: bentshrimp <[email protected]>

* Fix : icon size setting fixed #65

Signed-off-by: bentshrimp <[email protected]>

* Chore : remove .vscode

Signed-off-by: Yun Min Woo <[email protected]>

* Add : _redirects for netlify CD

Signed-off-by: Yun Min Woo <[email protected]>

* Fix : Improving cookie handling tech #78

- need to improve handling cookie at refreshing main page

* Fix : vulnerability alert resolved  #77

- https://github.com/AgainIoT/Open-Set-Go_client/security/dependabot/3

Signed-off-by: bentshrimp <[email protected]>

* Fix : MainPage isLogin state works well  #78

Signed-off-by: bentshrimp <[email protected]>

* Fix : changed unnecessary if-else into single return statement #78

Signed-off-by: bentshrimp <[email protected]>

* update staging branch (#81)

* Fix : Improving cookie handling tech #78

- need to improve handling cookie at refreshing main page

* Fix : vulnerability alert resolved  #77

- https://github.com/AgainIoT/Open-Set-Go_client/security/dependabot/3

Signed-off-by: bentshrimp <[email protected]>

* Fix : MainPage isLogin state works well  #78

Signed-off-by: bentshrimp <[email protected]>

* Fix : changed unnecessary if-else into single return statement #78

Signed-off-by: bentshrimp <[email protected]>

---------

Signed-off-by: bentshrimp <[email protected]>
Co-authored-by: ymw0407 <[email protected]>

* Fix : remove user info in local storage  #83

- correct the icon src
- remove user info every time user revisit after automatic loggout

Signed-off-by: bentshrimp <[email protected]>

* Add : add react script 'yarn start:win' & 'yarn start:linux' #85

* Feat : Security Policy Updated #87

Signed-off-by: Yun Min Woo <[email protected]>

* Fix : blog -> docs, docs domain changed #88

* Fix : Logo.svg changed to logo.svg(typo error)

Co-authored-by : bent_shrimp <[email protected]>

Signed-off-by: Yun Min Woo <[email protected]>

* Fix : render profile image when only login #83

Signed-off-by: bentshrimp <[email protected]>

* Chore : remove unnecessary import #83

Signed-off-by: bentshrimp <[email protected]>

* Revert "Unexpected bugs fixed"

* Fix : manage login state only in Header #83

Signed-off-by: bentshrimp <[email protected]>

* Chore : remove unused state variable #83

Signed-off-by: bentshrimp <[email protected]>

* Correct old docs url (#100)

Fix : old docs url corrected #98

Signed-off-by: bentshrimp <[email protected]>
Co-authored-by: Yun Min Woo <[email protected]>

---------

Signed-off-by: bentshrimp <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: ymw0407 <[email protected]>
Signed-off-by: Yun Min Woo <[email protected]>
Co-authored-by: bentshrimp <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: bent_shrimp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request feature request ๐Ÿš€
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants