Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 [BUG] - avatar appears if you leave the page and revisit after a while. #83

Closed
bentshrimp opened this issue Oct 5, 2023 · 0 comments · Fixed by #93
Closed

🐛 [BUG] - avatar appears if you leave the page and revisit after a while. #83

bentshrimp opened this issue Oct 5, 2023 · 0 comments · Fixed by #93
Assignees
@bentshrimp
Labels
bug Something isn't working

Comments

@bentshrimp
Copy link
Contributor

Browsers

Chrome

OS

Linux

Description

User profile image, called "avatar" still appears when you revisit after leaving the site without logout.

Reproduction URL

https://staging--open-set-go.netlify.app/

Reproduction Steps

Log in the page, and wait until the cookie expires.

Then revisit. You will be able to still see your avatar on the right top corner.

Solutions

Every time the user log in, his information is saved in local storage on the brower.

1. Check if the brower has valid token.
2. If it doesn't, remove user information saved in local storage.

Screenshots

![DESCRIPTION](LINK.png)
@bentshrimp bentshrimp added the bug Something isn't working label Oct 5, 2023
@bentshrimp bentshrimp self-assigned this Oct 5, 2023
bentshrimp added a commit that referenced this issue Oct 5, 2023
@bentshrimp
Fix : remove user info in local storage #83
050c481 
- correct the icon src
- remove user info every time user revisit after automatic loggout

Signed-off-by: bentshrimp <[email protected]>
bentshrimp added a commit that referenced this issue Oct 6, 2023
@bentshrimp
Fix : render profile image when only login #83
46c52b1 
Signed-off-by: bentshrimp <[email protected]>
@bentshrimp bentshrimp linked a pull request Oct 6, 2023 that will close this issue
Fixed profile image mulfunction #93
Merged
11 tasks
@bentshrimp bentshrimp mentioned this issue Oct 6, 2023
Merged
11 tasks
bentshrimp added a commit that referenced this issue Oct 6, 2023
@bentshrimp
Chore : remove unnecessary import #83
4d14dea 
Signed-off-by: bentshrimp <[email protected]>
@bentshrimp bentshrimp reopened this Oct 6, 2023
bentshrimp added a commit that referenced this issue Oct 6, 2023
@bentshrimp
Fix : manage login state only in Header #83
3a8152f 
Signed-off-by: bentshrimp <[email protected]>
@bentshrimp bentshrimp mentioned this issue Oct 6, 2023
Merged
11 tasks
bentshrimp added a commit that referenced this issue Oct 6, 2023
@bentshrimp
Chore : remove unused state variable #83
c1e4494 
Signed-off-by: bentshrimp <[email protected]>
bentshrimp added a commit that referenced this issue Oct 6, 2023
@bentshrimp
Merge pull request #96 from AgainIoT/feature/83
889814b 
Fix : manage login state only in Header #83
@bentshrimp bentshrimp mentioned this issue Oct 6, 2023
Merged
11 tasks
ymw0407 added a commit that referenced this issue Oct 7, 2023
@ymw0407 @bentshrimp @dependabot
Open-Set-Go v1.0.1 (#87)
bc30a25 
* Feat : add meta data #65

Signed-off-by: bentshrimp <[email protected]>

* Bump @adobe/css-tools from 4.2.0 to 4.3.1

Bumps [@adobe/css-tools](https://github.com/adobe/css-tools) from 4.2.0 to 4.3.1.
- [Changelog](https://github.com/adobe/css-tools/blob/main/History.md)
- [Commits](https://github.com/adobe/css-tools/commits)

---
updated-dependencies:
- dependency-name: "@adobe/css-tools"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* Fix : Security Priblem occured by nth-check resolved at #71

Signed-off-by: ymw0407 <[email protected]>

* Update : rename title from "Open Set Go" to "Open-Set-Go" #65

Signed-off-by: bentshrimp <[email protected]>

* Update : manifest.json updated with proper icon images #65

Signed-off-by: bentshrimp <[email protected]>

* Remove : unnecessary file, favicon.svg removed #65

Signed-off-by: bentshrimp <[email protected]>

* Fix : icon size setting fixed #65

Signed-off-by: bentshrimp <[email protected]>

* Chore : remove .vscode

Signed-off-by: Yun Min Woo <[email protected]>

* Add : _redirects for netlify CD

Signed-off-by: Yun Min Woo <[email protected]>

* Fix : Improving cookie handling tech #78

- need to improve handling cookie at refreshing main page

* Fix : vulnerability alert resolved  #77

- https://github.com/AgainIoT/Open-Set-Go_client/security/dependabot/3

Signed-off-by: bentshrimp <[email protected]>

* Fix : MainPage isLogin state works well  #78

Signed-off-by: bentshrimp <[email protected]>

* Fix : changed unnecessary if-else into single return statement #78

Signed-off-by: bentshrimp <[email protected]>

* update staging branch (#81)

* Fix : Improving cookie handling tech #78

- need to improve handling cookie at refreshing main page

* Fix : vulnerability alert resolved  #77

- https://github.com/AgainIoT/Open-Set-Go_client/security/dependabot/3

Signed-off-by: bentshrimp <[email protected]>

* Fix : MainPage isLogin state works well  #78

Signed-off-by: bentshrimp <[email protected]>

* Fix : changed unnecessary if-else into single return statement #78

Signed-off-by: bentshrimp <[email protected]>

---------

Signed-off-by: bentshrimp <[email protected]>
Co-authored-by: ymw0407 <[email protected]>

* Fix : remove user info in local storage  #83

- correct the icon src
- remove user info every time user revisit after automatic loggout

Signed-off-by: bentshrimp <[email protected]>

* Add : add react script 'yarn start:win' & 'yarn start:linux' #85

* Feat : Security Policy Updated #87

Signed-off-by: Yun Min Woo <[email protected]>

* Fix : blog -> docs, docs domain changed #88

* Fix : Logo.svg changed to logo.svg(typo error)

Co-authored-by : bent_shrimp <[email protected]>

Signed-off-by: Yun Min Woo <[email protected]>

* Fix : render profile image when only login #83

Signed-off-by: bentshrimp <[email protected]>

* Chore : remove unnecessary import #83

Signed-off-by: bentshrimp <[email protected]>

* Revert "Unexpected bugs fixed"

* Fix : manage login state only in Header #83

Signed-off-by: bentshrimp <[email protected]>

* Chore : remove unused state variable #83

Signed-off-by: bentshrimp <[email protected]>

* Correct old docs url (#100)

Fix : old docs url corrected #98

Signed-off-by: bentshrimp <[email protected]>
Co-authored-by: Yun Min Woo <[email protected]>

---------

Signed-off-by: bentshrimp <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: ymw0407 <[email protected]>
Signed-off-by: Yun Min Woo <[email protected]>
Co-authored-by: bentshrimp <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: bent_shrimp <[email protected]>
@bentshrimp bentshrimp mentioned this issue Oct 25, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bentshrimp bentshrimp

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed profile image mulfunction AgainIoT/Open-Set-Go_client
1 participant
@bentshrimp