-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update staging branch #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- need to improve handling cookie at refreshing main page
- https://github.com/AgainIoT/Open-Set-Go_client/security/dependabot/3 Signed-off-by: bentshrimp <[email protected]>
Fix : vulnerability alert resolved #77
Signed-off-by: bentshrimp <[email protected]>
Signed-off-by: bentshrimp <[email protected]>
cookie handling
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
ymw0407
approved these changes
Oct 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
ymw0407
added a commit
that referenced
this pull request
Oct 7, 2023
* Feat : add meta data #65 Signed-off-by: bentshrimp <[email protected]> * Bump @adobe/css-tools from 4.2.0 to 4.3.1 Bumps [@adobe/css-tools](https://github.com/adobe/css-tools) from 4.2.0 to 4.3.1. - [Changelog](https://github.com/adobe/css-tools/blob/main/History.md) - [Commits](https://github.com/adobe/css-tools/commits) --- updated-dependencies: - dependency-name: "@adobe/css-tools" dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * Fix : Security Priblem occured by nth-check resolved at #71 Signed-off-by: ymw0407 <[email protected]> * Update : rename title from "Open Set Go" to "Open-Set-Go" #65 Signed-off-by: bentshrimp <[email protected]> * Update : manifest.json updated with proper icon images #65 Signed-off-by: bentshrimp <[email protected]> * Remove : unnecessary file, favicon.svg removed #65 Signed-off-by: bentshrimp <[email protected]> * Fix : icon size setting fixed #65 Signed-off-by: bentshrimp <[email protected]> * Chore : remove .vscode Signed-off-by: Yun Min Woo <[email protected]> * Add : _redirects for netlify CD Signed-off-by: Yun Min Woo <[email protected]> * Fix : Improving cookie handling tech #78 - need to improve handling cookie at refreshing main page * Fix : vulnerability alert resolved #77 - https://github.com/AgainIoT/Open-Set-Go_client/security/dependabot/3 Signed-off-by: bentshrimp <[email protected]> * Fix : MainPage isLogin state works well #78 Signed-off-by: bentshrimp <[email protected]> * Fix : changed unnecessary if-else into single return statement #78 Signed-off-by: bentshrimp <[email protected]> * update staging branch (#81) * Fix : Improving cookie handling tech #78 - need to improve handling cookie at refreshing main page * Fix : vulnerability alert resolved #77 - https://github.com/AgainIoT/Open-Set-Go_client/security/dependabot/3 Signed-off-by: bentshrimp <[email protected]> * Fix : MainPage isLogin state works well #78 Signed-off-by: bentshrimp <[email protected]> * Fix : changed unnecessary if-else into single return statement #78 Signed-off-by: bentshrimp <[email protected]> --------- Signed-off-by: bentshrimp <[email protected]> Co-authored-by: ymw0407 <[email protected]> * Fix : remove user info in local storage #83 - correct the icon src - remove user info every time user revisit after automatic loggout Signed-off-by: bentshrimp <[email protected]> * Add : add react script 'yarn start:win' & 'yarn start:linux' #85 * Feat : Security Policy Updated #87 Signed-off-by: Yun Min Woo <[email protected]> * Fix : blog -> docs, docs domain changed #88 * Fix : Logo.svg changed to logo.svg(typo error) Co-authored-by : bent_shrimp <[email protected]> Signed-off-by: Yun Min Woo <[email protected]> * Fix : render profile image when only login #83 Signed-off-by: bentshrimp <[email protected]> * Chore : remove unnecessary import #83 Signed-off-by: bentshrimp <[email protected]> * Revert "Unexpected bugs fixed" * Fix : manage login state only in Header #83 Signed-off-by: bentshrimp <[email protected]> * Chore : remove unused state variable #83 Signed-off-by: bentshrimp <[email protected]> * Correct old docs url (#100) Fix : old docs url corrected #98 Signed-off-by: bentshrimp <[email protected]> Co-authored-by: Yun Min Woo <[email protected]> --------- Signed-off-by: bentshrimp <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: ymw0407 <[email protected]> Signed-off-by: Yun Min Woo <[email protected]> Co-authored-by: bentshrimp <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: bent_shrimp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe changes
Issue number or link
Types of changes
What is the type of code change?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
Please let me know if there's anything else to explain