Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update staging branch #81

Merged
merged 6 commits into from
Oct 5, 2023
Merged

update staging branch #81

merged 6 commits into from
Oct 5, 2023

Conversation

bentshrimp
Copy link
Contributor

Describe changes

  • vulnerability warning fixed
  • cookie handling improved
  • fixed a few bugs

Issue number or link

Types of changes

What is the type of code change?
Put an x in the boxes that apply

  • Bugfix (changes that resolve errors)
  • New feature (changes which adds functionality)
  • Breaking change (big changes that affect existing functionality)
  • Documentation Update

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the "README.md"
  • My code follows the style guidelines of this project
  • My changes generate no new warnings
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation
  • Any dependent changes have been merged and published in downstream modules

Further comments

Please let me know if there's anything else to explain

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@ymw0407 ymw0407 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ymw0407 ymw0407 merged commit d8da4fd into staging Oct 5, 2023
6 checks passed
ymw0407 added a commit that referenced this pull request Oct 7, 2023
* Feat : add meta data #65

Signed-off-by: bentshrimp <[email protected]>

* Bump @adobe/css-tools from 4.2.0 to 4.3.1

Bumps [@adobe/css-tools](https://github.com/adobe/css-tools) from 4.2.0 to 4.3.1.
- [Changelog](https://github.com/adobe/css-tools/blob/main/History.md)
- [Commits](https://github.com/adobe/css-tools/commits)

---
updated-dependencies:
- dependency-name: "@adobe/css-tools"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* Fix : Security Priblem occured by nth-check resolved at #71

Signed-off-by: ymw0407 <[email protected]>

* Update : rename title from "Open Set Go" to "Open-Set-Go" #65

Signed-off-by: bentshrimp <[email protected]>

* Update : manifest.json updated with proper icon images #65

Signed-off-by: bentshrimp <[email protected]>

* Remove : unnecessary file, favicon.svg removed #65

Signed-off-by: bentshrimp <[email protected]>

* Fix : icon size setting fixed #65

Signed-off-by: bentshrimp <[email protected]>

* Chore : remove .vscode

Signed-off-by: Yun Min Woo <[email protected]>

* Add : _redirects for netlify CD

Signed-off-by: Yun Min Woo <[email protected]>

* Fix : Improving cookie handling tech #78

- need to improve handling cookie at refreshing main page

* Fix : vulnerability alert resolved  #77

- https://github.com/AgainIoT/Open-Set-Go_client/security/dependabot/3

Signed-off-by: bentshrimp <[email protected]>

* Fix : MainPage isLogin state works well  #78

Signed-off-by: bentshrimp <[email protected]>

* Fix : changed unnecessary if-else into single return statement #78

Signed-off-by: bentshrimp <[email protected]>

* update staging branch (#81)

* Fix : Improving cookie handling tech #78

- need to improve handling cookie at refreshing main page

* Fix : vulnerability alert resolved  #77

- https://github.com/AgainIoT/Open-Set-Go_client/security/dependabot/3

Signed-off-by: bentshrimp <[email protected]>

* Fix : MainPage isLogin state works well  #78

Signed-off-by: bentshrimp <[email protected]>

* Fix : changed unnecessary if-else into single return statement #78

Signed-off-by: bentshrimp <[email protected]>

---------

Signed-off-by: bentshrimp <[email protected]>
Co-authored-by: ymw0407 <[email protected]>

* Fix : remove user info in local storage  #83

- correct the icon src
- remove user info every time user revisit after automatic loggout

Signed-off-by: bentshrimp <[email protected]>

* Add : add react script 'yarn start:win' & 'yarn start:linux' #85

* Feat : Security Policy Updated #87

Signed-off-by: Yun Min Woo <[email protected]>

* Fix : blog -> docs, docs domain changed #88

* Fix : Logo.svg changed to logo.svg(typo error)

Co-authored-by : bent_shrimp <[email protected]>

Signed-off-by: Yun Min Woo <[email protected]>

* Fix : render profile image when only login #83

Signed-off-by: bentshrimp <[email protected]>

* Chore : remove unnecessary import #83

Signed-off-by: bentshrimp <[email protected]>

* Revert "Unexpected bugs fixed"

* Fix : manage login state only in Header #83

Signed-off-by: bentshrimp <[email protected]>

* Chore : remove unused state variable #83

Signed-off-by: bentshrimp <[email protected]>

* Correct old docs url (#100)

Fix : old docs url corrected #98

Signed-off-by: bentshrimp <[email protected]>
Co-authored-by: Yun Min Woo <[email protected]>

---------

Signed-off-by: bentshrimp <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: ymw0407 <[email protected]>
Signed-off-by: Yun Min Woo <[email protected]>
Co-authored-by: bentshrimp <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: bent_shrimp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants