Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿš€ [REQUEST] - Meta Data #65

Closed
1 of 2 tasks
ymw0407 opened this issue Sep 30, 2023 · 4 comments ยท Fixed by #74
Closed
1 of 2 tasks

๐Ÿš€ [REQUEST] - Meta Data #65

ymw0407 opened this issue Sep 30, 2023 · 4 comments ยท Fixed by #74
Assignees
Labels
feature-request feature request ๐Ÿš€

Comments

@ymw0407
Copy link
Member

ymw0407 commented Sep 30, 2023

Describe

As shown in the picture below, the current logo and the name that is open to the outside seem to be included as the react default. There will need to be a correction in that area.
๋ฐ‘์˜ ์‚ฌ์ง„๊ณผ ๊ฐ™์ด ํ˜„์žฌ ๋กœ๊ณ ์™€ ์™ธ๋ถ€์— ๊ณต๊ฐœ๋˜๋Š” ์ด๋ฆ„์ด react ๊ธฐ๋ณธ๊ฐ’์œผ๋กœ ๋“ค์–ด๊ฐ€์žˆ๋Š”๊ฒƒ ๊ฐ™๋‹ค. ํ•ด๋‹น ๋ถ€๋ถ„์— ์žˆ์–ด์„œ ์ˆ˜์ •์„ ํ•ด์•ผํ•  ๊ฒƒ์ด๋‹ค.

image

Reasons

It seems to have a big impact when people try to access the site.
์‚ฌ๋žŒ๋“ค์ด ํ•ด๋‹น ์‚ฌ์ดํŠธ๋ฅผ ์ ‘๊ทผํ•˜๋ ค๊ณ  ํ• ๋•Œ ํฐ ์˜ํ–ฅ์„ ๋ฏธ์น  ๊ฒƒ์œผ๋กœ ๋ณด์ธ๋‹ค.

How to Implement Features

No response

Additional Explanation

No response

Connection

  • Have no effect on other functions
  • Other functions need to be changed
@ymw0407 ymw0407 added the feature-request feature request ๐Ÿš€ label Sep 30, 2023
@ymw0407 ymw0407 changed the title ๐Ÿš€ [REQUEST] - Open-Set-Go ๐Ÿš€ [REQUEST] - Meta Data Sep 30, 2023
bentshrimp added a commit that referenced this issue Sep 30, 2023
Signed-off-by: bentshrimp <[email protected]>
@bentshrimp
Copy link
Contributor

Should the title be "Open Set Go"? or "Open-Set-Go"?

@ymw0407
Copy link
Member Author

ymw0407 commented Sep 30, 2023

I think ... Open-Set-Go is better. But this also seems to be a topic to talk about. Please take a look at the opinions of other maintainers.
์ €๋Š”... Open-Set-Go๊ฐ€ ๋” ์ข‹๋‹ค๊ณ  ์ƒ๊ฐํ•ฉ๋‹ˆ๋‹ค. ํ•˜์ง€๋งŒ ์ด ๋˜ํ•œ ์–˜๊ธฐํ•ด๋ณผ๋งŒํ•œ ์ฃผ์ œ์ธ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค. ๋‹ค๋ฅธ maintainer๋“ค์˜ ์˜๊ฒฌ์€ ์–ด๋– ํ•œ์ง€ ์˜๊ฒฌ ํ•œ๋ฒˆ์”ฉ ๋ถ€ํƒํ•ฉ๋‹ˆ๋‹น.
@AgainIoT/development-team

@ymw0407
Copy link
Member Author

ymw0407 commented Sep 30, 2023

I think it's a good idea to do it with Open-Set-Go.
์šฐ์„ ์€ Open-Set-Go๋กœ ํ•ด๋ณด๋Š”๊ฒŒ ์ข‹์„ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค.

@bentshrimp
Copy link
Contributor

roger that

bentshrimp added a commit that referenced this issue Oct 1, 2023
bentshrimp added a commit that referenced this issue Oct 1, 2023
bentshrimp added a commit that referenced this issue Oct 1, 2023
bentshrimp added a commit that referenced this issue Oct 1, 2023
@bentshrimp bentshrimp linked a pull request Oct 4, 2023 that will close this issue
11 tasks
@ymw0407 ymw0407 mentioned this issue Oct 6, 2023
11 tasks
ymw0407 added a commit that referenced this issue Oct 7, 2023
* Feat : add meta data #65

Signed-off-by: bentshrimp <[email protected]>

* Bump @adobe/css-tools from 4.2.0 to 4.3.1

Bumps [@adobe/css-tools](https://github.com/adobe/css-tools) from 4.2.0 to 4.3.1.
- [Changelog](https://github.com/adobe/css-tools/blob/main/History.md)
- [Commits](https://github.com/adobe/css-tools/commits)

---
updated-dependencies:
- dependency-name: "@adobe/css-tools"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* Fix : Security Priblem occured by nth-check resolved at #71

Signed-off-by: ymw0407 <[email protected]>

* Update : rename title from "Open Set Go" to "Open-Set-Go" #65

Signed-off-by: bentshrimp <[email protected]>

* Update : manifest.json updated with proper icon images #65

Signed-off-by: bentshrimp <[email protected]>

* Remove : unnecessary file, favicon.svg removed #65

Signed-off-by: bentshrimp <[email protected]>

* Fix : icon size setting fixed #65

Signed-off-by: bentshrimp <[email protected]>

* Chore : remove .vscode

Signed-off-by: Yun Min Woo <[email protected]>

* Add : _redirects for netlify CD

Signed-off-by: Yun Min Woo <[email protected]>

* Fix : Improving cookie handling tech #78

- need to improve handling cookie at refreshing main page

* Fix : vulnerability alert resolved  #77

- https://github.com/AgainIoT/Open-Set-Go_client/security/dependabot/3

Signed-off-by: bentshrimp <[email protected]>

* Fix : MainPage isLogin state works well  #78

Signed-off-by: bentshrimp <[email protected]>

* Fix : changed unnecessary if-else into single return statement #78

Signed-off-by: bentshrimp <[email protected]>

* update staging branch (#81)

* Fix : Improving cookie handling tech #78

- need to improve handling cookie at refreshing main page

* Fix : vulnerability alert resolved  #77

- https://github.com/AgainIoT/Open-Set-Go_client/security/dependabot/3

Signed-off-by: bentshrimp <[email protected]>

* Fix : MainPage isLogin state works well  #78

Signed-off-by: bentshrimp <[email protected]>

* Fix : changed unnecessary if-else into single return statement #78

Signed-off-by: bentshrimp <[email protected]>

---------

Signed-off-by: bentshrimp <[email protected]>
Co-authored-by: ymw0407 <[email protected]>

* Fix : remove user info in local storage  #83

- correct the icon src
- remove user info every time user revisit after automatic loggout

Signed-off-by: bentshrimp <[email protected]>

* Add : add react script 'yarn start:win' & 'yarn start:linux' #85

* Feat : Security Policy Updated #87

Signed-off-by: Yun Min Woo <[email protected]>

* Fix : blog -> docs, docs domain changed #88

* Fix : Logo.svg changed to logo.svg(typo error)

Co-authored-by : bent_shrimp <[email protected]>

Signed-off-by: Yun Min Woo <[email protected]>

* Fix : render profile image when only login #83

Signed-off-by: bentshrimp <[email protected]>

* Chore : remove unnecessary import #83

Signed-off-by: bentshrimp <[email protected]>

* Revert "Unexpected bugs fixed"

* Fix : manage login state only in Header #83

Signed-off-by: bentshrimp <[email protected]>

* Chore : remove unused state variable #83

Signed-off-by: bentshrimp <[email protected]>

* Correct old docs url (#100)

Fix : old docs url corrected #98

Signed-off-by: bentshrimp <[email protected]>
Co-authored-by: Yun Min Woo <[email protected]>

---------

Signed-off-by: bentshrimp <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: ymw0407 <[email protected]>
Signed-off-by: Yun Min Woo <[email protected]>
Co-authored-by: bentshrimp <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: bent_shrimp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request feature request ๐Ÿš€
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants