Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The site meta data setting. #74

Merged
merged 5 commits into from
Oct 4, 2023
Merged

The site meta data setting. #74

merged 5 commits into from
Oct 4, 2023

Conversation

bentshrimp
Copy link
Contributor

@bentshrimp bentshrimp commented Oct 4, 2023 •
edited
Loading

Describe changes

The site title and icon changed from default.

Issue number or link

#65

Types of changes

What is the type of code change?
Put an x in the boxes that apply

  • Bugfix (changes that resolve errors)
  • New feature (changes which adds functionality)
  • Breaking change (big changes that affect existing functionality)
  • Documentation Update

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the "README.md"
  • My code follows the style guidelines of this project
  • My changes generate no new warnings
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation
  • Any dependent changes have been merged and published in downstream modules

Further comments

Please let me know if there's anything else to explain

@bentshrimp bentshrimp linked an issue Oct 4, 2023 that may be closed by this pull request
🚀 [REQUEST] - Meta Data #65
Closed
2 tasks
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bentshrimp bentshrimp requested a review from ymw0407 October 4, 2023 12:01
@bentshrimp bentshrimp self-assigned this Oct 4, 2023
ymw0407
ymw0407 approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@ymw0407 ymw0407 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ymw0407 ymw0407 merged commit 5c681ff into main Oct 4, 2023
6 checks passed
@ymw0407 ymw0407 deleted the feature/65 branch October 4, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymw0407 ymw0407 ymw0407 approved these changes

Assignees

@bentshrimp bentshrimp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀 [REQUEST] - Meta Data
2 participants
@bentshrimp @ymw0407