Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 [BUG] - CORS error #120

Closed
1 task done
ymw0407 opened this issue Oct 4, 2023 · 1 comment · Fixed by #122
Closed
1 task done

🐛 [BUG] - CORS error #120

ymw0407 opened this issue Oct 4, 2023 · 1 comment · Fixed by #122
Assignees
@bentshrimp @ymw0407
Labels
bug Something isn't working
Milestone
1.0.1

Comments

@ymw0407
Copy link
Member

ymw0407 commented Oct 4, 2023 •
edited
Loading

Browsers

Chrome

OS

Linux

Description

CORS Error occured by origin: 'https://start.open-set-go.com', so https://start.open-set-go.com will be changed to process.env.origin

Reproduction URL

https://staging--open-set-go.netlify.app/

Reproduction Steps

https://staging--open-set-go.netlify.app/

Solutions

No response

Screenshots

![DESCRIPTION](LINK.png)
@ymw0407 ymw0407 added the bug Something isn't working label Oct 4, 2023
@ymw0407 ymw0407 self-assigned this Oct 4, 2023
ymw0407 added a commit that referenced this issue Oct 4, 2023
@ymw0407
Feat : environment variable ORIGIN added #120
402fc3c
@ymw0407
Copy link
Member Author

ymw0407 commented Oct 4, 2023 •
edited
Loading

+) If server & client has different origin, then cookie cannot be handled at react!
So, we need to add API that can check if client has own valid jwt token!

  • Add Checking Valid JWT Token API

@ymw0407 ymw0407 mentioned this issue Oct 4, 2023
Merged
11 tasks
@ymw0407 ymw0407 linked a pull request Oct 4, 2023 that will close this issue
CORS Error resolved at #120 #122
Merged
11 tasks
ymw0407 added a commit that referenced this issue Oct 4, 2023
@ymw0407
Merge pull request #122 from AgainIoT/feature/120
4110d26 
CORS Error resolved at #120
ymw0407 added a commit that referenced this issue Oct 4, 2023
@ymw0407
CORS error resolved & CD applied (#123)
ab65cd8 
* Revert "Initial Prod Setting #107"

* Feat : environment variable ORIGIN added #120

* Feat: auth/check-token controller created #121

Signed-off-by: ymw0407 <[email protected]>

---------

Signed-off-by: ymw0407 <[email protected]>
ymw0407 added a commit that referenced this issue Oct 4, 2023
@ymw0407
Last Production Test (#124)
fef6fe5 
* Fix : dockerfile permission problem #107

* Fix : --chown=node:node has been removed #113

* Remove : remove unusable CD workflows #107

Signed-off-by: ymw0407 <[email protected]>

* Fix : NODE_ENV removed & control at cloud run

Signed-off-by: ymw0407 <[email protected]>

* CORS error resolved & CD applied (#123)

* Revert "Initial Prod Setting #107"

* Feat : environment variable ORIGIN added #120

* Feat: auth/check-token controller created #121

Signed-off-by: ymw0407 <[email protected]>

---------

Signed-off-by: ymw0407 <[email protected]>

---------

Signed-off-by: ymw0407 <[email protected]>
Signed-off-by: Yun Min Woo <[email protected]>
@ymw0407 ymw0407 mentioned this issue Oct 4, 2023
Closed
2 tasks
ymw0407 added a commit that referenced this issue Oct 6, 2023
@ymw0407 @Kim-Jiyun
Fixed to using at production(Cloud Run & Netlify) (#132)
cee7461 
* Revert "Initial Prod Setting #107"

* Feat : environment variable ORIGIN added #120

* Feat: auth/check-token controller created #121

Signed-off-by: ymw0407 <[email protected]>

* Fix : fix getLicense Service that get wrong pwd #126

Signed-off-by: ymw0407 <[email protected]>
Co-authored-by: Kim-Jiyun <[email protected]>

* Fix : fix formatter error #126

* Fix : reading default issue file logic changed & nest-cli changed #126

Signed-off-by: ymw0407 <[email protected]>

* Fix : nest-cli build without env-template folder error fixed at #125

Signed-off-by: ymw0407 <[email protected]>

* Remove : detach env-template repository's submodule

* Remove : remove env-template folder #125

* Add : add supportedEnv file #125

* Add : React template added #125

* Add : Express template added #125

* Add : NestJS template added #125

* Fix : resolve expressjs security hotspot problems #130

* Fix : reordering code simply

---------

Signed-off-by: ymw0407 <[email protected]>
Co-authored-by: Kim-Jiyun <[email protected]>
@ymw0407 ymw0407 mentioned this issue Oct 6, 2023
Merged
11 tasks
@ymw0407 ymw0407 added this to the 1.0.1 milestone Oct 6, 2023
ymw0407 added a commit that referenced this issue Oct 7, 2023
@ymw0407 @Kim-Jiyun
Open-Set-Go v1.0.1 #107 (#133)
8846785 
* Fix : dockerfile permission problem #107

* Fix : --chown=node:node has been removed #113

* Remove : remove unusable CD workflows #107

Signed-off-by: ymw0407 <[email protected]>

* Fix : NODE_ENV removed & control at cloud run

Signed-off-by: ymw0407 <[email protected]>

* CORS error resolved & CD applied (#123)

* Revert "Initial Prod Setting #107"

* Feat : environment variable ORIGIN added #120

* Feat: auth/check-token controller created #121

Signed-off-by: ymw0407 <[email protected]>

---------

Signed-off-by: ymw0407 <[email protected]>

* Fixed to using at production(Cloud Run & Netlify) (#132)

* Revert "Initial Prod Setting #107"

* Feat : environment variable ORIGIN added #120

* Feat: auth/check-token controller created #121

Signed-off-by: ymw0407 <[email protected]>

* Fix : fix getLicense Service that get wrong pwd #126

Signed-off-by: ymw0407 <[email protected]>
Co-authored-by: Kim-Jiyun <[email protected]>

* Fix : fix formatter error #126

* Fix : reading default issue file logic changed & nest-cli changed #126

Signed-off-by: ymw0407 <[email protected]>

* Fix : nest-cli build without env-template folder error fixed at #125

Signed-off-by: ymw0407 <[email protected]>

* Remove : detach env-template repository's submodule

* Remove : remove env-template folder #125

* Add : add supportedEnv file #125

* Add : React template added #125

* Add : Express template added #125

* Add : NestJS template added #125

* Fix : resolve expressjs security hotspot problems #130

* Fix : reordering code simply

---------

Signed-off-by: ymw0407 <[email protected]>
Co-authored-by: Kim-Jiyun <[email protected]>

---------

Signed-off-by: ymw0407 <[email protected]>
Signed-off-by: Yun Min Woo <[email protected]>
Co-authored-by: Kim-Jiyun <[email protected]>
ymw0407 added a commit that referenced this issue Oct 11, 2023
@ymw0407 @Kim-Jiyun
Feat : Open-Source operational review API added (#144)
d0f82a1 
* Revert "Initial Prod Setting #107"

* Feat : environment variable ORIGIN added #120

* Feat: auth/check-token controller created #121

Signed-off-by: ymw0407 <[email protected]>

* Fix : fix getLicense Service that get wrong pwd #126

Signed-off-by: ymw0407 <[email protected]>
Co-authored-by: Kim-Jiyun <[email protected]>

* Fix : fix formatter error #126

* Fix : reading default issue file logic changed & nest-cli changed #126

Signed-off-by: ymw0407 <[email protected]>

* Fix : nest-cli build without env-template folder error fixed at #125

Signed-off-by: ymw0407 <[email protected]>

* Remove : detach env-template repository's submodule

* Remove : remove env-template folder #125

* Add : add supportedEnv file #125

* Add : React template added #125

* Add : Express template added #125

* Add : NestJS template added #125

* Fix : resolve expressjs security hotspot problems #130

* Fix : reordering code simply

* Feat : Update Security Policy #133

Signed-off-by: Yun Min Woo <[email protected]>

* Feat : getPublicRepo api added #134

Signed-off-by: ymw0407 <[email protected]>

* Docs : API specs added & formatting docs files

* Fix : permission greater than or equal to push can use another api #134

Signed-off-by: ymw0407 <[email protected]>

* Add : senti modules added & senti/template api added #136

Signed-off-by: ymw0407 <[email protected]>

* Fix : Senti module's name changed to Review #136 #137

Signed-off-by: ymw0407 <[email protected]>

* Feat : review community controller added #136 #137

Signed-off-by: ymw0407 <[email protected]>

* Feat : Security review controller added #136 #137

Signed-off-by: ymw0407 <[email protected]>

* Chore : change unusable test indentifier

* Chore : function name changed

* Chore : unusable console log removed

* Feat : review/file controller added & pr, issue, contributing, readme api added #140

* Docs : add review controller's sped

* Docs : review controller's spec added #140

Signed-off-by: ymw0407 <[email protected]>

* Feat : getRepoDetails feature added #142

Signed-off-by: ymw0407 <[email protected]>

* Docs : getRepoDetails's spec added #141

---------

Signed-off-by: ymw0407 <[email protected]>
Signed-off-by: Yun Min Woo <[email protected]>
Co-authored-by: Kim-Jiyun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bentshrimp bentshrimp

@ymw0407 ymw0407

Labels
bug Something isn't working
Projects
None yet
Milestone
1.0.1
Development

Successfully merging a pull request may close this issue.

CORS Error resolved at #120 AgainIoT/Open-Set-Go_server
2 participants
@bentshrimp @ymw0407