Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open-Set-Go v1.0.1 #107 #133

Merged
merged 10 commits into from
Oct 7, 2023
Merged

Open-Set-Go v1.0.1 #107 #133

merged 10 commits into from
Oct 7, 2023

Conversation

ymw0407
Copy link
Member

@ymw0407 ymw0407 commented Oct 6, 2023

Describe changes

  • The deployment environment has been changed from AWS EC2 On-premise to Netflix (client) with CD, Google Cloud Run (server). We have solved all the problems caused by this.
    배포 환경이 AWS EC2 On-premise에서 CD를 적용한 Netlify(client), Google Cloud Run(server)로 변경되었습니다. 이에 따라 발생된 문제들에 대해서 모두 해결하였습니다.

  • Many security vulnerabilities have been addressed as security coding progressed.
    Security coding을 진행함에 따라 많은 보안취약점이 보완되었습니다.

  • Dockerfile was added as the CD was applied.
    CD를 적용함에 따라 Dockerfile이 추가되었습니다.

Issue number or link

Types of changes

What is the type of code change?
Put an x in the boxes that apply

  • Bugfix (changes that resolve errors)
  • New feature (changes which adds functionality)
  • Breaking change (big changes that affect existing functionality)
  • Documentation Update

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the "README.md"
  • My code follows the style guidelines of this project
  • My changes generate no new warnings
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation
  • Any dependent changes have been merged and published in downstream modules

Further comments

Please let me know if there's anything else to explain

ymw0407 and others added 10 commits October 4, 2023 18:18
Fix : dockerfile permission problem #107
Fix : security hotspot related by Docker #113
* Revert "Initial Prod Setting #107"

* Feat : environment variable ORIGIN added #120

* Feat: auth/check-token controller created #121

Signed-off-by: ymw0407 <[email protected]>

---------

Signed-off-by: ymw0407 <[email protected]>
* Revert "Initial Prod Setting #107"

* Feat : environment variable ORIGIN added #120

* Feat: auth/check-token controller created #121

Signed-off-by: ymw0407 <[email protected]>

* Fix : fix getLicense Service that get wrong pwd #126

Signed-off-by: ymw0407 <[email protected]>
Co-authored-by: Kim-Jiyun <[email protected]>

* Fix : fix formatter error #126

* Fix : reading default issue file logic changed & nest-cli changed #126

Signed-off-by: ymw0407 <[email protected]>

* Fix : nest-cli build without env-template folder error fixed at #125

Signed-off-by: ymw0407 <[email protected]>

* Remove : detach env-template repository's submodule

* Remove : remove env-template folder #125

* Add : add supportedEnv file #125

* Add : React template added #125

* Add : Express template added #125

* Add : NestJS template added #125

* Fix : resolve expressjs security hotspot problems #130

* Fix : reordering code simply

---------

Signed-off-by: ymw0407 <[email protected]>
Co-authored-by: Kim-Jiyun <[email protected]>
@ymw0407 ymw0407 added this to the 1.0.1 milestone Oct 6, 2023
@ymw0407 ymw0407 requested a review from a team October 6, 2023 12:17
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

ymw0407 added a commit that referenced this pull request Oct 6, 2023
Copy link
Contributor

@bentshrimp bentshrimp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ymw0407 ymw0407 requested review from a team and Kim-Jiyun and removed request for a team October 6, 2023 16:11
@ymw0407 ymw0407 merged commit 8846785 into production Oct 7, 2023
ymw0407 added a commit that referenced this pull request Oct 11, 2023
* Revert "Initial Prod Setting #107"

* Feat : environment variable ORIGIN added #120

* Feat: auth/check-token controller created #121

Signed-off-by: ymw0407 <[email protected]>

* Fix : fix getLicense Service that get wrong pwd #126

Signed-off-by: ymw0407 <[email protected]>
Co-authored-by: Kim-Jiyun <[email protected]>

* Fix : fix formatter error #126

* Fix : reading default issue file logic changed & nest-cli changed #126

Signed-off-by: ymw0407 <[email protected]>

* Fix : nest-cli build without env-template folder error fixed at #125

Signed-off-by: ymw0407 <[email protected]>

* Remove : detach env-template repository's submodule

* Remove : remove env-template folder #125

* Add : add supportedEnv file #125

* Add : React template added #125

* Add : Express template added #125

* Add : NestJS template added #125

* Fix : resolve expressjs security hotspot problems #130

* Fix : reordering code simply

* Feat : Update Security Policy #133

Signed-off-by: Yun Min Woo <[email protected]>

* Feat : getPublicRepo api added #134

Signed-off-by: ymw0407 <[email protected]>

* Docs : API specs added & formatting docs files

* Fix : permission greater than or equal to push can use another api #134

Signed-off-by: ymw0407 <[email protected]>

* Add : senti modules added & senti/template api added #136

Signed-off-by: ymw0407 <[email protected]>

* Fix : Senti module's name changed to Review #136 #137

Signed-off-by: ymw0407 <[email protected]>

* Feat : review community controller added #136 #137

Signed-off-by: ymw0407 <[email protected]>

* Feat : Security review controller added #136 #137

Signed-off-by: ymw0407 <[email protected]>

* Chore : change unusable test indentifier

* Chore : function name changed

* Chore : unusable console log removed

* Feat : review/file controller added & pr, issue, contributing, readme api added #140

* Docs : add review controller's sped

* Docs : review controller's spec added #140

Signed-off-by: ymw0407 <[email protected]>

* Feat : getRepoDetails feature added #142

Signed-off-by: ymw0407 <[email protected]>

* Docs : getRepoDetails's spec added #141

---------

Signed-off-by: ymw0407 <[email protected]>
Signed-off-by: Yun Min Woo <[email protected]>
Co-authored-by: Kim-Jiyun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants