-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open-Set-Go v1.0.1 #107 #133
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix : dockerfile permission problem #107
Fix : security hotspot related by Docker #113
Signed-off-by: ymw0407 <[email protected]>
Signed-off-by: ymw0407 <[email protected]>
GCP Cloud Run CD
Signed-off-by: Yun Min Woo <[email protected]>
* Revert "Initial Prod Setting #107" * Feat : environment variable ORIGIN added #120 * Feat: auth/check-token controller created #121 Signed-off-by: ymw0407 <[email protected]> --------- Signed-off-by: ymw0407 <[email protected]>
* Revert "Initial Prod Setting #107" * Feat : environment variable ORIGIN added #120 * Feat: auth/check-token controller created #121 Signed-off-by: ymw0407 <[email protected]> * Fix : fix getLicense Service that get wrong pwd #126 Signed-off-by: ymw0407 <[email protected]> Co-authored-by: Kim-Jiyun <[email protected]> * Fix : fix formatter error #126 * Fix : reading default issue file logic changed & nest-cli changed #126 Signed-off-by: ymw0407 <[email protected]> * Fix : nest-cli build without env-template folder error fixed at #125 Signed-off-by: ymw0407 <[email protected]> * Remove : detach env-template repository's submodule * Remove : remove env-template folder #125 * Add : add supportedEnv file #125 * Add : React template added #125 * Add : Express template added #125 * Add : NestJS template added #125 * Fix : resolve expressjs security hotspot problems #130 * Fix : reordering code simply --------- Signed-off-by: ymw0407 <[email protected]> Co-authored-by: Kim-Jiyun <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
ymw0407
added a commit
that referenced
this pull request
Oct 6, 2023
Signed-off-by: Yun Min Woo <[email protected]>
bentshrimp
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ymw0407
requested review from
a team and
Kim-Jiyun
and removed request for
a team
October 6, 2023 16:11
Kim-Jiyun
approved these changes
Oct 7, 2023
ymw0407
added a commit
that referenced
this pull request
Oct 11, 2023
* Revert "Initial Prod Setting #107" * Feat : environment variable ORIGIN added #120 * Feat: auth/check-token controller created #121 Signed-off-by: ymw0407 <[email protected]> * Fix : fix getLicense Service that get wrong pwd #126 Signed-off-by: ymw0407 <[email protected]> Co-authored-by: Kim-Jiyun <[email protected]> * Fix : fix formatter error #126 * Fix : reading default issue file logic changed & nest-cli changed #126 Signed-off-by: ymw0407 <[email protected]> * Fix : nest-cli build without env-template folder error fixed at #125 Signed-off-by: ymw0407 <[email protected]> * Remove : detach env-template repository's submodule * Remove : remove env-template folder #125 * Add : add supportedEnv file #125 * Add : React template added #125 * Add : Express template added #125 * Add : NestJS template added #125 * Fix : resolve expressjs security hotspot problems #130 * Fix : reordering code simply * Feat : Update Security Policy #133 Signed-off-by: Yun Min Woo <[email protected]> * Feat : getPublicRepo api added #134 Signed-off-by: ymw0407 <[email protected]> * Docs : API specs added & formatting docs files * Fix : permission greater than or equal to push can use another api #134 Signed-off-by: ymw0407 <[email protected]> * Add : senti modules added & senti/template api added #136 Signed-off-by: ymw0407 <[email protected]> * Fix : Senti module's name changed to Review #136 #137 Signed-off-by: ymw0407 <[email protected]> * Feat : review community controller added #136 #137 Signed-off-by: ymw0407 <[email protected]> * Feat : Security review controller added #136 #137 Signed-off-by: ymw0407 <[email protected]> * Chore : change unusable test indentifier * Chore : function name changed * Chore : unusable console log removed * Feat : review/file controller added & pr, issue, contributing, readme api added #140 * Docs : add review controller's sped * Docs : review controller's spec added #140 Signed-off-by: ymw0407 <[email protected]> * Feat : getRepoDetails feature added #142 Signed-off-by: ymw0407 <[email protected]> * Docs : getRepoDetails's spec added #141 --------- Signed-off-by: ymw0407 <[email protected]> Signed-off-by: Yun Min Woo <[email protected]> Co-authored-by: Kim-Jiyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe changes
The deployment environment has been changed from AWS EC2 On-premise to Netflix (client) with CD, Google Cloud Run (server). We have solved all the problems caused by this.
배포 환경이 AWS EC2 On-premise에서 CD를 적용한 Netlify(client), Google Cloud Run(server)로 변경되었습니다. 이에 따라 발생된 문제들에 대해서 모두 해결하였습니다.
Many security vulnerabilities have been addressed as security coding progressed.
Security coding을 진행함에 따라 많은 보안취약점이 보완되었습니다.
Dockerfile was added as the CD was applied.
CD를 적용함에 따라 Dockerfile이 추가되었습니다.
Issue number or link
Types of changes
What is the type of code change?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
Please let me know if there's anything else to explain