Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ› [BUG] - SupportedEnv API not worked at Production environment #125

Closed
ymw0407 opened this issue Oct 4, 2023 · 0 comments Β· Fixed by #129
Closed

πŸ› [BUG] - SupportedEnv API not worked at Production environment #125

ymw0407 opened this issue Oct 4, 2023 · 0 comments Β· Fixed by #129
Assignees
@ymw0407 @Kim-Jiyun
Labels
bug Something isn't working
Milestone
1.0.1

Comments

@ymw0407
Copy link
Member

ymw0407 commented Oct 4, 2023

Browsers

Firefox, Chrome, Safari, Microsoft Edge, Opera

OS

Windows, Linux, Mac

Description

The methods currently distributed to the server are as follows.
ν˜„μž¬ μ„œλ²„μ— λ°°ν¬λ˜λŠ” 방식은 λ‹€μŒκ³Ό κ°™λ‹€.

commit at staging or production -> cloud build(packing & deploying) -> cloud run

Here, the process of commit -> cloud build proceeds through the continuous deployment option of cloud run. When distributing on-premises, submodules could be pulled and used with commands such as 'git clone --recursive https://github.com/AgainIoT/Open-Set-Go_server ', but Cloud Run does not proceed with this process.
μ—¬κΈ°μ„œ commit -> cloud build의 과정은 cloud run의 지속적인 배포 μ˜΅μ…˜μ„ ν†΅ν•΄μ„œ μ§„ν–‰λœλ‹€. μ˜¨ν”„λ ˆλ―ΈμŠ€λ‘œ 배포λ₯Ό μ§„ν–‰ν–ˆμ„λ•ŒλŠ”, git clone --recursive https://github.com/AgainIoT/Open-Set-Go_server와 같은 μ»€λ§¨λ“œλ‘œ submodule듀을 λŒμ–΄μ™€μ„œ μ‚¬μš©ν•  수 μžˆμ—ˆμ§€λ§Œ, Cloud Runμ—μ„œλŠ” 이 과정을 진행해주지 μ•ŠλŠ”λ‹€.

Accordingly, we intend to remove the method of importing supportedEnv through the submodule and develop it in a way that is embedded in the repository.
이에 따라, submodule을 ν†΅ν•΄μ„œ supportedEnvλ₯Ό κ°€μ Έμ˜€λŠ” 방식을 μ œκ±°ν•˜κ³  ν•΄λ‹Ή repository에 λ‚΄μž₯ν•˜λŠ” λ°©μ‹μœΌλ‘œ κ°œλ°œν•˜κ³ μž ν•œλ‹€.

Reproduction URL

https://open-set-go-stage-kbplnuaeba-du.a.run.app/file/supportedEnv

Reproduction Steps

https://open-set-go-stage-kbplnuaeba-du.a.run.app/file/supportedEnv

Solutions

remove git submodule & strengthening `supporting environment's` Security

Screenshots

![DESCRIPTION](LINK.png)
@ymw0407 ymw0407 added the bug Something isn't working label Oct 4, 2023
@ymw0407 ymw0407 assigned ymw0407 and Kim-Jiyun and unassigned Kim-Jiyun Oct 4, 2023
@ymw0407 ymw0407 changed the title πŸ› [BUG] - SupportedEnv API not worked at Production env πŸ› [BUG] - SupportedEnv API not worked at Production environment Oct 4, 2023
@ymw0407 ymw0407 mentioned this issue Oct 4, 2023
Closed
4 tasks
ymw0407 added a commit that referenced this issue Oct 6, 2023
@ymw0407
Fix : nest-cli build without env-template folder error fixed at #125
9510e4e 
Signed-off-by: ymw0407 <[email protected]>
ymw0407 added a commit that referenced this issue Oct 6, 2023
@ymw0407
Remove : remove env-template folder #125
cf61a24
ymw0407 pushed a commit that referenced this issue Oct 6, 2023
@Kim-Jiyun
Add : add supportedEnv file #125
cbdd9e8
ymw0407 pushed a commit that referenced this issue Oct 6, 2023
@Kim-Jiyun
Add : React template added #125
7c47f22
ymw0407 pushed a commit that referenced this issue Oct 6, 2023
@Kim-Jiyun
Add : Express template added #125
4126cd3
ymw0407 pushed a commit that referenced this issue Oct 6, 2023
@Kim-Jiyun
Add : NestJS template added #125
4c50ffb
@ymw0407 ymw0407 linked a pull request Oct 6, 2023 that will close this issue
Fixe : SupportedEnv API not worked at Production environment error resolved at #125 #129
Merged
11 tasks
@ymw0407 ymw0407 mentioned this issue Oct 6, 2023
Merged
11 tasks
ymw0407 added a commit that referenced this issue Oct 6, 2023
@ymw0407
Merge pull request #129 from AgainIoT/feature/125
06fba6c 
Fixe : SupportedEnv API not worked at Production environment error resolved at #125
ymw0407 added a commit that referenced this issue Oct 6, 2023
@ymw0407 @Kim-Jiyun
Fixed to using at production(Cloud Run & Netlify) (#132)
cee7461 
* Revert "Initial Prod Setting #107"

* Feat : environment variable ORIGIN added #120

* Feat: auth/check-token controller created #121

Signed-off-by: ymw0407 <[email protected]>

* Fix : fix getLicense Service that get wrong pwd #126

Signed-off-by: ymw0407 <[email protected]>
Co-authored-by: Kim-Jiyun <[email protected]>

* Fix : fix formatter error #126

* Fix : reading default issue file logic changed & nest-cli changed #126

Signed-off-by: ymw0407 <[email protected]>

* Fix : nest-cli build without env-template folder error fixed at #125

Signed-off-by: ymw0407 <[email protected]>

* Remove : detach env-template repository's submodule

* Remove : remove env-template folder #125

* Add : add supportedEnv file #125

* Add : React template added #125

* Add : Express template added #125

* Add : NestJS template added #125

* Fix : resolve expressjs security hotspot problems #130

* Fix : reordering code simply

---------

Signed-off-by: ymw0407 <[email protected]>
Co-authored-by: Kim-Jiyun <[email protected]>
@ymw0407 ymw0407 mentioned this issue Oct 6, 2023
Merged
11 tasks
@ymw0407 ymw0407 added this to the 1.0.1 milestone Oct 6, 2023
ymw0407 added a commit that referenced this issue Oct 7, 2023
@ymw0407 @Kim-Jiyun
Open-Set-Go v1.0.1 #107 (#133)
8846785 
* Fix : dockerfile permission problem #107

* Fix : --chown=node:node has been removed #113

* Remove : remove unusable CD workflows #107

Signed-off-by: ymw0407 <[email protected]>

* Fix : NODE_ENV removed & control at cloud run

Signed-off-by: ymw0407 <[email protected]>

* CORS error resolved & CD applied (#123)

* Revert "Initial Prod Setting #107"

* Feat : environment variable ORIGIN added #120

* Feat: auth/check-token controller created #121

Signed-off-by: ymw0407 <[email protected]>

---------

Signed-off-by: ymw0407 <[email protected]>

* Fixed to using at production(Cloud Run & Netlify) (#132)

* Revert "Initial Prod Setting #107"

* Feat : environment variable ORIGIN added #120

* Feat: auth/check-token controller created #121

Signed-off-by: ymw0407 <[email protected]>

* Fix : fix getLicense Service that get wrong pwd #126

Signed-off-by: ymw0407 <[email protected]>
Co-authored-by: Kim-Jiyun <[email protected]>

* Fix : fix formatter error #126

* Fix : reading default issue file logic changed & nest-cli changed #126

Signed-off-by: ymw0407 <[email protected]>

* Fix : nest-cli build without env-template folder error fixed at #125

Signed-off-by: ymw0407 <[email protected]>

* Remove : detach env-template repository's submodule

* Remove : remove env-template folder #125

* Add : add supportedEnv file #125

* Add : React template added #125

* Add : Express template added #125

* Add : NestJS template added #125

* Fix : resolve expressjs security hotspot problems #130

* Fix : reordering code simply

---------

Signed-off-by: ymw0407 <[email protected]>
Co-authored-by: Kim-Jiyun <[email protected]>

---------

Signed-off-by: ymw0407 <[email protected]>
Signed-off-by: Yun Min Woo <[email protected]>
Co-authored-by: Kim-Jiyun <[email protected]>
ymw0407 added a commit that referenced this issue Oct 11, 2023
@ymw0407 @Kim-Jiyun
Feat : Open-Source operational review API added (#144)
d0f82a1 
* Revert "Initial Prod Setting #107"

* Feat : environment variable ORIGIN added #120

* Feat: auth/check-token controller created #121

Signed-off-by: ymw0407 <[email protected]>

* Fix : fix getLicense Service that get wrong pwd #126

Signed-off-by: ymw0407 <[email protected]>
Co-authored-by: Kim-Jiyun <[email protected]>

* Fix : fix formatter error #126

* Fix : reading default issue file logic changed & nest-cli changed #126

Signed-off-by: ymw0407 <[email protected]>

* Fix : nest-cli build without env-template folder error fixed at #125

Signed-off-by: ymw0407 <[email protected]>

* Remove : detach env-template repository's submodule

* Remove : remove env-template folder #125

* Add : add supportedEnv file #125

* Add : React template added #125

* Add : Express template added #125

* Add : NestJS template added #125

* Fix : resolve expressjs security hotspot problems #130

* Fix : reordering code simply

* Feat : Update Security Policy #133

Signed-off-by: Yun Min Woo <[email protected]>

* Feat : getPublicRepo api added #134

Signed-off-by: ymw0407 <[email protected]>

* Docs : API specs added & formatting docs files

* Fix : permission greater than or equal to push can use another api #134

Signed-off-by: ymw0407 <[email protected]>

* Add : senti modules added & senti/template api added #136

Signed-off-by: ymw0407 <[email protected]>

* Fix : Senti module's name changed to Review #136 #137

Signed-off-by: ymw0407 <[email protected]>

* Feat : review community controller added #136 #137

Signed-off-by: ymw0407 <[email protected]>

* Feat : Security review controller added #136 #137

Signed-off-by: ymw0407 <[email protected]>

* Chore : change unusable test indentifier

* Chore : function name changed

* Chore : unusable console log removed

* Feat : review/file controller added & pr, issue, contributing, readme api added #140

* Docs : add review controller's sped

* Docs : review controller's spec added #140

Signed-off-by: ymw0407 <[email protected]>

* Feat : getRepoDetails feature added #142

Signed-off-by: ymw0407 <[email protected]>

* Docs : getRepoDetails's spec added #141

---------

Signed-off-by: ymw0407 <[email protected]>
Signed-off-by: Yun Min Woo <[email protected]>
Co-authored-by: Kim-Jiyun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ymw0407 ymw0407

@Kim-Jiyun Kim-Jiyun

Labels
bug Something isn't working
Projects
None yet
Milestone
1.0.1
2 participants
@ymw0407 @Kim-Jiyun