-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding support for Python 3.10 #1231
Conversation
There are changes that need to be done regarding manylinux formats for 3.10 Lines 308 to 324 in 73ee393
|
Thank you @sridhar562345 , changes added 😉 |
any update? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🔥
After approving the tests failed: can you look into those Lint errors in the build? Can I support in any way to fix those?
I assume when you run make black
and make isort
the lint errors wil be fixed.
@hellno sure, give me a couple of hours. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious as to why all of format changes?
Is this the result of running black on previously untouched code? Or, is this the result of a local dev environment configuration?
Unfortunately it looks like the |
The new version of Black has added new code format guidelines, so some blank lines have been removed. |
As @sridhar562345 said, something in the update of |
You asked for it 😉 --> #1239 |
Rebased on top of #1239 to use pytest for tests |
Strange that 3.7/3.8 coverage is down... can you find a way to add a couple of simple testcases to bump up the coverage? |
@monkut the reason for the coverage decrease is here: https://coveralls.io/jobs/120605047/source_files/7598797035#L213 We added specific lines of code for python 3.9 or 3.10, so more lines, but less executed code when on 3.7, 3.8. |
I just saw 0.57.0 has release 🎉 |
…zappa-0.57.0 * commit '0b1eab14ca39c3a3bfb4e915347e07495171dcba': (27 commits) updating workflow actions to remove deprecation warnings (zappa#1243) 📝 CHANGELOG.md update for 0.57.0 (zappa#1246) fixing compatibility with Django 4.2 (zappa#1237) Update Readme with patreon and donors (zappa#1234) adding support for Python 3.10 (zappa#1231) Nose to pytest (zappa#1239) lint: updating code style with `make black` (zappa#1238) Alternative way to check if running in Docker (zappa#1204) 📝 CHANGELOG.md update for 0.56.0 release (zappa#1187) Improve `get_best_match_zone()` to match by most matched components instead of by length of domain (zappa#1193) Bypass python version runtime check when code run in docker (zappa#1180) Be able to pass in a batch window when using batch size (zappa#1118) Correction to README. (zappa#1177) (zappa#908) Update BINARY_SUPPORT to use Content-Encoding to identify if data is binary (zappa#1155) Remove special check for Django<1.7, fix for zappa#1158 (zappa#1159) Resolve (zappa#410) Logs are missing query strings (zappa#1165) Handle spaces in x-forwared-for/remove six (zappa#1127) (zappa#1163) add feature (zappa#704) Check if args/kwargs are JSON Serializable while running locally (zappa#1154) docs: Add documentation for s3 event object key_filters (zappa#1169) Add feature pyenv virtualenv detecting .python-version file (zappa#1153) ... # Conflicts: # zappa/cli.py
Ref #1160, #1124