Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle optional space in x-forwarded-for header #1127

Closed
naresh-uplight opened this issue Apr 25, 2022 · 2 comments
Closed

Handle optional space in x-forwarded-for header #1127

naresh-uplight opened this issue Apr 25, 2022 · 2 comments
Assignees
@monkut
Labels
has-pr next-release-candidate

Comments

@naresh-uplight
Copy link

Zappa/zappa/wsgi.py

Line 105 in a1e842c

remote_addr = x_forwarded_for.split(", ")[-2]

As per the MDN docs the whitespace is optional and I have a case where the request errors because of that.
This was referenced Apr 25, 2022
Merged
Closed
@monkut monkut self-assigned this Aug 8, 2022
monkut added a commit that referenced this issue Aug 10, 2022
@monkut
✨ Handle spaces in x-forwared-for (#1127)
31b5de4
@monkut monkut mentioned this issue Aug 10, 2022
Merged
monkut added a commit that referenced this issue Oct 6, 2022
@monkut
Handle spaces in x-forwared-for/remove six (#1127) (#1163)
d47a4da 
* ✨ Handle spaces in x-forwared-for (#1127)

* 🔥 remove `six` (no longer needed as 2.x is no longer supported)

* ✅ add testcase for SUPPORTED_VERSION check to increase code coverage.

* 🎨 run black/isort

* 🔧 rename function for clarity

* 🔥 remove unnecessary import

* 🔧 change name of unused mock instance

* ✨ (#879) Fix url decoding for query string

* 🔧 change docstring type multi-line comment to standard multiline comment
✨ handle case where "requestContext" is not provided by the event.

> Systems calling the Lambda (other than API Gateway) may not provide the field requestContext in the event.

✅ add testcases

* 🔥 remove duplicate comment

* 📝 add docstring to util function, `get_unsupported_sys_versioninfo()`

* 🔥 remove double-underscore
@monkut
Copy link
Collaborator

monkut commented Oct 13, 2022

handled in pr #1127 closing.

@monkut monkut closed this as completed Oct 13, 2022
@monkut monkut mentioned this issue Nov 12, 2022
Merged
monkut added a commit that referenced this issue Nov 24, 2022
@monkut
Bypass python version runtime check when code run in docker (#1180)
72c5dc3 
* ✨ Handle spaces in x-forwared-for (#1127)

* 🔥 remove `six` (no longer needed as 2.x is no longer supported)

* ✅ add testcase for SUPPORTED_VERSION check to increase code coverage.

* 🎨 run black/isort

* 🔧 rename function for clarity

* 🔥 remove unnecessary import

* 🔧 change name of unused mock instance

* ✨ (#879) Fix url decoding for query string

* 🔧 change docstring type multi-line comment to standard multiline comment
✨ handle case where "requestContext" is not provided by the event.

> Systems calling the Lambda (other than API Gateway) may not provide the field requestContext in the event.

✅ add testcases

* 🔥 remove duplicate comment

* 📝 add docstring to util function, `get_unsupported_sys_versioninfo()`

* ✨ Add any python version support in the case where code is run in docker

* 🎨 run black/isort

* ✅ fix testcase
✅ update testcase to output the full filepath of file you are expected to compare the README.md to.

* 🔧 Add python minor version check when using docker.

* 🎨 fix flake8

* 🔧 don't limit the upper version of zappa on setup.  Internal checks will perform version check, but docker based installs shouldn't be capped.
@monkut
Copy link
Collaborator

monkut commented Dec 1, 2022

released in 0.56.0, closing.

Ian288 pushed a commit to tackle-io/Zappa that referenced this issue Jul 11, 2023
@monkut @Ian288
Handle spaces in x-forwared-for/remove six (zappa#1127) (zappa#1163)
7fe267f 
* ✨ Handle spaces in x-forwared-for (zappa#1127)

* 🔥 remove `six` (no longer needed as 2.x is no longer supported)

* ✅ add testcase for SUPPORTED_VERSION check to increase code coverage.

* 🎨 run black/isort

* 🔧 rename function for clarity

* 🔥 remove unnecessary import

* 🔧 change name of unused mock instance

* ✨ (zappa#879) Fix url decoding for query string

* 🔧 change docstring type multi-line comment to standard multiline comment
✨ handle case where "requestContext" is not provided by the event.

> Systems calling the Lambda (other than API Gateway) may not provide the field requestContext in the event.

✅ add testcases

* 🔥 remove duplicate comment

* 📝 add docstring to util function, `get_unsupported_sys_versioninfo()`

* 🔥 remove double-underscore
Ian288 pushed a commit to tackle-io/Zappa that referenced this issue Jul 11, 2023
@monkut @Ian288
Bypass python version runtime check when code run in docker (zappa#1180)
7cb1e17 
* ✨ Handle spaces in x-forwared-for (zappa#1127)

* 🔥 remove `six` (no longer needed as 2.x is no longer supported)

* ✅ add testcase for SUPPORTED_VERSION check to increase code coverage.

* 🎨 run black/isort

* 🔧 rename function for clarity

* 🔥 remove unnecessary import

* 🔧 change name of unused mock instance

* ✨ (zappa#879) Fix url decoding for query string

* 🔧 change docstring type multi-line comment to standard multiline comment
✨ handle case where "requestContext" is not provided by the event.

> Systems calling the Lambda (other than API Gateway) may not provide the field requestContext in the event.

✅ add testcases

* 🔥 remove duplicate comment

* 📝 add docstring to util function, `get_unsupported_sys_versioninfo()`

* ✨ Add any python version support in the case where code is run in docker

* 🎨 run black/isort

* ✅ fix testcase
✅ update testcase to output the full filepath of file you are expected to compare the README.md to.

* 🔧 Add python minor version check when using docker.

* 🎨 fix flake8

* 🔧 don't limit the upper version of zappa on setup.  Internal checks will perform version check, but docker based installs shouldn't be capped.
BarNehemia added a commit to Lightricks/Zappa that referenced this issue Aug 10, 2023
@BarNehemia
Merge commit '0b1eab14ca39c3a3bfb4e915347e07495171dcba' into upgrade-…
93295d2 
…zappa-0.57.0

* commit '0b1eab14ca39c3a3bfb4e915347e07495171dcba': (27 commits)
  updating workflow actions to remove deprecation warnings (zappa#1243)
  📝 CHANGELOG.md update for 0.57.0 (zappa#1246)
  fixing compatibility with Django 4.2 (zappa#1237)
  Update Readme with patreon and donors (zappa#1234)
  adding support for Python 3.10 (zappa#1231)
  Nose to pytest (zappa#1239)
  lint: updating code style with `make black` (zappa#1238)
  Alternative way to check if running in Docker (zappa#1204)
  📝 CHANGELOG.md update for 0.56.0 release (zappa#1187)
  Improve `get_best_match_zone()` to match by most matched components instead of by length of domain (zappa#1193)
  Bypass python version runtime check when code run in docker (zappa#1180)
  Be able to pass in a batch window when using batch size (zappa#1118)
  Correction to README. (zappa#1177)
  (zappa#908) Update BINARY_SUPPORT to use Content-Encoding to identify if data is binary (zappa#1155)
  Remove special check for Django<1.7, fix for zappa#1158  (zappa#1159)
  Resolve (zappa#410) Logs are missing query strings (zappa#1165)
  Handle spaces in x-forwared-for/remove six (zappa#1127) (zappa#1163)
  add feature (zappa#704) Check if args/kwargs are JSON Serializable while running locally (zappa#1154)
  docs: Add documentation for s3 event object key_filters (zappa#1169)
  Add feature pyenv virtualenv detecting .python-version file (zappa#1153)
  ...

# Conflicts:
#	zappa/cli.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@monkut monkut

Labels
has-pr next-release-candidate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@monkut @naresh-uplight