Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve (#410) Logs are missing query strings #1165

Merged
merged 8 commits into from
Oct 22, 2022

Conversation

monkut
Copy link
Collaborator

@monkut monkut commented Aug 16, 2022

Description

♻️ migrate utilities based tests from tests.py to tests_utilities.py
🔥 remove wsgi-request-logger dependency (appears to no longer be maintained) and bring formatter functionality into zappa
✨ add ApacheNCSAFormatter to replace wsgi-request-logger functionality.

GitHub Issues

#410

@coveralls
Copy link

coveralls commented Aug 16, 2022

Coverage Status

Coverage increased (+0.3%) to 74.063% when pulling 305389b on feature/issue-410-add-query-strings-to-logs into d47a4da on master.

Copy link
Collaborator

@hellno hellno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳💪🏼 looks great to me!

@monkut monkut merged commit 8effb63 into master Oct 22, 2022
Ian288 pushed a commit to tackle-io/Zappa that referenced this pull request Jul 11, 2023
* ✅ migrate utilities based tests from `tests.py` to `tests_utilities.py`

* 🔥 remove `wsgi-request-logger` dependency (appears to no longer be maintained) and bring formatter functionality into zappa
✨ add `ApacheNCSAFormatter` to replace wsgi-request-logger functionality.

* 🔧 black is no longer in 'beta', changing allow_prereleases to false.
BarNehemia added a commit to Lightricks/Zappa that referenced this pull request Aug 10, 2023
…zappa-0.57.0

* commit '0b1eab14ca39c3a3bfb4e915347e07495171dcba': (27 commits)
  updating workflow actions to remove deprecation warnings (zappa#1243)
  📝 CHANGELOG.md update for 0.57.0 (zappa#1246)
  fixing compatibility with Django 4.2 (zappa#1237)
  Update Readme with patreon and donors (zappa#1234)
  adding support for Python 3.10 (zappa#1231)
  Nose to pytest (zappa#1239)
  lint: updating code style with `make black` (zappa#1238)
  Alternative way to check if running in Docker (zappa#1204)
  📝 CHANGELOG.md update for 0.56.0 release (zappa#1187)
  Improve `get_best_match_zone()` to match by most matched components instead of by length of domain (zappa#1193)
  Bypass python version runtime check when code run in docker (zappa#1180)
  Be able to pass in a batch window when using batch size (zappa#1118)
  Correction to README. (zappa#1177)
  (zappa#908) Update BINARY_SUPPORT to use Content-Encoding to identify if data is binary (zappa#1155)
  Remove special check for Django<1.7, fix for zappa#1158  (zappa#1159)
  Resolve (zappa#410) Logs are missing query strings (zappa#1165)
  Handle spaces in x-forwared-for/remove six (zappa#1127) (zappa#1163)
  add feature (zappa#704) Check if args/kwargs are JSON Serializable while running locally (zappa#1154)
  docs: Add documentation for s3 event object key_filters (zappa#1169)
  Add feature pyenv virtualenv detecting .python-version file (zappa#1153)
  ...

# Conflicts:
#	zappa/cli.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants