-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update __init__.py #1219
Update __init__.py #1219
Conversation
Update to incorporate python 3.10.
+1 |
😂😂😂 |
Hi @katomaso and @moriisaac , if you're using docker with Zappa then you can use any version of python, even 2.7 or 3.11 too. |
It's true that AWS does not support even 3.10 yet so this is a bit preliminary. But we could merge it still, no? |
Can you tell us what exactly you are trying to achieve with this?
…On Sun, 19 Feb 2023, 4:41 pm Tomáš Peterka, ***@***.***> wrote:
It's true that AWS does not support even 3.10 yet so this is a bit
preliminary. But we could merge it still, no?
—
Reply to this email directly, view it on GitHub
<#1219 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOEJV3QAIBICKJRYIU3R22TWYH5URANCNFSM6AAAAAAUVV7MUY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
@@ -12,7 +12,7 @@ def running_in_docker() -> bool: | |||
return running_in_docker_flag | |||
|
|||
|
|||
SUPPORTED_VERSIONS = [(3, 7), (3, 8), (3, 9)] | |||
SUPPORTED_VERSIONS = [(3, 7), (3, 8), (3, 9),(3,10)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know zappa well so I'm not sure if 3.10 is a supported version,
but I think it would be nice to have a blank space.
before
SUPPORTED_VERSIONS = [(3, 7), (3, 8), (3, 9),(3,10)]
after
SUPPORTED_VERSIONS = [(3, 7), (3, 8), (3, 9), (3, 10)]
This value is used to define the aws provided lambda python runtime. As of 2023/3/1, python 3.9 is the latest supported runtime provided by aws. As @souravjamwal77 mentioned, if you want to use another python release, you can create and provide a docker image with your desired version. When you provide a docker image for usage, the defined When AWS provides a 3.10, or 3.11 runtime we'll get a patch release out as soon as we can to support it. |
As mentioned AWS does not yet provide a python 3.10 (or 3.11) runtime. There may be more, but this needs to be updated: https://github.com/zappa/Zappa/blob/master/zappa/utilities.py#L206-L216 And related testcase added: https://github.com/zappa/Zappa/blob/master/tests/tests.py#L144-L169 Support for the 3.10 runtime is tracked in the following issue: |
Update to incorporate python 3.10.
Description
GitHub Issues