Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update __init__.py #1219

Closed
wants to merge 1 commit into from
Closed

Update __init__.py #1219

wants to merge 1 commit into from

Conversation

moriisaac
Copy link

Update to incorporate python 3.10.

Description

GitHub Issues

Update to incorporate python 3.10.
@katomaso
Copy link

+1

@moriisaac
Copy link
Author

😂😂😂

@souravjamwal77
Copy link
Collaborator

Hi @katomaso and @moriisaac , if you're using docker with Zappa then you can use any version of python, even 2.7 or 3.11 too.

@katomaso
Copy link

It's true that AWS does not support even 3.10 yet so this is a bit preliminary. But we could merge it still, no?

@sridhar562345
Copy link
Contributor

sridhar562345 commented Feb 19, 2023 via email

@@ -12,7 +12,7 @@ def running_in_docker() -> bool:
return running_in_docker_flag


SUPPORTED_VERSIONS = [(3, 7), (3, 8), (3, 9)]
SUPPORTED_VERSIONS = [(3, 7), (3, 8), (3, 9),(3,10)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know zappa well so I'm not sure if 3.10 is a supported version,
but I think it would be nice to have a blank space.

before
SUPPORTED_VERSIONS = [(3, 7), (3, 8), (3, 9),(3,10)]

after
SUPPORTED_VERSIONS = [(3, 7), (3, 8), (3, 9), (3, 10)]

@monkut
Copy link
Collaborator

monkut commented Mar 1, 2023

This value is used to define the aws provided lambda python runtime. As of 2023/3/1, python 3.9 is the latest supported runtime provided by aws.
https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html

As @souravjamwal77 mentioned, if you want to use another python release, you can create and provide a docker image with your desired version. When you provide a docker image for usage, the defined SUPPORTED_VERSIONS here is by-passed.

When AWS provides a 3.10, or 3.11 runtime we'll get a patch release out as soon as we can to support it.

@monkut
Copy link
Collaborator

monkut commented Mar 5, 2023

As mentioned AWS does not yet provide a python 3.10 (or 3.11) runtime.
If you want to go ahead and add preliminary support there are more updates and testcases need.

There may be more, but this needs to be updated:

https://github.com/zappa/Zappa/blob/master/zappa/utilities.py#L206-L216

And related testcase added:

https://github.com/zappa/Zappa/blob/master/tests/tests.py#L144-L169

Support for the 3.10 runtime is tracked in the following issue:
#1160

@hellno
Copy link
Collaborator

hellno commented May 3, 2023

If anyone wants to follow the PR for python 3.10 support: #1231
the issue is tracked in #1160

@hellno hellno closed this May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants