Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tslint indent #1

Merged

Commits on Dec 19, 2017

  1. Configuration menu
    Copy the full SHA
    3ca9f8c View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2017

  1. Configuration menu
    Copy the full SHA
    3c702fb View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2018

  1. Configuration menu
    Copy the full SHA
    cfa76a2 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2018

  1. Configuration menu
    Copy the full SHA
    88d6a14 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2018

  1. Configuration menu
    Copy the full SHA
    a7f0537 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2018

  1. Configuration menu
    Copy the full SHA
    08441bf View commit details
    Browse the repository at this point in the history
  2. refactor: removed 'export = Linter` in linter.ts (palantir#3438)

    [no-log] This doesn't change our public API.
    ajafff authored and adidahiya committed Jan 9, 2018
    Configuration menu
    Copy the full SHA
    5155583 View commit details
    Browse the repository at this point in the history
  3. no-unsafe-any: allow object spread (palantir#3439)

    [bugfix] `no-unsafe-any` allows spreading an `any`-value into an object
    ajafff authored and adidahiya committed Jan 9, 2018
    Configuration menu
    Copy the full SHA
    6dfa0f6 View commit details
    Browse the repository at this point in the history
  4. callable-types: add parens inside ArrayType (palantir#3440)

    [bugfix] `callable-types` adds parentheses when fixing a type literal inside an array type
    ajafff authored and adidahiya committed Jan 9, 2018
    Configuration menu
    Copy the full SHA
    93fef3a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5256228 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e2d929d View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    4c29dd9 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    9bfc582 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    7a9f177 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    7a2bfbd View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    18fc973 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    8b853b2 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2018

  1. Added no-dynamic-delete rule (palantir#3573)

    Josh Goldberg authored and adidahiya committed Jan 10, 2018
    Configuration menu
    Copy the full SHA
    82bf779 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ef28083 View commit details
    Browse the repository at this point in the history
  3. [new-rule] newline-per-chained-call (palantir#3278)

    aervin_ authored and adidahiya committed Jan 10, 2018
    Configuration menu
    Copy the full SHA
    4117f16 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d9e20be View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b0061e7 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b5ebb9f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    2b8a737 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    a4dc874 View commit details
    Browse the repository at this point in the history
  9. Prepare release 5.9.1

    adidahiya committed Jan 10, 2018
    Configuration menu
    Copy the full SHA
    235561e View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2018

  1. Remove buffers noAssert argument (palantir#3770)

    The support for the `noAssert` argument dropped in the upcoming
    Node.js version 10.x and the argument should be removed therefore.
    BridgeAR authored and ajafff committed Apr 1, 2018
    Configuration menu
    Copy the full SHA
    f1b0896 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2018

  1. Configuration menu
    Copy the full SHA
    01cf478 View commit details
    Browse the repository at this point in the history
  2. Update index.md (palantir#3773)

    JSON cannot have dangling comma
    Chia-Lun Wu (Leo) authored and suchanlee committed Apr 2, 2018
    Configuration menu
    Copy the full SHA
    569d8da View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2018

  1. Improve documentation of cli flag --project (palantir#3703)

    The current documentation of the cli flag `--project` is a little confusing as to which the path of a file or the path of a directory can be specified.
    
    As both are valid options, updating the documentation to make it clear that either the path to a `tsconfig.json` file or the path to a directory containing a `tsconfig.json` file can be specified.
    a-xin authored and johnwiseheart committed Apr 5, 2018
    Configuration menu
    Copy the full SHA
    8716315 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b381eab View commit details
    Browse the repository at this point in the history
  3. Fixed "manging" typo in no-this-assignment (palantir#3673)

    Josh Goldberg authored and johnwiseheart committed Apr 5, 2018
    Configuration menu
    Copy the full SHA
    124311b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2bb6aa9 View commit details
    Browse the repository at this point in the history
  5. Update for docs/usage/configuration/index.md (palantir#3661)

    Added fix for text issue
    Victor Belozyorov authored and johnwiseheart committed Apr 5, 2018
    Configuration menu
    Copy the full SHA
    f904497 View commit details
    Browse the repository at this point in the history
  6. Added 2 (+/-1) sentence rationales for 2/3 of rules (palantir#3734)

    * Added a couple extra docs lines to align
    
    * Added a couple extra docs lines to arrow-return-shorthand
    
    * Added a couple extra docs lines to await-promise
    
    * Added a couple extra docs lines to binary-expression-operand-order
    
    * Added a couple extra docs to class-name
    
    * Added a couple extra docs to completed-docs
    
    * Added another doc line to cyclomatic-complexity
    
    * Switch link to https in eofline
    
    * Added a couple extra docs to for-in
    
    * Added a couple extra docs to member-access
    
    * Added a couple extra docs to member-ordering
    
    * Added a couple extra docs to no-any
    
    * Added a couple extra docs to no-boolean-literal-compare
    
    * Added a couple extra docs to no-consecutive-blank-lines
    
    * Added a couple extra docs to no-dynamic-delete
    
    * Added a couple extra docs to no-floating-promises
    
    * Added a couple extra docs to no-inferred-empty-object-type
    
    * Added a brief rationale to no-invalid-template-strings-rule
    
    * Typo correction on no-magic-numbers
    
    * Added a couple extra docs to no-misused-new
    
    * Added a couple extra docs to no-non-null-assertion
    
    * Added a couple extra docs to no-null-keyword
    
    * Added a couple extra docs to no-parameter-properties
    
    * Added a couple extra docs to no-shadowed-variable
    
    * Added a couple extra docs to no-string-throw
    
    * Added a couple extra docs to no-this-assignment
    
    * Added a couple extra docs to no-unbound-method
    
    * Added a couple extra docs to no-unnecessary-callback-wrapper
    
    * Added a couple extra docs to no-unnecessary-initializer
    
    * Added a couple extra docs to no-unsafe-any
    
    * Added a couple extra docs to no-unused-variable
    
    * Added a couple extra docs to no-var-keyword
    
    * Added a couple extra docs to no-var-requires
    
    * Added a couple extra docs to no-void-expression
    
    * Added a couple extra docs to number-literal-format
    
    * Missing dedent in no-non-null-assertion
    Josh Goldberg authored and johnwiseheart committed Apr 5, 2018
    Configuration menu
    Copy the full SHA
    42b058a View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2018

  1. Build tslint with TypeScript 2.7.2. (palantir#3819)

    * Build tslint with TypeScript 2.7.2.
    
    Updates the package.json, fixes some compiler issues where some typescript APIs changed, and makes 2 rules work under 2.7.2.
    
    * Fixes from code review.
    
    Fixed a lint issue (' => ").
    Actually checked for undefined, instead of just asserting.
    LucasSloan authored and suchanlee committed Apr 6, 2018
    Configuration menu
    Copy the full SHA
    8e13390 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2018

  1. promise-function-async: add options to specify function types to chec…

    …k. (palantir#3807)
    
    This is useful if you only want your function and method declarations
    to warn, or in other words, one doesn't want each arrow function that
    is passed to Promise#then() or Promise#catch() to be async.
    blair authored and suchanlee committed Apr 7, 2018
    Configuration menu
    Copy the full SHA
    375de6d View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2018

  1. Used bang in file-header (palantir#3741)

    Josh Goldberg authored and johnwiseheart committed Apr 9, 2018
    Configuration menu
    Copy the full SHA
    c89e0a7 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2018

  1. Clarified lint message "All imports are unused." (palantir#3831)

    Changed to: "All imports on this line are unused"
    jishi9 authored and suchanlee committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    e27439f View commit details
    Browse the repository at this point in the history
  2. Updated max-line-length ignore-pattern example (palantir#3834)

    The example uses:
    
    ```
    class [a-zA-Z] implements 
    ```
    
    but this only matches a class that has a single character as name. Even if it is an example, the rule should accept more than one character for the class name. I struggled with this ignore pattern in a project, because I didn't read the pattern itself completely. Therefore I want to give this feedback, such that other people don't have to search for the reason of a failing rule, like me.
    Janis Koehr authored and suchanlee committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    fb0da64 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2018

  1. Configuration menu
    Copy the full SHA
    0c24e91 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2018

  1. [docs] adds optional capability to provide code examples in rules' me…

    …tadata (palantir#3602)
    
    * codeExample support init implementation
    
    * dedent/markdown errors need revisting
    
    * updates to new code example scheme as per ajafff
    
    * reverts prettier style updates in curly
    
    * curly docs he -> they
    
    * ICodeExample config type any -> string
    
    * Code example blocks now color-coded according to pass/fail (grn/red)
    
    * updates to buildDocs
    
    * gemfile.lock??; removes unnecessary html/scss
    
    * removes site dist
    
    * moving code examples to dedicated dir to avoid bloat in rule files
    
    * removing _site dir
    aervin_ authored and suchanlee committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    5c86dd4 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2018

  1. Fix build (palantir#3853)

    * fix non-no-unused-variable tests
    
    * Fix no-unused-variables tests and modify logic in noUnusedVariableRule for TS2.8 support
    
    Logic had to be modified because starting from TS2.8, when all imports in an import node are not used,
    TS emits only 1 diagnostic object for the whole line as opposed to the previous behavior of outputting
    a diagnostic with kind == 6192 (UnusedKind.VARIABLE_OR_PARAMETER) for every unused import.
    
    * fix lint issue
    
    * hack/fix check-parameters test for 2.9-dev
    
    * add builds for ts 2.7 and 2.8
    
    * fix tests that broke from diagnosis codes changing in 2.9
    suchanlee authored Apr 26, 2018
    Configuration menu
    Copy the full SHA
    a7be726 View commit details
    Browse the repository at this point in the history
  2. Removed *nix-only comment from package.json (palantir#3858)

    It feels self-evident that `lint:global` as a task would lint everything with the global TSLint install.
    Josh Goldberg authored and suchanlee committed Apr 26, 2018
    Configuration menu
    Copy the full SHA
    f399c3c View commit details
    Browse the repository at this point in the history
  3. [new-fixer]: Add space before comment message fixer (palantir#3845)

    * [new-fixer]: Add space before comment message fixer
    
    * Add space-before-comment test
    tanniiz authored and suchanlee committed Apr 26, 2018
    Configuration menu
    Copy the full SHA
    6bc44a2 View commit details
    Browse the repository at this point in the history
  4. Added rule+file-specific error messages to rule crashes (palantir#3836)

    * Added rule+file-specific error messages to rule crashes
    
    It's not clear where tests for this should live. Would you like me to add some, and if so where?
    
    * Added endline; no more unnecessary duplication
    Josh Goldberg authored and suchanlee committed Apr 26, 2018
    Configuration menu
    Copy the full SHA
    49399eb View commit details
    Browse the repository at this point in the history

Commits on May 1, 2018

  1. Adding documentation example to deprecationRule (palantir#3848)

    This adds documentation example to the deprecation rule.
    felipeissa authored and suchanlee committed May 1, 2018
    Configuration menu
    Copy the full SHA
    37dddca View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9af0b65 View commit details
    Browse the repository at this point in the history
  3. [docs] no-string-throw: add missing examples. (palantir#3701)

    * [docs] no-string-throw: add missing examples.
    
    * [docs] no-string-throw: examples for rationale.
    
    * Code example section for no-string-throw.
    BB9z authored and suchanlee committed May 1, 2018
    Configuration menu
    Copy the full SHA
    921bd43 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0503f6d View commit details
    Browse the repository at this point in the history
  5. no-unbound-method: add another exception (palantir#3610)

    Reading a property with square brackets, though rare, should be allowed because it won't be effected by an unbound this.
    ethanresnick authored and giladgray committed May 1, 2018
    Configuration menu
    Copy the full SHA
    f47aeb3 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2018

  1. Fix completed-docs rule (palantir#3868)

    - Fixes building of master
    - Add escaping to backticks introduced in palantir#3823
    rwaskiewicz authored and suchanlee committed May 2, 2018
    Configuration menu
    Copy the full SHA
    7682184 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2018

  1. [new-rule]prefer-while rule (palantir#3750)

    * prefer-while rule
    
    Implements prefer-while rule in place of a for loop without an initializer and incrementer
    
    * renamed failure object creation method
    
    * fix json test file indentatons
    
    * Address review comments
    
     
    - Use isForStatement from tsutils
    - Update failure string to be more descriptive
    - Updated test messages
    
    * remove uneccessary type assertion
    
    - assertion now uneccessary with using isForStatement from tsutils
    
    * Add rationale field to prefer-while rule metadata
    
    * Use 'let' instead of 'const' in test
    
    * Update rule description & failure string
    
    - Updated the description and failure string of prefer-while
    - Updated tests accordingly
    
    * Coalesce test cases
    
    - Combine test cases for 'bad' for loops and case for 'good' for loops
    - Remove unneeded files
    - Add comments to test cases
    
    * Add additional test cases
    
    - Added test case with incrmentor in body of loop
    - Added test case with += incrementor
    
    * Add code examples
    
    - Added code examples for prefer-while rule
    rwaskiewicz authored and suchanlee committed May 3, 2018
    Configuration menu
    Copy the full SHA
    baa413e View commit details
    Browse the repository at this point in the history
  2. Improve "no valid rules" error message to include file type (palantir…

    …#3729)
    
    * Improve "no valid rules" error message to include file type
    
    * Lint
    OliverJAsh authored and giladgray committed May 3, 2018
    Configuration menu
    Copy the full SHA
    c86193f View commit details
    Browse the repository at this point in the history
  3. Excluded native JSX elements from no-unsafe-any (palantir#3699)

    * Excluded native JSX elements from no-unsafe-any
    
    * Lint fix: double-apostrophe
    
    Interesting how TypeScript auto-added single-apostrophes...
    
    * ...almost working..
    
    * Split no-unsafe-any into separate tests
    
    * Added test cases for fragments
    
    * Added case for TS2.1 and fragments
    Josh Goldberg authored and giladgray committed May 3, 2018
    Configuration menu
    Copy the full SHA
    93fd0ac View commit details
    Browse the repository at this point in the history
  4. Prepare release 5.10.0 (palantir#3871)

    * Prepare release 5.10.0
    jkillian authored May 3, 2018
    Configuration menu
    Copy the full SHA
    ecab88c View commit details
    Browse the repository at this point in the history

Commits on May 4, 2018

  1. Configuration menu
    Copy the full SHA
    e181237 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    895fd6c View commit details
    Browse the repository at this point in the history