Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Improve "no valid rules" error message to include file type #3729

Merged

Conversation

OliverJAsh
Copy link
Contributor

@OliverJAsh OliverJAsh commented Feb 21, 2018

PR checklist

  • Addresses an existing issue: #0000
  • New feature, bugfix, or enhancement
    • Includes tests
  • Documentation update

Overview of change:

When adding tslint to a project I was confused by the error message "No valid rules have been specified", even though I did specify valid rules, and those rules were working.

It turns out this was because I had not defined any jsRules and I was linting JS files.

This PR improves the error messaging to make that clearer.

Is there anything you'd like reviewers to focus on?

CHANGELOG.md entry:

@palantirtech
Copy link
Member

Thanks for your interest in palantir/tslint, @OliverJAsh! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@OliverJAsh
Copy link
Contributor Author

Any updates on this?

Build is failing with:

/bin/bash: yarn: command not found
Exited with code 127

@suchanlee
Copy link
Contributor

@OliverJAsh can you try merging master into your branch and see if we can get the build to run?

@OliverJAsh
Copy link
Contributor Author

Hi @suchanlee, done!

@giladgray giladgray merged commit c86193f into palantir:master May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants