This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Improve "no valid rules" error message to include file type #3729
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
When adding tslint to a project I was confused by the error message "No valid rules have been specified", even though I did specify valid rules, and those rules were working.
It turns out this was because I had not defined any
jsRules
and I was linting JS files.This PR improves the error messaging to make that clearer.
Is there anything you'd like reviewers to focus on?
CHANGELOG.md entry: