This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
The support for the
noAssert
argument dropped in the upcomingNode.js version 10.x and the argument should be removed therefore.
I would call it a bug fix. It can be argued against that just as well though.
Refs: nodejs/node#18395
Is there anything you'd like reviewers to focus on?
I was not able to compile anything and was not able to run the tests therefore.
I always got the following error:
CHANGELOG.md entry:
Not sure what to choose here...