Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Remove buffers noAssert argument #3770

Merged
merged 1 commit into from
Apr 1, 2018
Merged

Remove buffers noAssert argument #3770

merged 1 commit into from
Apr 1, 2018

Conversation

BridgeAR
Copy link
Contributor

PR checklist

  • Addresses an existing issue: #0000
  • New feature, bugfix, or enhancement
    • Includes tests
  • Documentation update

Overview of change:

The support for the noAssert argument dropped in the upcoming
Node.js version 10.x and the argument should be removed therefore.
I would call it a bug fix. It can be argued against that just as well though.

Refs: nodejs/node#18395

Is there anything you'd like reviewers to focus on?

I was not able to compile anything and was not able to run the tests therefore.
I always got the following error:

node_modules/tsutils/typeguard/type.d.ts(15,73): error TS2694: Namespace 'ts' has no exported member 'UniqueESSymbolType'.

CHANGELOG.md entry:

Not sure what to choose here...

The support for the `noAssert` argument dropped in the upcoming
Node.js version 10.x and the argument should be removed therefore.
@palantirtech
Copy link
Member

Thanks for your interest in palantir/tslint, @BridgeAR! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@BridgeAR
Copy link
Contributor Author

Ping

@BridgeAR
Copy link
Contributor Author

BridgeAR commented Apr 1, 2018

Ping @adidahiya @ajafff

@ajafff ajafff merged commit f1b0896 into palantir:master Apr 1, 2018
@ajafff
Copy link
Contributor

ajafff commented Apr 1, 2018

Thanks @BridgeAR

For posterity: you need to use yarn to install dependencies (as decribed in README.md in the repository root). That way the correct lockfile is used. You'll then be able to compile and test locally.

HyphnKnight pushed a commit to HyphnKnight/tslint that referenced this pull request Apr 9, 2018
The support for the `noAssert` argument dropped in the upcoming
Node.js version 10.x and the argument should be removed therefore.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants