This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Removes trailing whitespace from file-header #3802
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
The rule
file-header
does not play nice withno-trailing-whitespace
if the file header includes blank lines. For example, after applyingfile-header
with--fix
, you might end up with something like this:Note the trailing whitespace on the
*
lines. This means you would have to runtslint --fix
twice to get the desired result.This PR adds a simple solution of right-trimming each line of the file header.
Is there anything you'd like reviewers to focus on?
CHANGELOG.md entry:
[bugfix] Makes rule
file-header
play nice with ruleno-trailing-whitespace