-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new-log-viewer: Add ClpIrDecoder
.
#62
Conversation
ClpIrDecoder
with ClpStreamReader
from clp-ffi-js
integration.
/** | ||
* The end index for specifying full range when the exact number of log events is unknown. | ||
*/ | ||
const FULL_RANGE_END_IDX: number = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about LOG_EVENT_FILE_END_IDX
?
Let's file an issue for this so we don't forget. |
Co-authored-by: kirkrodrigues <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the PR title, how about:
new-log-viewer: Add ClpIrDecoder
.
Reported in #64 |
ClpIrDecoder
with ClpStreamReader
from clp-ffi-js
integration.ClpIrDecoder
.
@kirkrodrigues please trigger the merge from your end |
References
new-log-viewer series: #45 #46 #48 #51 #52 #53 #54 #55 #56 #59 #60 #61
Description
clp-ffi-js
as a dependency.ClpIrDecoder
.buildIdx()
in LogFileManager's constructor to deserialize the whole input file.Validation performed
" "
) JSONL decoder options does not affect the correct behaviours of the CLP Stream decoder.