Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new-log-viewer: Add support for loading files through open dialog or drag-and-drop; Display file name in the UI. #56

Merged
merged 22 commits into from
Sep 2, 2024
Merged

new-log-viewer: Add support for loading files through open dialog or drag-and-drop; Display file name in the UI. #56

merged 22 commits into from
Sep 2, 2024

Conversation

junhaoliao
Copy link
Member

@junhaoliao junhaoliao commented Aug 19, 2024 •
edited
Loading

References

new-log-viewer series: #45 #46 #48 #51 #52 #53 #54 #55

Description

  1. Add local file load support.
  2. Display file name in the UI.

Validation performed

  1. Referred to the validation steps in Add support for loading files, decoding them as JSONL, and formatting them using a Logback-like format string. #46 to start the debug server.
  2. Clicked button "Open File" and selected example.jsonl in the file open dialog.
  3. Observed the file getting loaded with logEventNum set to the last event in the log file.
  4. Changed value in logEventNum debug input box to 1 and observed the first page got loaded.

@junhaoliao junhaoliao marked this pull request as ready for review August 19, 2024 21:26
@junhaoliao junhaoliao changed the title new-log-viewer: Add local file load support. new-log-viewer: Add support for loading local files. Aug 19, 2024
@junhaoliao junhaoliao changed the title new-log-viewer: Add support for loading local files. new-log-viewer: Add support for loading local files and display file name in the UI. Aug 19, 2024
@junhaoliao junhaoliao mentioned this pull request Aug 20, 2024
Closed
@Henry8192 Henry8192 mentioned this pull request Aug 23, 2024
Merged
@junhaoliao junhaoliao mentioned this pull request Aug 28, 2024
Merged
kirkrodrigues
kirkrodrigues requested changes Aug 30, 2024
View reviewed changes
new-log-viewer/src/utils/file.ts Outdated Show resolved Hide resolved
new-log-viewer/src/utils/file.ts Outdated Show resolved Hide resolved
new-log-viewer/src/contexts/StateContextProvider.tsx Show resolved Hide resolved
new-log-viewer/src/components/DropFileContainer/index.tsx Outdated Show resolved Hide resolved
new-log-viewer/src/components/DropFileContainer/index.css Outdated Show resolved Hide resolved
new-log-viewer/src/components/DropFileContainer/index.css Outdated Show resolved Hide resolved
new-log-viewer/src/components/DropFileContainer/index.tsx Outdated Show resolved Hide resolved
new-log-viewer/src/components/DropFileContainer/index.tsx Outdated Show resolved Hide resolved
new-log-viewer/src/components/DropFileContainer/index.tsx Outdated Show resolved Hide resolved
new-log-viewer/src/components/DropFileContainer/index.tsx Outdated Show resolved Hide resolved
@junhaoliao junhaoliao mentioned this pull request Sep 1, 2024
Merged
kirkrodrigues
kirkrodrigues approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@kirkrodrigues kirkrodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the PR title, how about:

new-log-viewer: Add support for loading files through open dialog or drag-and-drop; Display file name in the UI.

@junhaoliao junhaoliao changed the title new-log-viewer: Add support for loading local files and display file name in the UI. new-log-viewer: Add support for loading files through open dialog or drag-and-drop; Display file name in the UI. Sep 2, 2024
@junhaoliao junhaoliao merged commit 4b65341 into y-scope:main Sep 2, 2024
@junhaoliao junhaoliao mentioned this pull request Sep 2, 2024
Closed
This was referenced Sep 11, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@davemarco davemarco mentioned this pull request Sep 25, 2024
Merged
This was referenced Sep 26, 2024
Merged
Merged
This was referenced Sep 27, 2024
Merged
Merged
This was referenced Sep 30, 2024
Merged
Merged
Merged
@davemarco davemarco mentioned this pull request Oct 4, 2024
Merged
@Henry8192 Henry8192 mentioned this pull request Oct 7, 2024
Merged
This was referenced Oct 14, 2024
Merged
Merged
Merged
Merged
Merged
This was referenced Oct 22, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirkrodrigues kirkrodrigues kirkrodrigues approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@junhaoliao @kirkrodrigues