Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new-log-viewer: LogbackFormatter: Only insert timestamp if date pattern was specified. #53

Merged
merged 1 commit into from
Aug 16, 2024
Merged

new-log-viewer: LogbackFormatter: Only insert timestamp if date pattern was specified. #53

merged 1 commit into from
Aug 16, 2024

Conversation

junhaoliao
Copy link
Member

References

#46 added support for decoding JSONL files. One issue was found that when the "formatString" does not include a date pattern, the formatted message still include formatted dates.

Description

  1. Do not format date if no date pattern is specified in configured format string.

Validation performed

  1. Loaded Log Viewer with example jsonl file.
    image
    Screenshot showing the formatted messages with dates
  2. In config debug form, configured decoderOptions/formatString with value [%process.thread.name] %log.level %message%n, which is the default with the date pattern %d{yyyy-MM-dd HH:mm:ss.SSS} removed from the beginning.
  3. Applied the config. After the page was reloaded, observed that the formatted messages no longer includes dates.
    image
    Screenshot showing the formatted messages do not include dates because now no such is configured in decoderOptions/formatString

@junhaoliao junhaoliao changed the title new-log-viewer: do not format date if no date pattern is specified in configured format string. new-log-viewer: do not format date if no date pattern is specified in format string. Aug 16, 2024
@junhaoliao junhaoliao changed the title new-log-viewer: do not format date if no date pattern is specified in format string. new-log-viewer: LogbackFormatter: do not format date if no date pattern is specified in format string. Aug 16, 2024
kirkrodrigues
kirkrodrigues approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@kirkrodrigues kirkrodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the PR title, how about:

new-log-viewer: LogbackFormatter: Only insert timestamp if date pattern was specified.

@junhaoliao junhaoliao changed the title new-log-viewer: LogbackFormatter: do not format date if no date pattern is specified in format string. new-log-viewer: LogbackFormatter: Only insert timestamp if date pattern was specified. Aug 16, 2024
@junhaoliao junhaoliao merged commit adc313a into y-scope:main Aug 16, 2024
This was referenced Aug 17, 2024
Merged
Merged
Merged
Closed
@Henry8192 Henry8192 mentioned this pull request Aug 23, 2024
Merged
This was referenced Aug 28, 2024
Merged
Merged
Closed
This was referenced Sep 11, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@davemarco davemarco mentioned this pull request Sep 25, 2024
Merged
This was referenced Sep 26, 2024
Merged
Merged
This was referenced Sep 27, 2024
Merged
Merged
This was referenced Sep 30, 2024
Merged
Merged
@junhaoliao junhaoliao mentioned this pull request Oct 3, 2024
Merged
@davemarco davemarco mentioned this pull request Oct 4, 2024
Merged
@Henry8192 Henry8192 mentioned this pull request Oct 7, 2024
Merged
This was referenced Oct 14, 2024
Merged
Merged
Merged
Merged
Merged
This was referenced Oct 22, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirkrodrigues kirkrodrigues kirkrodrigues approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@junhaoliao @kirkrodrigues