Fix a bug #2
Closed
Fix a bug #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…M_API_PY3 (#6344) Remove the build time dependency on SONIC_PLATFORM_API_PY2 and SONIC_PLATFORM_API_PY3 from xcvrd make rule
- Why I did it - Reboot cause prints "Non-Hardware (N/A)" instead of showing the software reboot cause. The issue is mishandling of hardware reboot cause in determine-reboot-cause script. - How I did it Fixed the handling for Non Hardware reboot cause. Ignore if Non-Hardware is present in the hardware_reboot_cause output. Added some code refactoring for simplicity. - How to verify it - With fix, the hardware reboot cause is ignored (if it is non hw):
**- Why I did it** I'm updating the jinja2 template to support getting SNMP information from the redis configdb. I'm using the format approved here: sonic-net/SONiC#718 This will pave the way for us to decrement using the snmp.yml in the future. Right now we will still be using both the snmp.yml and configdb to get variable information in order to create the snmpd.conf via the sonic-cfggen tool. **- How I did it** I first updated the SNMP Schema in PR #718 to get that approved as a standardized format. Then I verified I could add snmp configs to the configdb using this standard schema. Once the configs were added to the configdb then I updated the snmpd.conf.j2 file to support the updates via the configdb while still using the variables in the snmp.yml file in parallel. This way we will have backward compatibility until we can fully migrate to the configdb only. By updating the snmpd.conf.j2 template and running the sonic-cfggen tool the snmpd.conf gets generated with using the values in both the configdb and snmp.yml file. Co-authored-by: trvanduy <[email protected]>
…6351) Enable the notify mode of rsyslogd imfile module used for supervisord logs in docker container. Setup the mode="inotify" when loading imfile, made sure we are are getting supervisord logs in host immediately. Signed-off-by: Abhishek Dosi <[email protected]>
To incldue following changes: - [ci]: add build for arm64 and armhf (#757) - Use template hgetall, because we will tune the return types of library functions (#759) - [syncd] Fix bulk multi attrs for same key db update (#761) Signed-off-by: Ying Xie <[email protected]>
- Dynamically change EEPROM driver based on media type. - Otherwise, EEPROM INFO and DOM INFO might not be fetched properly and will result in erroneous output.
…ebian (#6114) Sonic devices advertise meaningful system description along with Debian package information. before the fix: ------------- admin@sonic:~$ show lldp neighbors ------------------------------------------------------------------------------- LLDP neighbors: ------------------------------------------------------------------------------- Interface: Ethernet0, via: LLDP, RID: 3, Time: 0 day, 16:36:30 SysName: sonic SysDescr: Debian GNU/Linux 9 (stretch) Linux 4.9.0-11-2-amd64 #1 SMP Debian 4.9.189-3+deb9u2 (2019-11-11) x86_64 ------------------------------------------------------------------------------- After the fix: root@sonic:~# show lldp neighbors Ethernet16 ------------------------------------------------------------------------------- LLDP neighbors: ------------------------------------------------------------------------------- Interface: Ethernet16, via: LLDP, RID: 10, Time: 0 day, 00:01:00 SysName: sonic SysDescr: SONiC Software Version: SONiC.sonic_upstream_1.0_daily_201130_1501_62-dirty-20201130.203529 - HwSku: Accton-AS7816-64X - Distribution: Debian 10.6 - Kernel: 4.19.0-9-2-amd64 ------------------------------------------------------------------------------- Signed-off-by: sudhanshukumar22 <[email protected]>
) src/sonic-platform-common 9935fca...8664efc (2): Make sonic_sfp Python2 and Python3 compatible (#157) [sffbase.py] Fix to make Python 3-compatible (#156) src/sonic-platform-daemons e6c786b...81318f7 (1): [psud] Fix issue where PSU Fan info is not updated in State DB (#137) Fixes #6341
…6364) * [platform][Nokia]: Add buffers and qos files for config qos reload - providing required files * [platform][armhf]: remove hardcoded disable for Telemetry on armhf Co-authored-by: Carl Keene <[email protected]>
Updated imfile configuration for supervisord logs for stretch and buster.
…xpected queue causing _brcm_sai_switch_assert () after warm reboot (#6374) Starting from build (master) 176 the warm reboot on BRCM Platform started to experience syncd crash. Upon further debug by Ying it was determined that the crash was related to the following new change: [Dynamic buffer calc] Support dynamic buffer calculation (#1338) Ying also debugged further and found The crash was caused by buffer pool profile setting operation SAI_BUFFER_PROFILE_ATTR_SHARED_DYNAMIC_TH A case has filed with BRCM while a potential fix was tried by Ying that seems to have addressed this issue and we are making this change available in master branch so that it will allow further feature validation/testing especially in the warm reboot area. Once an official fix is provided by BRCM, we will then remove this in house fix and apply the official fix. - How to verify it Just perform warm reboot with any master code 175 or above you should see this issue or issue the following cmd will also cause the crash: "mmuconfig -p egress_lossy_profile -a 0"
Pass universal_newlines=True parameter to subprocess.Popen(); no longer use .encode('utf-8') on resulting stdout.
This was missed in #5886
Note: I would prefer to use text=True instead of universal_newlines=True, as the former is an alias only available in Python 3 and is more understandable than the latter. However, Even though the setup.py file for this package only specifies Python 3, the LGTM tool finds other Python 2 code in the repo and validates the code as Python 2 code and alerts that text=True is an invalid parameter. Will stick with universal_newlines=True for now. Once all Python code in the repo has been converted to Python 3, I will change all universal_newlines=True to text=True.
Signed-off-by: Danny Allen <[email protected]>
- Make PDDF code compliant with both Python 2 and Python 3 - Align code with PEP8 standards using autopep8 - Build and install both Python 2 and Python 3 PDDF packages
…ade (#6285) In scenario where upgrade gets config from minigraph, it could miss tacacs credentials as they are not in minigraph. Hence restore explicitly upon load-minigraph, if present. - Why I did it Upon boot, when config migration is required, the switch could load config from minigraph. The config-load from minigraph would wipe off TACACS key and disable login via TACACS, which would disable all remote user access. This change, would re-configure the TACACS if there is a saved copy available. - How I did it When config is loaded from minigraph, look for a TACACS credentials back up (tacacs.json) under /etc/sonic/old_config. If present, load the credentials into running config, before config-save is called. - How to verify it Remove /etc/sonic/config_db.json and do an image update. Upon reboot, w/o this change, you would not be able ssh in as remote user. You may login as admin and check out, "show tacacs" & "show aaa" to verify that tacacs-key is missing and login is not enabled for tacacs. With this change applied, remove /etc/sonic/config_db.json, but save tacacs & aaa credentials as tacacs.json in /etc/sonic/. Upon reboot, you should see remote user access possible.
**- Why I did it** This PR aims to monitor the running status of each container. Currently the auto-restart feature was enabled. If a critical process exited unexpected, the container will be restarted. If the container was restarted 3 times during 20 minutes, then it will not run anymore unless we cleared the flag using the command `sudo systemctl reset-failed <container_name>` manually. **- How I did it** We will employ Monit to monitor a script. This script will generate the expected running container list and compare it with the current running containers. If there are containers which were expected to run but were not running, then an alerting message will be written into syslog. **- How to verify it** I tested this feature on a lab device `str-a7050-acs-3` which has single ASIC and `str2-n3164-acs-3` which has a Multi-ASIC. First I manually stopped a container by running the command `sudo systemctl stop <container_name>`, then I checked whether there was an alerting message in the syslog. Signed-off-by: Yong Zhao <[email protected]>
* Use 20 and 30 route-map entries instead of 2 and 3 for TSA * Added support for dynamic "Allow list" default action. Co-authored-by: Pavel Shirshov <[email protected]>
Includes sonic-swss-common commits: ``` 71dc350 2021-01-07 | Lower the log level for outdated key for SubscriberStateTable notification (#441) [Qi Luo] 7e40582 2021-01-08 | Add boost dependencies (#442) [Ze Gan] 30a8ddf 2021-01-05 | Change DBConnector::hgetall return type from map to unordered_map (#440) [Qi Luo] 021108d 2021-01-02 | MCLAG Enhancements per HLD sonic-net/SONiC#596 (#405) [Praveen-Brcm] 54996fc 2021-01-02 | Implement ConfigDBConnector and ConfigDBPipeConnector in C++ (#437) [Qi Luo] 8286525 2020-12-27 | Simply refactor DBConnector hgetall() [Qi Luo] 6d1d33b 2020-12-27 | Fix RedisTransactioner: handle empty deque [Qi Luo] 624e0b8 2020-12-26 | Move complex class constructor as explicit, and fix several mistaken copy constructor usage [Qi Luo] 3b983f9 2020-12-30 | [ci]: add timeout to 180 minutes for arm build (#439) [lguohan] f2e4210 2020-12-29 | Add utility for string and redis (#434) [Ze Gan] 7a885fd 2020-12-29 | [build]: add build check for arm64 and armhf (#436) [lguohan] 47bccc4 2020-12-24 | Add missed vector header to rediscommand.h (#435) [Ze Gan] ```
Bumps [lxml](https://github.com/lxml/lxml) from 4.6.1 to 4.6.2. - [Release notes](https://github.com/lxml/lxml/releases) - [Changelog](https://github.com/lxml/lxml/blob/master/CHANGES.txt) - [Commits](lxml/lxml@lxml-4.6.1...lxml-4.6.2) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…try on ARM64 (#6386) * Enable telemetry for ARM64 by default * [Centec]Upgrade Centec syncd docker to buster; libjemalloc2 have been installed in docker-base-buster, remove libjemalloc1 from docker-syncd-centec's Dockerfile.j2 Co-authored-by: Gu Xianghong <[email protected]>
- Cleanup and Refactor of library internals, logic mostly unchanged. - Enhance debugability with `arista dump` and `arista diag` commands. - Fix power supply detection issue.
The HLD about MACsec feature is at : https://github.com/Azure/SONiC/blob/master/doc/macsec/MACsec_hld.md - How to verify it This PR doesn't set MACsec container automatically start, You should manually start the container by docker run docker-macsec wpa_supplicant binary can be found at MACsec container. This PR depends on the PR, WPA_SUPPLICANT, and The MACsec container will be set as automatically start by later PR. Signed-off-by: zegan <[email protected]>
- (HEAD, github/master) [storyteller] adding a grep wrapper with predefined scenarios (#1349) - Adding global-timeout, individual command timeout, log files collection (#1249) - Add FW dump with new SAI implementation (#1338) - [unit test][pfcwd] Fix tests that require sudo access (#1340) Signed-off-by: Ying Xie <[email protected]>
To make the peer switch hostname easily accessible from config DB. Add peer_switch field to DEVICE_METADATA table Signed-off-by: Lawrence Lee <[email protected]>
Need to add the follow redirection option -L when downloading the package with redirection.
Signed-off-by: Guohan Lu <[email protected]>
Fix #119 when parallel build is enable, multiple dpkg-buildpackage instances are running at the same time. /var/lib/dpkg is shared by all instances and the /var/lib/dpkg/updates could be corrupted and cause the build failure. the fix is to use overlay fs to mount separate /var/lib/dpkg for each dpkg-buildpackage instance so that they are not affecting each other. Signed-off-by: Guohan Lu <[email protected]>
* src/sonic-platform-common bd4dc03...513920c (1): > [sffbase] Make convert_hex_to_string() compatible with both Python 2 and Python 3 (#165)
armhf kernel package name does not have `unsigned` string Signed-off-by: Guohan Lu <[email protected]>
Tweak GitHub issue and pull request templates - Rename files to align with new [standard](https://docs.github.com/en/github/building-a-strong-community/using-templates-to-encourage-useful-issues-and-pull-requests) - Use markdown headings rather than bolded bullets
Include SAI bug fixes: - Apply device MAC on port host interface when port is removed from LAG. - [Shared Headroom]: fixed watermark handling for SHP flow - Decrease verbosity of policer unbind message when no policer is attached Signed-off-by: Stepan Blyschak <[email protected]>
We stopped building our own custom python-click package via #5549. This target should have been removed at that time but was missed.
the added change was accidentally removed in commit 092f537 Signed-off-by: Guohan Lu <[email protected]>
Merged bcmsai 4.3.0.13 code to top of master bcmsai 4.3.0.10-5. - How to verify it Ran nightly regression on T0 and T1 topology using bcmsai 4.3.0.13. Test results are better than previous runs. For T0 - New test passing - CRM, Decap, FDB, platform test, VxLAN New test failing – PFC unknown MAC For T1 – New test passing – Port Channel New test failing – platform test
… on init. (#6709) **- Why I did it** To support FW upgrade on init. **- How I did it** Change timeout value **- How to verify it** I manually changed ASIC and Gearbox FW followed by hard reset in order for FW upgrade to take place on init. Signed-off-by: liora <[email protected]>
…65x-r0 (#6612) platform modules' deb package rules for x86_64-accton_wedge100bf_65x-r0 was missing the code that installs the sonic_platform wheel package file under device directory on host (which is checked by pmon deamon on start)
…d Improvements (#6738) - Why I did it Enable platform API tests to run successfully by providing required test infrastructure files along with supporting changes. - How I did it Added platform.json along with supporting changes. - Addition of pcie.yaml supporting pcied - Addition of Real fan drawer support vs Virtual - Removal of python2 wheel with support in place for python3 - supporting changes platform api tests
SER test script is failing as mem_cache flag is disabled.
…prom.py (#6739) Signed-off-by: Volodymyr Boyko <[email protected]>
Use separate file for each sfp eeprom operation Signed-off-by: Volodymyr Boyko <[email protected]>
Fix wrong sfp reset return value Signed-off-by: Volodymyr Boyko <[email protected]>
Add platform.json used for sonic-mgmt testing in DellEMC S6000, S6100 platforms.
sonic-utilities 28d358f...f5b8a1e (22): > Fix deprecation warnings (#1423) > Fix: initialize SonicDBConfig differently for single or multi_asic (continued) (#1417) > [multi-asic] show ip interface changes for multi asic (#1396) > [show mux]: Sort output by intf name (#1418) > [ci] Test and build package using Azure Pipelines (#1406) > [GitHub] Tweak PR and issue templates (#1419) > Import 'mock' module from 'unittest' library (#1415) > Revert "Add FW dump with new SAI implementation (#1338)" (#1407) > [config reload]: Restart macsec container (#1410) > [pcieutil] Remove the warning message and change the config file location (#1362) > Fix: initialize SonicDBConfig differently for single or multi_asic (#1409) > Support shared headroom pool on top of dynamic buffer calculation (#1348) > Fix unsupported fs.squashfs extraction in sonic-installer (#1366) > [show] Use proper variable to avoid exception in natshow script (#1383) > Set up CI with Azure Pipelines > [config reload]: Restart mux container (#1401) > Advertise ipv6 link local address (#1402) > [storyteller] Enhance the storyteller utility (#1400) > [show] Fix int status when portchannel is in the system (#1376) > [config][show] cli support for retrieving ber, eye-info and configuring prbs, loopback on Y-cable (#1386) > Skip route check for tun0 interfaces (#1399) > do not parse stderr to get correct routing stack (#1398) > [storyteller] allow storyteller to work on downloaded logs (#1388) > [vrf]: Fix freezing during interface binding (#1325) > Use SonicV2Connector/ConfigDBConnector/SonicDBConfig from swsscommon instread of swsssdk (#1392) Signed-off-by: Lawrence Lee <[email protected]>
Signed-off-by: Guohan Lu <[email protected]>
…face counters (#6775) This PR is needed to fix the show interface counters output issue where the counters are not correct due to an issue introduced in BRCM SAI 4.3. - How to verify it Without the fix if one injects packets, the expected counters for the interfaces involved do not show correct count values. The RX count looks to be TX count while TX count looks to be RX count but even that the values could not be trusted. After the fix the counters started to look correct. Here is one sample output taken after the fix is applied where I manually injected 10,000 packets into Ethernet92 to be routed out of the port channel member port Ethernet40. Also injected 10,000 invalid packets into the same Ethernet92 and all 10,000 packets were shown RX_DRP correctly.
- Introduced TS common file in docker as well and moved common functions.
- TSA/B/C scripts run only in BGP instances for front end ASICs.
In addition skip enforcing it on route maps used between internal BGP sessions.
admin@str--acs-1:~$ sudo /usr/bin/TSA
System Mode: Normal -> Maintenance
and in case of Multi-ASIC
admin@str--acs-1:~$ sudo /usr/bin/TSA
BGP0 : System Mode: Normal -> Maintenance
BGP1 : System Mode: Normal -> Maintenance
BGP2 : System Mode: Normal -> Maintenance
coppmgrd process do not need to be auto-restarted if it exited unexpectedly. Signed-off-by: Yong Zhao <[email protected]>
…6780) Fix marvell-armhf build break The azure-storage package depends on the cryptography package. Newer versions of cryptography require the rust compiler, the correct version for which is not readily available in buster. Hence we pre-install an older version here to satisfy the azure-storage dependency. Note: This is not a problem for other architectures as pre-built versions of cryptography are available for those. This sequence can be removed after upgrading to debian bullseye.
sonic-net/sonic-utilities#1431 changes the path to the udevprefix.conf file. The file previously inappropriately resided in the <platform>/plugins/ directory. That directory is reserved for now-deprecated Python platform plugins, and will be removed in the near future.
Commits include: * src/sonic-utilities c7e46c9...42cab68 (3): > [consutil] Look for udevprefix.conf file under platform dir, not plugins (#1431) > [ci]: download from sonic-buildimage.vs artifact (#1428) > [storyteller] sort output by time and improve lag support (#1430)
* Add *MUX_CABLE_TABLE* to set of tables to clear on SWSS start, which will clear HW_MUX_CABLE_TABLE and MUX_CABLE_TABLE * Order swss to start before pmon to ensure that DBs are cleared before xcvrd (running inside pmon) starts and re-populates the tables Signed-off-by: Lawrence Lee <[email protected]>
xumia
pushed a commit
that referenced
this pull request
Nov 14, 2021
Upgrade DellEMC platforms to bullseye.
xumia
pushed a commit
that referenced
this pull request
Sep 8, 2022
…onic-net#11684) The follwing commit is added in sonic-utilities b034f0c (HEAD -> 202012, origin/202012) [config][muxcable] add support to enable/disable ycable telemetry (#2… (sonic-net#2304) The follwing commit is added in sonic-platform-daemons 978667c (HEAD -> 202012, origin/202012) [ycabled] add capability to enable/disable telemetry (sonic-net#279) (sonic-net#280 Signed-off-by: vaibhav-dahiya <[email protected]> Signed-off-by: vaibhav-dahiya <[email protected]>
xumia
pushed a commit
that referenced
this pull request
Oct 27, 2022
#### Why I did it Update sonic-host-services submodule to include below commits: ``` bc8698d Merge pull request #21 from abdosi/feature 557a110 Fix the issue where if dest port is not specified in ACL rule than for multi-asic where we create NAT rule to forward traffic from Namespace to host fail with exception. 6e45acc (master) Merge pull request #14 from abdosi/feature 4d6cad7 Merge remote-tracking branch 'upstream/master' into feature bceb13e Install libyang to azure pipeline (#20) 82299f5 Merge pull request #13 from SuvarnaMeenakshi/cacl_fabricns 15d3bf4 Merge branch 'master' into cacl_fabricns de54082 Merge pull request #16 from ZhaohuiS/feature/caclmgrd_external_client_warning_log b4b368d Add warning log if destination port is not defined d4bb96d Merge branch 'master' into cacl_fabricns 35c76cb Add unit-test and fix typo. 17d44c2 Made Changes to be Python 3.7 compatible 978afb5 Aligning Code 1fbf8fb Merge remote-tracking branch 'upstream/master' into feature 7b8c7d1 Added UT for the changes 91c4c42 Merge pull request #9 from ZhaohuiS/feature/caclmgrd_external_client 7c0b56a Add 4 test cases for external_client_acl, including single port and port range for ipv4 and ipv6 b71e507 Merge remote-tracking branch 'origin/master' into HEAD d992dc0 Merge branch 'master' into feature/caclmgrd_external_client bd7b172 DST_PORT is configuralbe in json config file for EXTERNAL_CLIENT_ACL f9af7ae [CLI] Move hostname, mgmt interface/vrf config to hostcfgd (#2) 70ce6a3 Merge pull request #10 from sujinmkang/cold_reset 29be8d2 Added Support to render Feature Table using Device running metadata. Also added support to render 'has_asic_scope' field of Feature Table. 3437e35 [caclmgrd][chassis]: Add ip tables rules to accept internal docker traffic from fabric asic namespaces. 8720561 Fix and add hardware reboot cause determination tests 0dcc7fe remove the empty bracket if no hardware reboot cause minor e47d831 fix the wrong expected result comparision ef86b53 Fix startswith Attribute error 8a630bb fix mock patch 8543ddf update the reboot cause logic and update the unit test 53ad7cd fix the mock patch function 7c8003d fix the reboot-cause regix for test 1ba611f fix typo 25379d3 Add unit test case a56133b Add hardware reboot cause as actual reboot cause for soft reboot failed c7d3833 Support Restapi/gnmi control plane acls f6ea036 caclmgrd: Don't block traffic to mgmt by default a712fc4 Update test cases adc058b caclmgrd: Don't block traffic to mgmt by default 06ff918 Merge pull request #7 from bluecmd/patch-1 e3e23bc ci: Rename sonic-buildimage repository e83a858 Merge pull request #4 from kamelnetworks/acl-ip2me-test f5a2e50 [caclmgrd]: Tests for IP2ME rules generation ```
xumia
pushed a commit
that referenced
this pull request
Mar 6, 2024
…ing fastboot Fix fastreboot path to shutdown SLB neighbors during fastboot This issue was found when the new build on internal branch started failing. Build failure log: ``` Applying patch ../sonic-utilities.patch/0002-Stopping-all-BGP-SLB-neighbors-if-they-re-presented-.patch patching file scripts/fast-reboot Hunk #1 succeeded at 43 with fuzz 1 (offset 7 lines). Hunk #2 FAILED at 123. Hunk #3 succeeded at 502 with fuzz 1 (offset 81 lines). Hunk #4 succeeded at 582 (offset 95 lines). 1 out of 4 hunks FAILED -- rejects in file scripts/fast-reboot ``` Repro'd this locally: ``` vadixit@DevVM-20:~/workspace/Networking-acs-buildimage/src/sonic-utilities$ quilt push -a Applying patch patches/0002-Stopping-all-BGP-SLB-neighbors-if-they-re-presented-.patch patching file scripts/fast-reboot Hunk #1 succeeded at 42 with fuzz 1 (offset 6 lines). Hunk #2 FAILED at 123. Hunk #3 succeeded at 489 with fuzz 1 (offset 68 lines). Hunk #4 succeeded at 569 (offset 82 lines). 1 out of 4 hunks FAILED -- rejects in file scripts/fast-reboot Patch patches/0002-Stopping-all-BGP-SLB-neighbors-if-they-re-presented-.patch does not apply (enforce with -f) ``` Issue fixed with this change: ``` vadixit@DevVM-20:~/workspace/Networking-acs-buildimage/src/sonic-utilities$ quilt push -a Applying patch patches/0001-fast-reboot-patch-Handle-SLB-neighbors-shutdown-duri.patch patching file scripts/fast-reboot Now at patch patches/0001-fast-reboot-patch-Handle-SLB-neighbors-shutdown-duri.patch ``` Additionally, changed the series file and renamed the 0002 patch as 0001 patch as this is the only patch on this branch right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything works again