[Nokia]: Enable Telemetry for armhf and provide required qos files #6364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR title is not descriptive. |
carl-nokia
changed the title
|
Fixed the title - was an oversight. Thanks |
lguohan
reviewed
Jan 6, 2021
lguohan
requested changes
Jan 6, 2021
- providing required files
|
Reverted the commit with mistake and pushed the one line change to slave.mk |
lguohan
approved these changes
Jan 6, 2021
|
Retest mellanox please |
|
build test failure irrelavant |
lguohan
pushed a commit
that referenced
this pull request
Jan 9, 2021
…6364) * [platform][Nokia]: Add buffers and qos files for config qos reload - providing required files * [platform][armhf]: remove hardcoded disable for Telemetry on armhf Co-authored-by: Carl Keene <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
To enable Telemetry on armhf architecture and provide required qos/buffers files that
config qos reload --no-dynamic-buffer now requires for the Nokia ixs7215
- How I did it
Removed the hardcoded disable of Telemetry in slave.mk for armhf architecture and provided
required qos/buffers files for the config qos reload code to succeed as stubs since they do not
generate buffer settings to Marvell SAI for this MO based role
- How to verify it
config load_minigraph -y succeeds for OC testing
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)