MACsec container and wpa_supplicant component #5700
Conversation
Signed-off-by: zegan <[email protected]>
Signed-off-by: zegan <[email protected]>
Signed-off-by: zegan <[email protected]>
…mage into wpa_supplicant_support
Signed-off-by: zegan <[email protected]>
Signed-off-by: zegan <[email protected]>
Signed-off-by: zegan <[email protected]>
Signed-off-by: zegan <[email protected]>
Signed-off-by: zegan <[email protected]>
Signed-off-by: zegan <[email protected]>
Signed-off-by: zegan <[email protected]>
…to wpa_supplicant_support
Signed-off-by: Ze Gan <[email protected]>
Signed-off-by: Ze Gan <[email protected]>
Signed-off-by: Ze Gan <[email protected]>
Signed-off-by: Ze Gan <[email protected]>
Signed-off-by: Ze Gan <[email protected]>
|
retest vsimage please |
|
retest vs please |
|
retest mellanox please |
|
retest baseimage please |
Signed-off-by: Ze Gan <[email protected]>
Signed-off-by: Ze Gan <[email protected]>
Signed-off-by: Ze Gan <[email protected]>
Signed-off-by: Ze Gan <[email protected]>
src/wpasupplicant/Makefile
Outdated
| rm -rf ./wpa | ||
|
|
||
| # Clone wpa repo | ||
| # git clone https://github.com/Azure/sonic-wpa-supplicant.git |
There was a problem hiding this comment.
What's the issue regarding the repo in Azure? Why are we still using debian repo?
There was a problem hiding this comment.
Because the repo in Azure doesn't include debian rule to build the debian package.
This PR need wait another PR(haven't been created) to add debian build rule for sonic-wpa-supplicant. So this PR is draft status right now.
|
In critical process file, do we not want to watch any processes? e.g. macsecmgr? |
Yes, you are right. But I believe we will have another PR to set up all runtime environment or requirement. This PR is just for creating all components for integration and others need to start each components manually. |
Signed-off-by: Ze Gan <[email protected]>
Pterosaur
force-pushed
the
macsec
branch
2 times, most recently
from
717962b
to
9a697c1
Compare
Signed-off-by: Ze Gan <[email protected]>
|
retest this please |
|
retest vsimage please |
Signed-off-by: Ze Gan <[email protected]>
Signed-off-by: Ze Gan <[email protected]>
|
retest vsimage please |
|
@lguohan Please review this PR. |
|
we need to add critical process in macsec container. |
|
why is that supervisord.conf is empty? are we not starting any process right now? |
Yes, I will submit another PR for starting MACsec Manager in MACsec container. |
| qtbase5-dev \ | ||
| aspell-en \ | ||
| libhiredis-dev \ | ||
| libnl-3-dev \ |
There was a problem hiding this comment.
We build our own libnl3 and libhiredis. Please depend on them instead of pre-install the vanilla ones in sonic-slave.
- Why I did it
Make SONiC support MACsec feature
The HLD about MACsec feature is at : MACsec HLD
- How I did it
Add MACsec container and sonic-wpa-supplicant
- How to verify it
This PR doesn't set MACsec container automatically start, You should manually start the container by
docker run docker-macsecwpa_supplicant binary can be found at MACsec container.
This PR depends on the PR, WPA_SUPPLICANT, and The MACsec container will be set as automatically start by later PR.
- A picture of a cute animal (not mandatory but encouraged)
🐉