Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xcvrd] Remove dependency on SONIC_PLATFORM_API_PY2 and SONIC_PLATFORM_API_PY3 #6344

Merged
merged 1 commit into from
Jan 5, 2021

Conversation

Junchao-Mellanox
Copy link
Collaborator

- Why I did it

xcvrd no longer depends on target SONIC_PLATFORM_API_PY2 and SONIC_PLATFORM_API_PY3

- How I did it

Remove the build time dependency SONIC_PLATFORM_API_PY2 and SONIC_PLATFORM_API_PY3 from xcvrd make rule

- How to verify it

Run build.

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@jleveque
Copy link
Contributor

jleveque commented Jan 5, 2021

Retest vsimage please

@Junchao-Mellanox
Copy link
Collaborator Author

retest vsimage please

@lguohan lguohan requested a review from jleveque January 5, 2021 17:15
@jleveque jleveque changed the title [xcvrd] Remove dependency SONIC_PLATFORM_API_PY2 and SONIC_PLATFORM_API_PY3 from xcvrd [xcvrd] Remove dependency on SONIC_PLATFORM_API_PY2 and SONIC_PLATFORM_API_PY3 Jan 5, 2021
@jleveque jleveque merged commit 4460076 into sonic-net:master Jan 5, 2021
lguohan pushed a commit that referenced this pull request Jan 6, 2021
…M_API_PY3 (#6344)

Remove the build time dependency on SONIC_PLATFORM_API_PY2 and SONIC_PLATFORM_API_PY3 from xcvrd make rule
@Junchao-Mellanox Junchao-Mellanox deleted the fix-xcvrd-dependency branch February 4, 2021 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants