Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #6838: 3.17-pre - Support multiple factory answers in PerformanceHints check_data endpoint #6861

Merged

Conversation

jeawhanlee
Copy link
Contributor

@jeawhanlee jeawhanlee commented Aug 9, 2024

Description

Fixes #6838

Documentation

User documentation

Allow other feature using the beacon work properly.

Technical documentation

Accommodate other features payload instead of dying after first feature ajax request is processed.

Type of change

  • Bug fix (non-breaking change which fixes an issue).
  • Enhancement (non-breaking change which improves an existing functionality).

New dependencies

None

Risks

None

Checklists

Feature validation

  • I validated all the Acceptance Criteria. If possible, provide sreenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Documentation

  • I prepared the user documentation for the feature/enhancement and shared it in the PR or the GitHub issue.
  • The user documentation covers new/changed entry points (endpoints, WP hooks, configuration files, ...).
  • I prepared the technical documentation if needed, and shared it in the PR or the GitHub issue.

Code style

  • I wrote self-explanatory code about what it does.
  • I wrote comments to explain why it does it.
  • I named variables and functions explicitely.
  • I protected entry points against unexpected inputs.
  • I did not introduce unecessary complexity.

jeawhanlee and others added 30 commits July 16, 2024 12:25
@jeawhanlee jeawhanlee self-assigned this Aug 9, 2024
@jeawhanlee jeawhanlee added module: OCI Optimize Critical Images module: ALR Issues related to the Automatic Lazy Rendering feature labels Aug 9, 2024
Copy link

codacy-production bot commented Aug 9, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for d68d1781 26.47% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (d68d178) Report Missing Report Missing Report Missing
Head commit (040c807) 37613 14283 37.97%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6861) 34 9 26.47%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@jeawhanlee jeawhanlee marked this pull request as ready for review August 14, 2024 09:59
@jeawhanlee jeawhanlee requested a review from a team August 14, 2024 10:06
@Mai-Saad
Copy link
Contributor

Copy link
Contributor

@Mai-Saad Mai-Saad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeawhanlee jeawhanlee merged commit 2f41700 into feature/lrc Aug 20, 2024
10 of 11 checks passed
@jeawhanlee jeawhanlee deleted the 3.17-pilot-support-multiple-factory-for-ajax-endpoint branch August 20, 2024 07:12
@jeawhanlee jeawhanlee mentioned this pull request Aug 20, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: ALR Issues related to the Automatic Lazy Rendering feature module: OCI Optimize Critical Images
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.17-pre - Support multiple factory answers in PerformanceHints check_data endpoint
7 participants