-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #6851: 3.17 refactor regression: {wpr_imagedimensions=1} query string isnot added to home page while warmup after fresh install #6853
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Question: What is the advantage of this solution instead of reverting to the previous working code? |
@Tabrisrp We define this query before in 2 places, in the api client and also as a callback which didn't seem necessary but now we still have it defined once but just with the subscriber called early enough. |
inc/Engine/Common/PerformanceHints/Activation/ServiceProvider.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and confirmed as fixed on PR.
Description
Fixes #6851
Documentation
User documentation
Imagedimension query argument is now added for home during activation, this initially prevent the home from having entries in DB
Technical documentation
In the 3.17 refactor we removed these lines and depended on the filter to apply this query arg here but the issue was that the warmup subscriber will not be loaded early enough for this callback to be fired, so in this PR we loaded the subscriber early enough to trigger the callback.
Type of change
New dependencies
None
Risks
None
Checklists
Feature validation
Documentation
Code style