Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtask/6778 3.17 refactor frontend process #6804

Merged

Conversation

jeawhanlee
Copy link
Contributor

Description

Fixes #6778

Documentation

User documentation

No changes on user side.

Technical documentation

Here we refactor the frontend module to make the subscriber extendable by creating abstract and concrete products and updating the concrete factory to call the frontend controller object.

Type of change

  • Enhancement (non-breaking change which improves an existing functionality).

New dependencies

None

Risks

None

Checklists

Feature validation

  • I validated all the Acceptance Criteria. If possible, provide sreenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Documentation

  • I prepared the user documentation for the feature/enhancement and shared it in the PR or the GitHub issue.
  • The user documentation covers new/changed entry points (endpoints, WP hooks, configuration files, ...).
  • I prepared the technical documentation if needed, and shared it in the PR or the GitHub issue.

Code style

  • I wrote self-explanatory code about what it does.
  • I wrote comments to explain why it does it.
  • I named variables and functions explicitely.
  • I protected entry points against unexpected inputs.
  • I did not introduce unecessary complexity.
  • I listed the introduced external dependencies explicitely on the PR.
  • I validated the repo-specific guidelines from CONTRIBUTING.md.

Observability

  • I handled errors when needed.
  •  I wrote user-facing messages that are understandable and provide actionable feedbacks.
  • I prepared ways to observe the implemented system (logs, data, etc.).

Risks

  •  I explicitely mentioned performance risks in the PR.
  • I explicitely mentioned security risks in the PR.

@jeawhanlee jeawhanlee self-assigned this Jul 20, 2024
@jeawhanlee jeawhanlee added type: enhancement Improvements that slightly enhance existing functionality and are fast to implement module: OCI Optimize Critical Images labels Jul 20, 2024
Copy link

codacy-production bot commented Jul 20, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for c14bfd31 60.00% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (c14bfd3) Report Missing Report Missing Report Missing
Head commit (623a9e0) 37411 14560 38.92%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6804) 110 66 60.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@jeawhanlee jeawhanlee changed the base branch from develop to 3.17-atf-refactor July 20, 2024 10:54
@jeawhanlee jeawhanlee marked this pull request as ready for review July 20, 2024 10:55
@jeawhanlee jeawhanlee requested a review from a team July 20, 2024 10:58
@jeawhanlee jeawhanlee merged commit 4149dc2 into 3.17-atf-refactor Jul 22, 2024
12 of 13 checks passed
@jeawhanlee jeawhanlee deleted the subtask/6778-3.17-refactor-frontend-process branch July 22, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: OCI Optimize Critical Images type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.17 Sub tasks - Frontend Refactoring
2 participants