Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accomodate updated payload structure #16

Merged

Conversation

jeawhanlee
Copy link
Contributor

Description

Adds support for updated payload for multiple feature factories. https://wp-media.slack.com/archives/CUT7FLHF1/p1722433782954279

Documentation

User documentation

Allow other feature using the beacon work properly.

Technical documentation

Accommodate other features payload instead of dying after first feature ajax request is processed.

Type of change

  • Bug fix (non-breaking change which fixes an issue).
  • Enhancement (non-breaking change which improves an existing functionality).

New dependencies

None

Risks

None

Checklists

Feature validation

  • I validated all the Acceptance Criteria. If possible, provide sreenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Documentation

  • I prepared the user documentation for the feature/enhancement and shared it in the PR or the GitHub issue.
  • The user documentation covers new/changed entry points (endpoints, WP hooks, configuration files, ...).
  • I prepared the technical documentation if needed, and shared it in the PR or the GitHub issue.

Code style

  • I wrote self-explanatory code about what it does.
  • I named variables and functions explicitely.
  • I protected entry points against unexpected inputs.
  • I did not introduce unecessary complexity.

@jeawhanlee jeawhanlee changed the title Enhancement/accomodate updated playload structure Accomodate updated payload structure Aug 14, 2024
@jeawhanlee jeawhanlee self-assigned this Aug 14, 2024
@wordpressfan
Copy link
Collaborator

Thanks @jeawhanlee
Is the PHP part available in the plugin now? or we just need to validate the code here without testing?

@jeawhanlee
Copy link
Contributor Author

@wordpressfan It's here awaiting testing by QA

MathieuLamiot
MathieuLamiot previously approved these changes Aug 14, 2024
@wordpressfan
Copy link
Collaborator

I think we are fine to merge this one, what do u think @jeawhanlee @MathieuLamiot ?

@wordpressfan wordpressfan merged commit f024b7f into develop Aug 16, 2024
2 checks passed
@wordpressfan wordpressfan deleted the enhancement/accomodate-updated-playload-structure branch August 16, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants