Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile Release v1.42.2 - Hotfix: Fix crash when deleting a block #2893

Merged
merged 6 commits into from
Dec 11, 2020
Merged

Mobile Release v1.42.2 - Hotfix: Fix crash when deleting a block #2893

merged 6 commits into from
Dec 11, 2020

Conversation

Tug
Copy link
Contributor

@Tug Tug commented Dec 11, 2020 •
edited by cameronvoell
Loading

Fixes #2886

Gutenberg PR -> WordPress/gutenberg#27692
WPiOS: wordpress-mobile/WordPress-iOS#15479
WPANdroid: wordpress-mobile/WordPress-Android#13594

To test check the Gutenberg PR description.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@Tug Tug changed the base branch from develop to trunk December 11, 2020 18:44
@Tug Tug mentioned this pull request Dec 11, 2020
Merged
2 tasks
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Dec 11, 2020 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@guarani guarani added this to the 1.42 (16.3) milestone Dec 11, 2020
This was referenced Dec 11, 2020
Merged
Closed
guarani
guarani approved these changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jd-alexander jd-alexander merged commit e99c3f6 into trunk Dec 11, 2020
@jd-alexander jd-alexander deleted the hotfix/v1.42.2 branch December 11, 2020 23:58
@cameronvoell cameronvoell changed the title Hotfix: Fix crash when deleting a block Mobile Release v1.42.2 - Hotfix: Fix crash when deleting a block Dec 12, 2020
This was referenced Dec 12, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guarani guarani guarani approved these changes

@cameronvoell cameronvoell Awaiting requested review from cameronvoell

@jd-alexander jd-alexander Awaiting requested review from jd-alexander

Assignees
No one assigned
Labels
release-process
Projects
None yet
Milestone
1.42 (16.3)
Development

Successfully merging this pull request may close these issues.

Crash when deleting block from page template
4 participants
@Tug @guarani @jd-alexander @cameronvoell