Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor release 1.42.2 integration #15479

Merged
merged 1 commit into from
Dec 12, 2020
Merged

Editor release 1.42.2 integration #15479

merged 1 commit into from
Dec 12, 2020

Conversation

guarani
Copy link
Contributor

@guarani guarani commented Dec 11, 2020

Fixes wordpress-mobile/gutenberg-mobile#2886

Gutenberg Mobile PR -> wordpress-mobile/gutenberg-mobile#2893
Gutenberg PR -> WordPress/gutenberg#27683

To test check the Gutenberg PR description.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@guarani guarani added the Gutenberg Editing and display of Gutenberg blocks. label Dec 11, 2020
@guarani guarani added this to the 16.3 ❄️ milestone Dec 11, 2020
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Dec 11, 2020 •
edited
Loading

You can test the changes on this Pull Request by downloading it from AppCenter here with build number: 39279. IPA is available here. If you need access to this, you can ask a maintainer to add you.

@guarani guarani requested a review from jd-alexander December 11, 2020 20:37
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Dec 11, 2020 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@jd-alexander
Copy link
Contributor

@guarani shouldn't this point to the release/16.3 branch?

@guarani guarani changed the base branch from develop to release/16.3 December 12, 2020 00:15
@guarani
Copy link
Contributor Author

guarani commented Dec 12, 2020

@guarani shouldn't this point to the release/16.3 branch?

True! Thanks for noticing!

@guarani guarani force-pushed the fix/deleting-block-16.3 branch from 5cf40b4 to 682559a Compare December 12, 2020 00:42
@guarani guarani requested a review from jkmassel December 12, 2020 01:51
@guarani
Copy link
Contributor Author

guarani commented Dec 12, 2020

Tested build 39279 and wordpress-mobile/gutenberg-mobile#2886 is resolved 👍

jkmassel
jkmassel reviewed Dec 12, 2020
View reviewed changes
Podfile
@@ -154,7 +154,7 @@ target 'WordPress' do
## Gutenberg (React Native)
## =====================
##
gutenberg :tag => 'v1.42.0'
gutenberg :tag => 'v1.42.2'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this is changing by two versions – just want to ensure that's deliberate? 😃

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi good eye => we noticed this today. I think our checks missed that the previous hotfix PR was supposed to be updated to 1.42.1, but I accidentally updated the reference to 1.42.0 in final PR (I just added a comment on that PR with that info: #15436 (comment)). As that hotfix was actually an android specific fix, so the PR was just an update to keep versioning in sync on the iOS side with no functional changes.

So yes the update from 1.42.0 1.42.2 is intentional.

@cameronvoell cameronvoell mentioned this pull request Dec 12, 2020
Merged
1 task
@cameronvoell cameronvoell self-requested a review December 12, 2020 09:19
cameronvoell
cameronvoell approved these changes Dec 12, 2020
View reviewed changes
Copy link
Contributor

@cameronvoell cameronvoell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified crash fix and gb-mobile na dgutenberg hashes => ready to merge!

@cameronvoell cameronvoell mentioned this pull request Dec 12, 2020
Merged
2 tasks
@jkmassel jkmassel merged commit 094208f into release/16.3 Dec 12, 2020
@jkmassel jkmassel deleted the fix/deleting-block-16.3 branch December 12, 2020 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkmassel jkmassel jkmassel left review comments

@cameronvoell cameronvoell cameronvoell approved these changes

@jd-alexander jd-alexander Awaiting requested review from jd-alexander

Assignees
No one assigned
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Milestone
16.3
Development

Successfully merging this pull request may close these issues.

Crash when deleting block from page template
4 participants
@guarani @jd-alexander @cameronvoell @jkmassel