Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge release 1.42.2 to develop #2896

Closed
wants to merge 9 commits into from
Closed

Merge release 1.42.2 to develop #2896

wants to merge 9 commits into from

Conversation

guarani
Copy link
Contributor

@guarani guarani commented Dec 12, 2020

Brings back changes from 1.42.2 release to develop

Release PR 1.42.2 for reference: #2893

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@guarani guarani mentioned this pull request Dec 12, 2020
Closed
2 tasks
@guarani guarani marked this pull request as ready for review December 12, 2020 02:51
@guarani guarani requested a review from cameronvoell December 12, 2020 02:51
cameronvoell
cameronvoell reviewed Dec 15, 2020
View reviewed changes
Copy link
Contributor

@cameronvoell cameronvoell left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably should just not update the gutenberg reference in this PR since the reference from 1.42.2 is specific to that hotfix, and we dont want to point there from our gutenberg-mobile develop branch.

When we create the "Merge release 1.43.0 to develop" PR I recommend updating the gutenberg reference to the commit where the following PR is merged to gutenberg master: WordPress/gutenberg#27566

@hypest hypest mentioned this pull request Dec 21, 2020
Merged
2 tasks
@guarani guarani added this to the 1.44 (16.5) milestone Jan 4, 2021
@guarani
Copy link
Contributor Author

guarani commented Jan 4, 2021

We probably should just not update the gutenberg reference in this PR since the reference from 1.42.2 is specific to that hotfix, and we dont want to point there from our gutenberg-mobile develop branch.

When we create the "Merge release 1.43.0 to develop" PR I recommend updating the gutenberg reference to the commit where the following PR is merged to gutenberg master: WordPress/gutenberg#27566

I overlooked attending this PR. We've now updated the Gutenberg submodule hash in #2929 so I think this can be safely closed without merging.
@cameronvoell if you think that's incorrect, please let me know.

@guarani guarani closed this Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cameronvoell cameronvoell cameronvoell left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.44 (16.5)
Development

Successfully merging this pull request may close these issues.
4 participants
@guarani @cameronvoell @Tug @jd-alexander