Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: Integrate GB-Mobile 1.42.2 - Fix crash when deleting a block #13594

Merged
merged 8 commits into from
Dec 14, 2020

Conversation

Tug
Copy link
Contributor

@Tug Tug commented Dec 11, 2020

Fixes wordpress-mobile/gutenberg-mobile#2886

Gutenberg Mobile PR -> wordpress-mobile/gutenberg-mobile#2893
Gutenberg PR -> WordPress/gutenberg#27692

To test check the Gutenberg PR description.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Dec 11, 2020

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@Tug Tug changed the base branch from develop to release/16.3 December 11, 2020 18:57
@Tug Tug requested a review from guarani December 11, 2020 19:17
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Dec 11, 2020

You can test the changes on this Pull Request by downloading the APK here.

@jd-alexander jd-alexander self-requested a review December 12, 2020 00:06
Copy link
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and unable to reproduce wordpress-mobile/gutenberg-mobile#2886, so looks good to me!

@cameronvoell cameronvoell changed the title Hotfix: Fix crash when deleting a block Hotfix: GB-Mobile 1.42.2 - Fix crash when deleting a block Dec 12, 2020
@cameronvoell cameronvoell changed the title Hotfix: GB-Mobile 1.42.2 - Fix crash when deleting a block Hotfix: Integrate GB-Mobile 1.42.2 - Fix crash when deleting a block Dec 12, 2020
@guarani guarani added this to the 16.3 milestone Dec 12, 2020
@Tug Tug merged commit 4b12e41 into release/16.3 Dec 14, 2020
@Tug Tug deleted the fix/deleting-block-16.3 branch December 14, 2020 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when deleting block from page template
4 participants