-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v1.20.0 #1752
Merged
Merged
Release v1.20.0 #1752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it is not supported by GlotPress
…droid-strings-xml
Make the git commands a little easier to copy by taking out `$` from the start of the lines. This also matches with the other commands on the page which do not start with `$`.
The heading "Test" should be "Unit Tests". The heading "Writing and Running Tests" should be "Writing and Running Unit Tests". https://github.com/wordpress-mobile/gutenberg-mobile/blob/develop/src/index.test.js
* Add ref to gutenberg repo * Fix e2e tests * Update ref to gutenberg master
…mands Update Getting Started documentation to shorten git commands
Nudge for adding tests, clearer language on the PR template
…ize-option-conditionally
Add support for [SASS partials](https://sass-lang.com/guide), as is already present [upstream](https://github.com/kristerkari/react-native-sass-transformer/blob/52884dd59582856fa17e2b2e8ca9efc37d412387/index.js#L41-L42). This should fix the issue introduced by WordPress/gutenberg#19159, and discussed there.
2 tasks
* Add ref to gutenberg release * Update ref to gutenberg release branch
…lify-android-strings-xml
…d-strings-xml Do no escape strings with double quotes in android strings.xml
Co-authored-by: Drapich Piotr <[email protected]>
…low-on-android Force the react-native-video fork to build against same RN version as gutenberg-mobile from maven repo
6 tasks
hypest
approved these changes
Jan 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release for Gutenberg Mobile v1.20.0
Related PRs
Gutenberg PR: WordPress/gutenberg#19562
Aztec-iOS:
v1.14.1
(unchanged)Aztec-Android:
v1.3.37
(unchanged)WPAndroid: wordpress-mobile/WordPress-Android#11052
WPiOS: wordpress-mobile/WordPress-iOS#13190
Changes (Milestones view)
__DEV__
) (Basic template picker #1576)undo
button pressing #1701)Test Plan
Use the main WP apps to test the changes above. See WPAndroid and WPiOS PRs if there are specific tests to run.
Smoke test the main WP apps for general writing flow.