Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Merge mobile release v1.20.0 back into master #19562

Merged
merged 5 commits into from
Jan 10, 2020

Conversation

Tug
Copy link
Contributor

@Tug Tug commented Jan 10, 2020

Description

Related PR in gutenberg-mobile: wordpress-mobile/gutenberg-mobile#1752

Details:

How has this been tested?

This should be tested in this gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#1752 and in the WP apps directly (WPAndroid - wordpress-mobile/WordPress-Android#11052, WPiOS - wordpress-mobile/WordPress-iOS#13190).

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .

lukewalczak and others added 4 commits January 7, 2020 10:51
* Styling fixes to navigation feature

* Add netural styles for toolbar

* Fix condition for not registered component

* Display 'Unsupported' in breadcrumbs for missing components

* Refactor after CR

* Remove leftovers
* check if onBlur event contains text that is different than value

* add check if there is a text in native event

* Prevent re-selection of RichText when native selection changes as a result of resigning focus

* Fix typo

* Check if isSelected only in onSelectionChangeFromAztec

Co-authored-by: Jorge Bernal <[email protected]>
@Tug Tug added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Jan 10, 2020
@Tug Tug requested a review from hypest January 10, 2020 14:17
@Tug Tug self-assigned this Jan 10, 2020
@Tug Tug changed the base branch from master to rnmobile/releases-2020 January 10, 2020 15:58
@Tug Tug force-pushed the rnmobile/release-v1.20.0 branch from 6c5791e to 6db12c8 Compare January 10, 2020 16:18
Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

For the record, we pointed the PR to rnmobile/releases-2020 to work around merge conflicts with master. We'll merge there and then follow up with another PR to resolve conflicts and finally merge to master when we'll merge the gutenberg-mobile release branch back to its develop.

@Tug Tug merged commit 041394d into rnmobile/releases-2020 Jan 10, 2020
@Tug Tug deleted the rnmobile/release-v1.20.0 branch January 10, 2020 17:03
Tug added a commit that referenced this pull request Jan 14, 2020
…9569)

* [RNMobile] Merge mobile release v1.20.0 back into master (#19562)

* styling fixes after navigation feature merge (#19455)

* Styling fixes to navigation feature

* Add netural styles for toolbar

* Fix condition for not registered component

* Display 'Unsupported' in breadcrumbs for missing components

* Refactor after CR

* Remove leftovers

* [FIX] rich text focus loop (#19240)

* check if onBlur event contains text that is different than value

* add check if there is a text in native event

* Prevent re-selection of RichText when native selection changes as a result of resigning focus

* Fix typo

* Check if isSelected only in onSelectionChangeFromAztec

Co-authored-by: Jorge Bernal <[email protected]>

* [RNMobile] Correct displaying photo during upload (#19502)

* [RNMobile] Fix crash once adding Group (#19457)

* Add extra branch for travis to run tests onto

Co-authored-by: Luke Walczak <[email protected]>
Co-authored-by: Drapich Piotr <[email protected]>
Co-authored-by: Jorge Bernal <[email protected]>

* Revert travis changes

Co-authored-by: Luke Walczak <[email protected]>
Co-authored-by: Drapich Piotr <[email protected]>
Co-authored-by: Jorge Bernal <[email protected]>
@mkevins mkevins restored the rnmobile/release-v1.20.0 branch January 20, 2020 05:26
@ellatrix ellatrix added this to the Gutenberg 7.3 milestone Jan 20, 2020
hypest added a commit that referenced this pull request Feb 11, 2020
* [RNMobile] Merge mobile release v1.20.0 back into master (#19562)

* styling fixes after navigation feature merge (#19455)

* Styling fixes to navigation feature

* Add netural styles for toolbar

* Fix condition for not registered component

* Display 'Unsupported' in breadcrumbs for missing components

* Refactor after CR

* Remove leftovers

* [FIX] rich text focus loop (#19240)

* check if onBlur event contains text that is different than value

* add check if there is a text in native event

* Prevent re-selection of RichText when native selection changes as a result of resigning focus

* Fix typo

* Check if isSelected only in onSelectionChangeFromAztec

Co-authored-by: Jorge Bernal <[email protected]>

* [RNMobile] Correct displaying photo during upload (#19502)

* [RNMobile] Fix crash once adding Group (#19457)

* Add extra branch for travis to run tests onto

Co-authored-by: Luke Walczak <[email protected]>
Co-authored-by: Drapich Piotr <[email protected]>
Co-authored-by: Jorge Bernal <[email protected]>

* Adding empty function to RichText children call. (#19818)

This fixes a crash originated on this PR:
#19536
`

* Disable gallery image size options on mobile (#19828)

* [Mobile] Fix blank image size labels on mobile (#19800) (#20045)

* Fix blank image size labels on mobile

* Use name instead of label in default imageSizes

* [RNMobile] Enable Dismiss on PlainText in Android (#20095)

* Add flag for determining if running on Android

* Enable Dismiss button on PlainText. Enable show keyboard in Android on PlainText mount

* Enable Dismiss button on PlainText. Enable show keyboard in Android on PlainText mount

Co-authored-by: Tugdual de Kerviler <[email protected]>
Co-authored-by: Luke Walczak <[email protected]>
Co-authored-by: Drapich Piotr <[email protected]>
Co-authored-by: Jorge Bernal <[email protected]>
Co-authored-by: etoledom <[email protected]>
Co-authored-by: Matthew Kevins <[email protected]>
Co-authored-by: Chip <[email protected]>
@mkevins mkevins deleted the rnmobile/release-v1.20.0 branch July 6, 2020 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants