Gutenberg: update to v1.20.0 #11052

Tug · 2020-01-07T16:39:49Z

Gutenberg mobile "master" PR: wordpress-mobile/gutenberg-mobile#1752

This PR updates the gutenberg-mobile reference to point to the latest release, v1.20.0. No wpandroid integration changes introduced.

The libs/gutenberg-mobile reference is currently pointing to the release/1.20.0 branch on https://github.com/wordpress-mobile/gutenberg-mobile.

When that gets merged to gutenberg-mobile master, I'll update the ref here to point to the merge commit.

Changes:

Fix displaying placeholder for images in some cases when the image cannot be downloaded (Issue/1592 fix alignment hiding image placeholder gutenberg-mobile#1631)
Introduce new Stepper UI component, used in the Spacer block to select the block's height (Stepper component gutenberg-mobile#1640)
Add a testID to the inserter button so in can be used for AT (Test: "Add Inserter testID" gutenberg-mobile#1681)
Hide image size selection options when image is a url (Image block: Hide Size options when Image object is undefined gutenberg-mobile#1669)
Add experimental page template selector (__DEV__) (Basic template picker gutenberg-mobile#1576)
Fix crash on undo (Fix app crash after block removal due to undo button pressing gutenberg-mobile#1701)
Style fixes on navigation UI (Fixes after navigation for release 1.20.0 gutenberg-mobile#1754)

To test:
The block editor should work as normal.

Update release notes:

If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

peril-wordpress-mobile · 2020-01-07T16:46:13Z

You can test the changes on this Pull Request by downloading the APK here.

…e_release_1.20.0

etoledom · 2020-01-10T10:43:27Z

I've found these two small issues so far:

1- The strikethrough icon is not highlighted when the cursor is over a strikethrough-ed text.
2- The Layout looks a bit messy on the Images source selection bottom sheet.

Tested on Device Mi A2 Lite, Android 9, using the APK from CircleCI

Tug · 2020-01-10T11:21:58Z

@etoledom it seems your strikethrough text is also underlined? I think that might be one of aztec<-> gutenberg limitations when formatting text, aztec might just produce other tags that the one gutenberg format-library supports.

2 is indeed a problem, and more generally for translated text that might be longer. I have also noticed on my older (iOS) device that we were showing the block selection bottom sheet on 2 columns which crops some of the blocks. So in my opinion screen sizes looks like a more general problem we should address, but probably not as part of this release, wdyt?

etoledom · 2020-01-10T11:55:57Z

aztec might just produce other tags that the one gutenberg format-library supports.

Yes that's it! Aztec creates a <del> tag, and Gutenberg expects an <s> tag. 👍

etoledom · 2020-01-10T11:59:24Z

About 2: I remember have seen this issue before, and @marecar3 fixed it (If I'm not being confused). I'm trying to find that ticket but haven't found it yet.

@marecar3 maybe you remember?

etoledom · 2020-01-10T12:04:49Z

Just tested the version from the store (Beta) and it still happens there, so I guess is not a regression 👍

So in my opinion screen sizes looks like a more general problem we should address, but probably not as part of this release, wdyt?

Agreed!

marecar3 · 2020-01-10T12:26:06Z

About 2: I remember have seen this issue before, and @marecar3 fixed it (If I'm not being confused). I'm trying to find that ticket but haven't found it yet.

@marecar3 maybe you remember?

Hey @etoledom, I can't remember that I was working on that one 😕

etoledom · 2020-01-10T12:42:22Z

Thank you @marecar3 ! I got confused then 👍

There's one more: Captions on Images and Gallery have issues with multiline when pressing enter.
@pinarol any idea? If this seems important enough, we might want to target the release branch with a hot-fix.

etoledom · 2020-01-10T12:56:05Z

Everything else seems to work well. I'm happy to ✅ if all the issues described are not blockers for this PR.

Tug · 2020-01-10T12:58:12Z

It's not a regression but it's still pretty serious as caption might have line breaks (at least it's possible on the web) and we might lose content when editing on mobile.

etoledom · 2020-01-10T13:36:29Z

It's not a regression but it's still pretty serious as caption might have line breaks (at least it's possible on the web) and we might lose content when editing on mobile.

Tested on iOS and it works well. It might be related to Aztec Android?

hypest · 2020-01-10T14:23:22Z

The removal of the newlines in captions on Android is a known issue:
wordpress-mobile/gutenberg-mobile#1651

hypest · 2020-01-10T14:33:52Z

✅ Fix displaying placeholder for images in some cases when the image cannot be downloaded (wordpress-mobile/gutenberg-mobile#1631)
🆗 (not exposed to any user-facing UI yet) Introduce new Stepper UI component, used in the Spacer block to select the block's height (wordpress-mobile/gutenberg-mobile#1640)
✅ Add a testID to the inserter button so in can be used for AT (wordpress-mobile/gutenberg-mobile#1681)
🆗 (behind DEV flag still so, not exposed to user yet) Hide image size selection options when image is a url (wordpress-mobile/gutenberg-mobile#1669)
🆗 (behind DEV flag still so, not exposed to user yet) Add experimental page template selector (DEV) (wordpress-mobile/gutenberg-mobile#1576)
✅ Fix crash on undo (wordpress-mobile/gutenberg-mobile#1701)
✅ Style fixes on navigation UI (wordpress-mobile/gutenberg-mobile#1754)

etoledom · 2020-01-10T14:40:36Z

RELEASE-NOTES.txt

@@ -1,5 +1,9 @@
 14.0
 -----
+* Block Editor: Hide image size selection options when image is a url


The image size selector is still under dev flag, so this should not affect the release build.

etoledom

The removal of the newlines in captions on Android is a known issue:
wordpress-mobile/gutenberg-mobile#1651

Since this is known issue, there's my ✅ 🎉

pinarol · 2020-01-10T14:43:06Z

There's one more: Captions on Images and Gallery have issues with multiline when pressing enter.
@pinarol any idea? If this seems important enough, we might want to target the release branch with a hot-fix.

As @hypest said it is a known issue. We tried fixing that for the individual tiles but this time an interesting bug happens where the first word of caption can not be styled.
see First word not stylable

hypest · 2020-01-10T14:54:48Z

We tried fixing that for the individual tiles but this time an interesting bug happens where the first word of caption can not be styled.

Just to be sure @pinarol , do you mean that there's a new issue in this PR? Or was it an issue that happened in the attempts to fix the removing caption newlines issue?

pinarol · 2020-01-10T15:10:54Z

Just to be sure @pinarol , do you mean that there's a new issue in this PR? Or was it an issue that happened in the attempts to fix the removing caption newlines issue?

The "First word not stylable" problem is currently reproducible only on individual Gallery tiles because it uses its own RichText and not the Caption component. The existing Caption component was suitable only for blocks so we couldn't use it on tiles. In this PR, newline issue does not exist on tiles because we solved it without noticing the "First word not stylable" regression.

We are about to merge a PR to develop that refactors Caption component to make it suitable for both tiles and blocks. After that one is merged, both blocks and tiles will be using the same Caption component so they will have the same bug which is the newline issue.

hypest

LGTM!

hypest · 2020-01-10T17:35:37Z

The strings update (1294de9) looks good to me.

Target gutenberg-mobile release 1.20.0

5d7e643

Tug added the Gutenberg Editing and display of Gutenberg blocks. label Jan 7, 2020

Tug added this to the 14.0 milestone Jan 7, 2020

Tug requested a review from hypest January 7, 2020 16:39

Tug self-assigned this Jan 7, 2020

Tug mentioned this pull request Jan 7, 2020

Release v1.20.0 wordpress-mobile/gutenberg-mobile#1752

Merged

Tug added 6 commits January 8, 2020 12:05

Update release notes with gutenberg changes in v1.20.0

b483b15

Update gutenberg-mobile ref

c6e27a5

Update gutenberg-mobile ref

5236aaf

Merge remote-tracking branch 'origin/develop' into gutenberg/integrat…

be80b66

…e_release_1.20.0

Update gutenberg-mobile ref

48fcaa9

Merge remote-tracking branch 'origin/develop' into gutenberg/integrat…

b98eace

…e_release_1.20.0

Tug mentioned this pull request Jan 10, 2020

[RNMobile] Merge mobile release v1.20.0 back into master WordPress/gutenberg#19562

Merged

6 tasks

Tug added 3 commits January 10, 2020 15:35

Update gutenberg-mobile submodule

caa39cf

Stepper component is actually not used yet, updating release notes

2b248fa

Update gutenberg-mobile submodule

e33b6e3

etoledom reviewed Jan 10, 2020

View reviewed changes

etoledom approved these changes Jan 10, 2020

View reviewed changes

Update release notes to remove fix for a feature that is behind dev flag

5a61085

hypest approved these changes Jan 10, 2020

View reviewed changes

Set gutenberg-mobile ref to the merged commit for v1.20.0 in master

e5f33aa

Tug mentioned this pull request Jan 10, 2020

[RNMobile] Merge mobile release v1.20.0 back into master (step 2) WordPress/gutenberg#19568

Closed

6 tasks

Update main resources file with gutenberg-mobile changes from 1.20.0

1294de9

Tug mentioned this pull request Jan 10, 2020

[RNMobile] Merge mobile release v1.20.0 back into master (step 2) WordPress/gutenberg#19569

Merged

6 tasks

Tug merged commit 69cfe28 into develop Jan 10, 2020

Tug deleted the gutenberg/integrate_release_1.20.0 branch January 10, 2020 17:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Gutenberg: update to v1.20.0 #11052

Gutenberg: update to v1.20.0 #11052

Tug commented Jan 7, 2020 •

edited

Loading

peril-wordpress-mobile bot commented Jan 7, 2020 •

edited

Loading

etoledom commented Jan 10, 2020

Tug commented Jan 10, 2020 •

edited

Loading

etoledom commented Jan 10, 2020

etoledom commented Jan 10, 2020

etoledom commented Jan 10, 2020

marecar3 commented Jan 10, 2020

etoledom commented Jan 10, 2020

etoledom commented Jan 10, 2020

Tug commented Jan 10, 2020

etoledom commented Jan 10, 2020

hypest commented Jan 10, 2020

hypest commented Jan 10, 2020 •

edited

Loading

etoledom Jan 10, 2020

etoledom left a comment

pinarol commented Jan 10, 2020 •

edited

Loading

hypest commented Jan 10, 2020

pinarol commented Jan 10, 2020

hypest left a comment

hypest commented Jan 10, 2020

Gutenberg: update to v1.20.0 #11052

Gutenberg: update to v1.20.0 #11052

Conversation

Tug commented Jan 7, 2020 • edited Loading

Changes:

peril-wordpress-mobile bot commented Jan 7, 2020 • edited Loading

etoledom commented Jan 10, 2020

Tug commented Jan 10, 2020 • edited Loading

etoledom commented Jan 10, 2020

etoledom commented Jan 10, 2020

etoledom commented Jan 10, 2020

marecar3 commented Jan 10, 2020

etoledom commented Jan 10, 2020

etoledom commented Jan 10, 2020

Tug commented Jan 10, 2020

etoledom commented Jan 10, 2020

hypest commented Jan 10, 2020

hypest commented Jan 10, 2020 • edited Loading

etoledom Jan 10, 2020

Choose a reason for hiding this comment

etoledom left a comment

Choose a reason for hiding this comment

pinarol commented Jan 10, 2020 • edited Loading

hypest commented Jan 10, 2020

pinarol commented Jan 10, 2020

hypest left a comment

Choose a reason for hiding this comment

hypest commented Jan 10, 2020

Tug commented Jan 7, 2020 •

edited

Loading

peril-wordpress-mobile bot commented Jan 7, 2020 •

edited

Loading

Tug commented Jan 10, 2020 •

edited

Loading

hypest commented Jan 10, 2020 •

edited

Loading

pinarol commented Jan 10, 2020 •

edited

Loading