Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash once adding a Group block #1755

Merged
merged 1 commit into from
Jan 10, 2020
Merged

Fix crash once adding a Group block #1755

merged 1 commit into from
Jan 10, 2020

Conversation

lukewalczak
Copy link
Contributor

Fixes crash once adding Group block

Ref to gutenberg PR: WordPress/gutenberg#19457

To test:

  1. Add a Group block
  2. Check if block is added correctly

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@lukewalczak lukewalczak changed the base branch from develop to release/1.20.0 January 7, 2020 11:10
@lukewalczak lukewalczak changed the title Add ref to gutenberg release Fix crash once adding a Group block Jan 7, 2020
@lukewalczak lukewalczak added this to the 1.20 milestone Jan 7, 2020
@lukewalczak lukewalczak self-assigned this Jan 7, 2020
@lukewalczak lukewalczak mentioned this pull request Jan 7, 2020
Merged
6 tasks
@hypest hypest requested a review from Tug January 7, 2020 11:16
pinarol
pinarol approved these changes Jan 10, 2020
View reviewed changes
Copy link
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉 Tested with WPiOS by adding a Group block

@lukewalczak lukewalczak merged commit 5b727a7 into release/1.20.0 Jan 10, 2020
@lukewalczak lukewalczak deleted the fix-group-crash branch January 10, 2020 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinarol pinarol pinarol approved these changes

@Tug Tug Awaiting requested review from Tug

Assignees

@lukewalczak lukewalczak

Labels
hotfix [Type] Crash
Projects
None yet
Milestone
1.20
Development

Successfully merging this pull request may close these issues.
3 participants
@lukewalczak @pinarol @dratwas