-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Posts & Pages: Merge trunk into feature branch #21883
Merged
momo-ozawa
merged 131 commits into
task/ui-modernization-posts-and-pages
from
task/merge-trunk
Oct 26, 2023
Merged
Posts & Pages: Merge trunk into feature branch #21883
momo-ozawa
merged 131 commits into
task/ui-modernization-posts-and-pages
from
task/merge-trunk
Oct 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tracking all the loaded widgets when application is opened allows to see the percentage of unique daily users who use widgets and proportion of usage of each widget. Given we only need an approximate tracking to understand the usage of widgets we don't need to rely on unpredictable widget loading events. A single event also make it more likely to understand and track.
This file is not used in any target. Also, it seems to be a duplication of WordPress/JetpackStatsWidgets/LocalizationConfiguration.swift. It's potentially a left-over from #21521.
It was highlighted by CocoaPods.
…reation When users select paid domain, they can still opt-in for a free wordpress.com subdomain in plan selection view. When domain is selected, it is returned through "domain_name" parameter. Use this domain when creating siteURLString instead of the one selected in domain selection view.
Merge 23.5 code freeze
…refactor-status-type Update `DashboardPostsSyncManagerListener` function signature
…in-name-back-from-calypso
…r-pages Fix authors filter support on Pages
…rs-pages-release Fix authors filter support on Pages
…-detail-header Reader Detail: Dispatch header layoutIfNeeded on main queue
…menu [Domain Management] Add My Domains to Me Screen
…ce-popover-for-ui-tests UI Tests: Disable compliance popover for UI Tests
…tting-wrong-code-for-sms-2fa-can-result-in-a-vague-error-message Fix: Submitting wrong code for SMS 2FA can result in a vague error message
…fa-controllers-are-opened-when-logging-in Fix two 2FA controllers being opened when logging in at the same time
# Conflicts: # Podfile # Podfile.lock # WordPress/Classes/ViewRelated/Pages/PageListViewController.swift # WordPress/WordPress.xcodeproj/project.pbxproj
Generated by 🚫 dangerJS |
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
|
kean
approved these changes
Oct 25, 2023
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges
trunk
intotask/ui-modernization-posts-and-pages
feature branch