-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gutenberg: Move config comments to header #21872
Conversation
Generated by 🚫 dangerJS |
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I was able to follow the testing instructions successfully and noted that the comments were not removed when changing the commit value and removing the tag via yq
. Disabling automerging for now to let @mokagio confirm if moving the comments to the header might affect anything else unintentionally.
Thanks @jhnstn @derekblank ! 🙇♂️ |
Currently the
yq
command removes the nested comments when evaluatingdel(.ref.tag)
. This occurs when preparing a new Gutenberg Mobile release (see here)Here is an example of the comments being removed 084669a
This seems to be a common issue with
yq
but for our case, moving the comments to the header of the file avoids the deletion.To test:
Try updating the commit value and removing the tag field via
yq
:yq eval ".ref.commit = \"123abc\"" ./Gutenberg/config.yml -i
yq eval 'del(.ref.tag)' ./Gutenberg/config.yml -i
Note that the comments are not removed after either command
Regression Notes
Gutenberg releases
Manually testing the
yq
commands used to update GutenbergChange is too small to warrant automated tests
PR submission checklist:
RELEASE-NOTES.txt
if necessary.UI Changes testing checklist: