Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove an unused source file: LocalizationConfiguration.swift #21784

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

crazytonyli
Copy link
Contributor

This file is not used in any target. Also, it seems to be a duplication of WordPress/JetpackStatsWidgets/LocalizationConfiguration.swift. It's potentially a left-over from #21521.

This PR should be good to merge as long as CI jobs pass.

Regression Notes

  1. Potential unintended areas of impact
    None.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    None.

  3. What automated tests I added (or what prevented me from doing so)
    None.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist: N/A

This file is not used in any target. Also, it seems to be a duplication of
WordPress/JetpackStatsWidgets/LocalizationConfiguration.swift. It's
potentially a left-over from #21521.
@crazytonyli crazytonyli added this to the 23.6 milestone Oct 15, 2023
@crazytonyli crazytonyli requested a review from mokagio October 15, 2023 22:33
@crazytonyli crazytonyli self-assigned this Oct 15, 2023
@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr21784-36ca389
Version23.4
Bundle IDorg.wordpress.alpha
Commit36ca389
App Center BuildWPiOS - One-Offs #7412
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr21784-36ca389
Version23.4
Bundle IDcom.jetpack.alpha
Commit36ca389
App Center Buildjetpack-installable-builds #6442
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@mokagio mokagio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this removal: CI is green and there's no project file change. Looks good.

@mokagio mokagio merged commit 34dd03c into trunk Oct 17, 2023
@mokagio mokagio deleted the remove-unused-widget-localization-code branch October 17, 2023 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants