-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Domain Management] Add My Domains to Me Screen #21701
Conversation
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
|
import UIKit | ||
|
||
final class MyDomainsViewController: UIViewController { | ||
enum Action: String { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alpavanoglu This enum
should be removed. right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this on a simulator and I noticed the following issue. The new button doesn't match the design. The text is centered, and it is missing the icon. Also, there's a "Products" section header that is not available in the design.
Design ref: rvVgXupiyONUcJMgPSoMFj-fi-2565_27886
PR Build | Design |
---|---|
Edit: I just noticed you mentioned inside the testing steps there's another PR to follow this 👍
}()) | ||
] | ||
|
||
#if JETPACK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Question] Why are we using macros here? Have you considered using AppConfiguration.isJetpack
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can answer this question as it was my suggestion @hassaanelgarem.
Without the macro, the MyDomainsViewController
files and all the files that depend on it would have to be added to WordPress target too. Even though the My Domains screen is for Jetpack only.
And if we remove those files from WordPress target, then the WordPress app won't build.
@alpavanoglu considered using isJetpack
flag but that doesn't fix this problem.
@hassaanelgarem Based on the "My Domains" design, it looks like the row doesn't have the disclosure indicator ( chevron icon ), which indicates that the screen should be presented modally. As I said earlier, I'm not a fan of presenting that screen modally. So what do you say we add the chevron like other rows? Also, that globe icon doesn't resemble the other icons. 🤔 |
Refs #21424
Refs #21425
This PR adds the "My Domains" tab to "Me" screen and tapping on the button will open the empty view controller.
Testing Steps
RemoteFeatureFlag
domainManagement
default value on line 63. needs to be set to true.