-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge beta 21.3.0.2 into trunk
#19742
Conversation
You can test the changes in Jetpack from this Pull Request by:
|
You can test the changes in WordPress from this Pull Request by:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but just want to have the state in the codebase internally consistent. Also, if we revert my change before merging, we'll avoid confusion with the translators.
Hey 👋 @mokagio - those sound like good reasons to me to revert the commit. Good catch. 👍
If I should open a PR to revert it just let me know. 🙇
No need, done in 27964b2. Sorry, I was only looking for your confirmation I didn't mean to suggest you'd have to make the change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @mokagio! 🙇
We're really close to merging #19735 (just waiting for all green tests). Would it be more efficient to include it on this merge, or is it better to wait?
Well, I may have answered my own question by merging the branch. 😬 Sorry if this complicated things. I've added #19735 to the description of this PR.
…notifications [Jetpack Focus] Revert Jetpack Notifications Disabling Feature Flag and Release Notes
Generated by 🚫 dangerJS |
@twstokes, no worries! 😄
From the point of view of getting the changes into However, from the point of view of having a beta with those changes, merging the code will not trigger a new beta deployment. That is a process release managers (or anyone with the right tokens in their environment) trigger manually via If you'd like a new beta with these changes, it'd be straightforward to make one but I'd suggest waiting until tomorrow (or ~12-24 hours) so that we can get more translations in. |
Whew, thanks a bunch @mokagio. |
Includes:
@twstokes 🤔 I'm not sure at this point whether my amendment of the release notes should be considered valid, in light of the feature flag? Maybe better to remove it? Thanks!
I'm aware we might not ship 21.3, but just want to have the state in the codebase internally consistent. Also, if we revert my change before merging, we'll avoid confusion with the translators.