Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Jetpack Content Migration] Enable Content Migration Flow #19714

Merged
merged 2 commits into from
Dec 2, 2022
Merged

[Jetpack Content Migration] Enable Content Migration Flow #19714

merged 2 commits into from
Dec 2, 2022

Conversation

twstokes
Copy link
Contributor

@twstokes twstokes commented Dec 2, 2022 •
edited
Loading

Closes #19659

Description

Activates the Jetpack migration flow by enabling the following feature flags:

  • jetpackPoweredBottomSheet
  • contentMigration

Regression Notes

  1. Potential unintended areas of impact

    • N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • Manual testing

  3. What automated tests I added (or what prevented me from doing so)

    • Tests were added during feature development

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@twstokes twstokes self-assigned this Dec 2, 2022
@twstokes twstokes added this to the 21.3 ❄️ milestone Dec 2, 2022
@twstokes twstokes changed the base branch from trunk to release/21.3 December 2, 2022 21:51
@twstokes twstokes marked this pull request as ready for review December 2, 2022 21:52
@twstokes twstokes requested review from salimbraksa, dvdchr, a team and alpavanoglu December 2, 2022 21:52
@peril-wordpress-mobile
Copy link

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

salimbraksa
salimbraksa approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@salimbraksa salimbraksa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@wpmobilebot
Copy link
Contributor

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19714-440b8e8 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19714-440b8e8 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@twstokes twstokes merged commit 8aff3df into release/21.3 Dec 2, 2022
@twstokes twstokes deleted the task/enable-cmf branch December 2, 2022 22:40
mokagio added a commit that referenced this pull request Dec 5, 2022
@mokagio
Add note regarding #19714 to editorialized release notes
fcd38db
@twstokes twstokes mentioned this pull request Dec 5, 2022
Merged
4 tasks
@mokagio mokagio mentioned this pull request Dec 6, 2022
Merged
mokagio added a commit that referenced this pull request Dec 6, 2022
@mokagio
Revert "Add note regarding #19714 to editorialized release notes"
27964b2 
This reverts commit fcd38db.

Since making that change to the release notes, the content migration
feature has been disabled (via feature toggle, see #19734, #19736) and
it would be misleading to advertise it in the release notes.

This also reverts f6efa1d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salimbraksa salimbraksa salimbraksa approved these changes

@dvdchr dvdchr Awaiting requested review from dvdchr

@alpavanoglu alpavanoglu Awaiting requested review from alpavanoglu

Assignees

@twstokes twstokes

Labels
Jetpack Content Migration Flow
Projects
None yet
Milestone
21.3 ❄️
Development

Successfully merging this pull request may close these issues.

iOS - Enable Content Migration Flow
3 participants
@twstokes @wpmobilebot @salimbraksa