Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Jetpack Content Migration] Disable Content Migration Flow #19734

Merged
merged 2 commits into from
Dec 5, 2022
Merged

[Jetpack Content Migration] Disable Content Migration Flow #19734

merged 2 commits into from
Dec 5, 2022

Conversation

twstokes
Copy link
Contributor

@twstokes twstokes commented Dec 5, 2022 •
edited
Loading

This PR reverts the commits from #19714 to disable the Content Migration Flow.

Related: #19735

Testing

Tapping a banner or badge in the WordPress app should not show the Jetpack overlay

  1. Load the WordPress app with an account authenticated into WordPress.com
  2. Locate any view that has a Jetpack badge or banner (Notifications, Reader, etc.)
  3. Tap the badge or banner
  4. Expect: No Jetpack overlay view to be shown and no prompts to start a migration

Loading the Jetpack app should not kick off a migration from the WordPress app

Related PR: #19710

  1. Clean install the WordPress app and authenticate.
  2. Exit the WordPress app and don't reopen it. (This will prevent the pre-flight sequence from running)
  3. Clean install the Jetpack app and load it.
  4. Expect: To see the Jetpack landing / prologue login screen.

Local build tests using Xcode debugger

  1. Run the WordPress and Jetpack apps from local builds attached to the Xcode debugger
  2. Monitor the debugger output for any messages related to the Jetpack migration

Regression Notes

  1. Potential unintended areas of impact

    • All features related to the migration should be behind feature flags, so thorough testing should be completed to confirm.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • Testing steps above.

  3. What automated tests I added (or what prevented me from doing so)

    • Automated tests added as part of the Jetpack Content Migration Flow.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@twstokes twstokes changed the base branch from trunk to release/21.3 December 5, 2022 18:59
@twstokes twstokes added this to the 21.3 ❄️ milestone Dec 5, 2022
@twstokes twstokes self-assigned this Dec 5, 2022
@twstokes twstokes marked this pull request as ready for review December 5, 2022 19:17
@peril-wordpress-mobile
Copy link

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@twstokes twstokes mentioned this pull request Dec 5, 2022
Merged
4 tasks
@wpmobilebot
Copy link
Contributor

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19734-45e556b on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19734-45e556b on your iPhone

If you need access to App Center, please ask a maintainer to add you.

salimbraksa
salimbraksa approved these changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@salimbraksa salimbraksa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that nothing happens when tapping "Jetpack Powered" badge and the migration flow didn't show up on Jetpack app.

But I saw these debugger logs on Jetpack:

🔵 Tracked: migration_content_export_eligibility <eligible: false>
🔵 Tracked: migration_content_import_eligibility <eligible: false>

I guess these are fixed in another PR. LGTM! 🚀

@twstokes
Copy link
Contributor Author

twstokes commented Dec 5, 2022

Thanks @salimbraksa!

I guess these are fixed in another PR. LGTM! 🚀

Correct, this PR aims to resolve those.

@twstokes twstokes merged commit e9a03e3 into release/21.3 Dec 5, 2022
@twstokes twstokes deleted the task/disable-cmf branch December 5, 2022 22:20
@mokagio mokagio mentioned this pull request Dec 6, 2022
Merged
mokagio added a commit that referenced this pull request Dec 6, 2022
@mokagio
Revert "Add note regarding #19714 to editorialized release notes"
27964b2 
This reverts commit fcd38db.

Since making that change to the release notes, the content migration
feature has been disabled (via feature toggle, see #19734, #19736) and
it would be misleading to advertise it in the release notes.

This also reverts f6efa1d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salimbraksa salimbraksa salimbraksa approved these changes

@wargcm wargcm Awaiting requested review from wargcm

@staskus staskus Awaiting requested review from staskus

@alpavanoglu alpavanoglu Awaiting requested review from alpavanoglu

@dvdchr dvdchr Awaiting requested review from dvdchr

@Gio2018 Gio2018 Awaiting requested review from Gio2018

Assignees

@twstokes twstokes

Labels
Jetpack Content Migration Flow [Type] Task
Projects
None yet
Milestone
21.3 ❄️
Development

Successfully merging this pull request may close these issues.
3 participants
@twstokes @wpmobilebot @salimbraksa