Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge beta 21.3.0.3 into trunk #19747

Merged
merged 3 commits into from
Dec 7, 2022
Merged

Merge beta 21.3.0.3 into trunk #19747

merged 3 commits into from
Dec 7, 2022

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented Dec 7, 2022

The diff includes no .strings likely because little time has passed since #19742.

I double checked this by re-running the lane to download localization to verify it produced no commit with .strings.

App .strings:
image

Other .strings (too many to fit in one page of my terminal):
image

The diff includes no PR, despite this being a new beta, because #19735 was merged into the release branch while #19742 was still open.


  • Updates to the localization files (.strings and Fastlane metadata) automatically pulled for the new translations that have already been approved in GlotPress
  • Version update in .xcconfig
  • Diffs from the PRs that made it into this beta (None)

@mokagio mokagio self-assigned this Dec 7, 2022
@peril-wordpress-mobile
Copy link

Messages
📖 This PR has the 'Releases' label: some checks will be skipped.

Generated by 🚫 dangerJS

@mokagio mokagio requested review from twstokes and a team December 7, 2022 06:43
@mokagio mokagio marked this pull request as ready for review December 7, 2022 06:43
@mokagio mokagio enabled auto-merge December 7, 2022 06:47
@wpmobilebot
Copy link
Contributor

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19747-a9fe267 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19747-a9fe267 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

Copy link
Contributor

@twstokes twstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @mokagio! 🙇

@mokagio mokagio merged commit 1d7af78 into trunk Dec 7, 2022
@spencertransier spencertransier deleted the release/21.3 branch December 30, 2022 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants