[Gutenberg] [Aztec] Prevent headings from becoming bold after words are autocorrected #17844

twstokes · 2022-01-31T18:56:54Z

This PR upgrades Aztec to version 1.19.8 and points to the Gutenberg Mobile commit that incorporates this change.

Related:

To test:

Prerequisites:

A WordPress.com site running the Seedlet theme.

Create a new Post
Add a Heading block
In the block type: "Hello i'm testing a heading." (autocorrect should intervene on "i'm")
Observe the heading is now "Hello I'm testing a heading."
Observe that when highlighting "I'm", the bold formatting button isn't depressed / enabled.
Publish the Post.
Observe that "I'm" isn't shown in bold on the site. (you can further inspect the HTML source to ensure <strong> tags don't wrap the text)

Regression Notes

Potential unintended areas of impact

Any text block in the block editor
Replacing text in text blocks
Autocorrecting any text block

What I did to test those areas of impact (or what existing automated tests I relied on)

Used testing steps above
Tested various non-heading blocks

What automated tests I added (or what prevented me from doing so)

A unit test has been added to Aztec.

PR submission checklist:

I have completed the Regression Notes.
I have considered adding unit tests for my changes.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

peril-wordpress-mobile · 2022-01-31T19:35:41Z

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

jkmassel · 2022-01-31T20:21:36Z

You can test the WordPress changes on this Pull Request by downloading it from AppCenter here with build number: pr17844-2d3eeda. IPA is available here. If you need access to this, you can ask a maintainer to add you.

jkmassel · 2022-01-31T20:25:35Z

You can test the Jetpack changes on this Pull Request by downloading it from AppCenter here with build number: pr17844-2d3eeda. IPA is available here. If you need access to this, you can ask a maintainer to add you.

guarani

Just leaving a review here. I tested this yesterday in the WPiOS app and it worked well, but when testing in Aztec I noticed a potential blocker: wordpress-mobile/AztecEditor-iOS#1334 (review).
Feel free to re-request a review when ready.

twstokes · 2022-02-04T16:26:30Z

I've pointed to the latest Aztec commit that hopefully mitigates the issue found.

guarani

Approved via wordpress-mobile/AztecEditor-iOS#1334 (review).
I also tested here with the installable build and the testing steps work as expected and I didn't notice any regressions.

twstokes · 2022-02-11T02:51:56Z

Awaiting approvals on the Gutenberg Mobile side before cutting the new Aztec release. Once the release is cut we'll point to the tag.

twstokes · 2022-02-14T23:03:08Z

This branch was caught up with the 19.2 release branch so that it would use GB Mobile v1.71.1. The release has not yet been merged back into trunk.

wpmobilebot · 2022-02-14T23:41:10Z

You can test the WordPress changes on this Pull Request by downloading it from AppCenter here with build number: pr17844-8943e0c. IPA is available here. If you need access to this, you can ask a maintainer to add you.

wpmobilebot · 2022-02-14T23:52:32Z

You can test the Jetpack changes on this Pull Request by downloading it from AppCenter here with build number: pr17844-8943e0c. IPA is available here. If you need access to this, you can ask a maintainer to add you.

twstokes · 2022-02-15T14:46:19Z

@fluiddot, since you helped out with the related Gutenberg + Gutenberg Mobile PRs, could you check this PR as well? I have the Podfile pointed to the merged Gutenberg Mobile commit, which if I understand correctly, may need to be tagged before this PR is merged into trunk. Thank you! 🙇

twstokes · 2022-02-15T15:08:43Z

⚠️ I just did a quick test of the generated binary on this PR and it failed - the bold heading issue still appeared. I'm looking into it. 👀

fluiddot · 2022-02-15T17:51:13Z

RELEASE-NOTES.txt

@@ -4,6 +4,7 @@
 * [*] Stats: fix navigation between Stats tab. [#17894]
 * [*] Add "Copy Link" functionality to Posts List and Pages List [#17911]
 * [*] [Jetpack-only] Enables the ability to use and create WordPress.com sites, and enables the Reader tab. [#17914, #17948]
+* [*] Block editor: Autocorrected Headings no longer apply bold formatting if they weren't already bold. [#17844]


If the Gutenberg Mobile ref is not being updated, which would include this fix, I'm wondering whether we should add this entry, wdyt?

That's a good point @fluiddot - I'd leave it out if we were just updating WordPress-Editor-iOS. After our discussion, though, the plan will be to include the GB Mobile upgrade as well with this PR.

twstokes · 2022-02-15T19:50:42Z

⚠️ I just did a quick test of the generated binary on this PR and it failed - the bold heading issue still appeared. I'm looking into it. 👀

This is working now that the GB Mobile bundle has been generated and we're pointing to that commit. 👍 After the Gutenberg Mobile PR is merged and a tag is created, we'll update this PR.

fluiddot

LGTM 🎊 !

I confirm that the issue can't be reproduced in the build pr17844-d47c82c.

NOTE: Totally unrelated to this PR but I noticed that the picker for switching the site doesn't work in the installable build. Not sure if it's a known issue otherwise we should open it.

fluiddot · 2022-02-16T13:19:45Z

As a side note, it would be great to address the warning from Peril (reference) and assign a milestone before merging the PR.

twstokes · 2022-02-16T14:47:22Z

NOTE: Totally unrelated to this PR but I noticed that the picker for switching the site doesn't work in the installable build. Not sure if it's a known issue otherwise we should open it.

Thanks for bringing this up @fluiddot! I'm running the same build and haven't been able to reproduce that. 😬

twstokes · 2022-02-16T15:43:04Z

This has been pointed to the GB Mobile tag.

[Gutenberg] [Aztec] Prevent headings from becoming bold after words are autocorrected

twstokes added the [Type] Bug label Jan 31, 2022

twstokes changed the title ~~Point to Aztec bold heading fix commit.~~ Prevent headings from becoming bold after words are autocorrected Jan 31, 2022

twstokes added the Posting/Editing label Jan 31, 2022

twstokes requested a review from guarani January 31, 2022 20:03

guarani reviewed Feb 3, 2022

View reviewed changes

twstokes force-pushed the bug/aztec-headings branch from 4c771b4 to 2d3eeda Compare February 3, 2022 19:36

twstokes requested a review from guarani February 4, 2022 16:26

guarani approved these changes Feb 7, 2022

View reviewed changes

twstokes added the [Status] DO NOT MERGE label Feb 11, 2022

This was referenced Feb 11, 2022

Release 1.19.8 wordpress-mobile/AztecEditor-iOS#1350

Merged

[Gutenberg] Prevent bold headings after autocorrection #17946

Closed

Prevent bold headings after autocorrection wordpress-mobile/gutenberg-mobile#4557

Merged

twstokes changed the title ~~Prevent headings from becoming bold after words are autocorrected~~ [Gutenberg] [Aztec] Prevent headings from becoming bold after words are autocorrected Feb 14, 2022

twstokes added Aztec and removed [Status] DO NOT MERGE labels Feb 14, 2022

twstokes added 2 commits February 14, 2022 18:29

Point to Aztec 1.19.8 release and GB Mobile commit.

9948a8d

Update release notes.

9e5a5fc

twstokes force-pushed the bug/aztec-headings branch from cbac842 to 9e5a5fc Compare February 14, 2022 23:31

Point to merged Gutenberg Mobile commit.

39f36e5

twstokes requested a review from fluiddot February 15, 2022 14:46

twstokes mentioned this pull request Feb 15, 2022

Retain Heading attribute when headings are autocorrected. wordpress-mobile/AztecEditor-iOS#1334

Merged

Revert to current GB Mobile tag.

948b320

fluiddot reviewed Feb 15, 2022

View reviewed changes

Point pod to GB Mobile with bundle generated.

d47c82c

twstokes mentioned this pull request Feb 15, 2022

Generate bundle to apply fix from "Prevent headings from becoming bold after words are autocorrected" wordpress-mobile/gutenberg-mobile#4585

Merged

fluiddot approved these changes Feb 16, 2022

View reviewed changes

twstokes added this to the 19.3 milestone Feb 16, 2022

Point to GB Mobile alpha tag.

8943e0c

twstokes self-assigned this Feb 16, 2022

twstokes merged commit d4e8240 into trunk Feb 16, 2022

twstokes deleted the bug/aztec-headings branch February 16, 2022 16:16

twstokes mentioned this pull request Feb 18, 2022

Revert Gutenberg Mobile version to v1.71.1, Aztec to 1.19.7 #17989

Merged

fluiddot mentioned this pull request Mar 2, 2022

[Gutenberg] Update gesture handler and reanimated libraries #18065

Merged

4 tasks

SiobhyB pushed a commit that referenced this pull request Mar 3, 2022

Merge pull request #17844 from wordpress-mobile/bug/aztec-headings

6fc8712

[Gutenberg] [Aztec] Prevent headings from becoming bold after words are autocorrected

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Gutenberg] [Aztec] Prevent headings from becoming bold after words are autocorrected #17844

[Gutenberg] [Aztec] Prevent headings from becoming bold after words are autocorrected #17844

twstokes commented Jan 31, 2022 •

edited

Loading

peril-wordpress-mobile bot commented Jan 31, 2022 •

edited

Loading

jkmassel commented Jan 31, 2022 •

edited

Loading

jkmassel commented Jan 31, 2022 •

edited

Loading

guarani left a comment

twstokes commented Feb 4, 2022

guarani left a comment

twstokes commented Feb 11, 2022 •

edited

Loading

twstokes commented Feb 14, 2022 •

edited

Loading

wpmobilebot commented Feb 14, 2022 •

edited

Loading

wpmobilebot commented Feb 14, 2022 •

edited

Loading

twstokes commented Feb 15, 2022 •

edited

Loading

twstokes commented Feb 15, 2022 •

edited

Loading

fluiddot Feb 15, 2022

twstokes Feb 15, 2022

twstokes commented Feb 15, 2022 •

edited

Loading

fluiddot left a comment

fluiddot commented Feb 16, 2022

twstokes commented Feb 16, 2022

twstokes commented Feb 16, 2022

[Gutenberg] [Aztec] Prevent headings from becoming bold after words are autocorrected #17844

[Gutenberg] [Aztec] Prevent headings from becoming bold after words are autocorrected #17844

Conversation

twstokes commented Jan 31, 2022 • edited Loading

To test:

Regression Notes

peril-wordpress-mobile bot commented Jan 31, 2022 • edited Loading

jkmassel commented Jan 31, 2022 • edited Loading

jkmassel commented Jan 31, 2022 • edited Loading

guarani left a comment

Choose a reason for hiding this comment

twstokes commented Feb 4, 2022

guarani left a comment

Choose a reason for hiding this comment

twstokes commented Feb 11, 2022 • edited Loading

twstokes commented Feb 14, 2022 • edited Loading

wpmobilebot commented Feb 14, 2022 • edited Loading

wpmobilebot commented Feb 14, 2022 • edited Loading

twstokes commented Feb 15, 2022 • edited Loading

twstokes commented Feb 15, 2022 • edited Loading

fluiddot Feb 15, 2022

Choose a reason for hiding this comment

twstokes Feb 15, 2022

Choose a reason for hiding this comment

twstokes commented Feb 15, 2022 • edited Loading

fluiddot left a comment

Choose a reason for hiding this comment

fluiddot commented Feb 16, 2022

twstokes commented Feb 16, 2022

twstokes commented Feb 16, 2022

twstokes commented Jan 31, 2022 •

edited

Loading

peril-wordpress-mobile bot commented Jan 31, 2022 •

edited

Loading

jkmassel commented Jan 31, 2022 •

edited

Loading

jkmassel commented Jan 31, 2022 •

edited

Loading

twstokes commented Feb 11, 2022 •

edited

Loading

twstokes commented Feb 14, 2022 •

edited

Loading

wpmobilebot commented Feb 14, 2022 •

edited

Loading

wpmobilebot commented Feb 14, 2022 •

edited

Loading

twstokes commented Feb 15, 2022 •

edited

Loading

twstokes commented Feb 15, 2022 •

edited

Loading

twstokes commented Feb 15, 2022 •

edited

Loading