Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.19.8 #1350

Merged
merged 11 commits into from
Feb 11, 2022
Merged

Release 1.19.8 #1350

merged 11 commits into from
Feb 11, 2022

Conversation

twstokes
Copy link
Contributor

@twstokes twstokes commented Feb 8, 2022

@twstokes twstokes self-assigned this Feb 8, 2022
@twstokes
Copy link
Contributor Author

twstokes commented Feb 11, 2022

My plan is to merge this once the following PRs are approved:

I did a smoke test with Mobile Gutenberg pointed to the changes for #1344 and it didn't appear affected. Running the Gutenberg Mobile demo and adding breakpoints here and here never paused execution when manipulating lists, telling me that Mobile Gutenberg doesn't use this path.

@twstokes twstokes added this to the 1.19.8 milestone Feb 11, 2022
@twstokes twstokes requested a review from guarani February 11, 2022 17:11
@twstokes
Copy link
Contributor Author

@guarani would you mind taking a look at this release PR when convenient?

Thanks! 🙇

Copy link
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good and match what I see in https://github.com/wordpress-mobile/AztecEditor-iOS/blob/develop/Documentation/ReleaseProcess.md.

I'm not familiar with the other change that's going into this release, but I presume it's also non-breaking, so can be shipped in a patch version.

I see you've checked the Gutenberg Mobile and Gutenberg demo apps with this change and there were no issues. Do we need to create a WPiOS PR, point it to this branch, and have its CI checks pass to know that WPiOS also works? I'm not sure this is needed though.
BTW even though WPiOS classic editor is powered by Aztec, classic editor tests are currently disabled , so I'm not sure CI would be able to catch any regressions anyway.

Should I do any manual testing of this release? Let me know how you want to proceed 🙇‍♂️

@twstokes
Copy link
Contributor Author

I'm not familiar with the other change that's going into this release, but I presume it's also non-breaking, so can be shipped in a patch version.

Good thought: I think it qualifies for a patch in this case due to being a bugfix.

Do we need to create a WPiOS PR, point it to this branch, and have its CI checks pass to know that WPiOS also works? I'm not sure this is needed though.

Also a good thought. We'd tested the Headings bug independently, but I'll cut a branch to test this entire release just to be extra safe.

@twstokes
Copy link
Contributor Author

I've created a PR in WPiOS to run CI for this release.

@guarani guarani self-requested a review February 11, 2022 20:02
Copy link
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving since all looks good here from my perspective. I don't think manual testing is needed to review this and the WPiOS PR buildkite tests appear to be passing.

@twstokes twstokes merged commit e5735cb into trunk Feb 11, 2022
@twstokes twstokes deleted the release/1.19.8 branch February 11, 2022 20:05
@twstokes twstokes changed the title Release/1.19.8 Release 1.19.8 Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants