-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.19.8 #1350
Release 1.19.8 #1350
Conversation
….1.19.7 Merge trunk changes of 1.19.6 to develop
Addressing PR comments
…tching-list-style Fix Li tag when switching the list style (issue #1307)
Retain Heading attribute when headings are autocorrected.
My plan is to merge this once the following PRs are approved:
I did a smoke test with Mobile Gutenberg pointed to the changes for #1344 and it didn't appear affected. Running the Gutenberg Mobile demo and adding breakpoints here and here never paused execution when manipulating lists, telling me that Mobile Gutenberg doesn't use this path. |
@guarani would you mind taking a look at this release PR when convenient?
Thanks! 🙇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good and match what I see in https://github.com/wordpress-mobile/AztecEditor-iOS/blob/develop/Documentation/ReleaseProcess.md.
I'm not familiar with the other change that's going into this release, but I presume it's also non-breaking, so can be shipped in a patch version.
I see you've checked the Gutenberg Mobile and Gutenberg demo apps with this change and there were no issues. Do we need to create a WPiOS PR, point it to this branch, and have its CI checks pass to know that WPiOS also works? I'm not sure this is needed though.
BTW even though WPiOS classic editor is powered by Aztec, classic editor tests are currently disabled , so I'm not sure CI would be able to catch any regressions anyway.
Should I do any manual testing of this release? Let me know how you want to proceed 🙇♂️
Good thought: I think it qualifies for a patch in this case due to being a bugfix.
Also a good thought. We'd tested the Headings bug independently, but I'll cut a branch to test this entire release just to be extra safe. |
I've created a PR in WPiOS to run CI for this release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving since all looks good here from my perspective. I don't think manual testing is needed to review this and the WPiOS PR buildkite tests appear to be passing.
The changes incorporated in the release
1.19.8
are: