Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate bundle to apply fix from "Prevent headings from becoming bold after words are autocorrected" #4585

Merged
merged 1 commit into from
Feb 16, 2022

Conversation

twstokes
Copy link
Contributor

@twstokes twstokes commented Feb 15, 2022

This PR contains the result of running npm run bundle to generate the latest bundle from develop due to the following PR:

This is needed so we can bump the GB Mobile version for WPiOS.

@twstokes twstokes requested a review from fluiddot February 15, 2022 19:57
@twstokes
Copy link
Contributor Author

After this is merged we'll need to create a tag for GB Mobile so that WPiOS can point to it.

Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via wordpress-mobile/WordPress-iOS#17844 (review).

Nitpick: I'm wondering if we should update the PR's title to mention that the bundle was generated to apply the fix "Prevent headings from becoming bold after words are autocorrected", wdyt?

@twstokes
Copy link
Contributor Author

Nitpick: I'm wondering if we should update the PR's title to mention that the bundle was generated to apply the fix "Prevent headings from becoming bold after words are autocorrected", wdyt?

Sure! I'd kept it generic.

@twstokes twstokes changed the title Generate latest bundle Generate bundle to apply fix from "Prevent headings from becoming bold after words are autocorrected" Feb 16, 2022
@twstokes twstokes merged commit 4f906b5 into develop Feb 16, 2022
@twstokes twstokes deleted the generate_bundle_for_aztec branch February 16, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants