Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gutenberg: Update to v1.17.0 #12917

Merged
merged 37 commits into from
Nov 15, 2019
Merged

Gutenberg: Update to v1.17.0 #12917

merged 37 commits into from
Nov 15, 2019

Conversation

hypest
Copy link
Contributor

@hypest hypest commented Nov 11, 2019 •
edited
Loading

This PR updates Gutenberg to v1.15.0
gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#1566

To test:

Please copy the following checklist into a new comment and mark each test with ✅, ⚠️ or ❌ based on your test result. Check the individual PR for testing steps.

⏳ Activate Preformatted block wordpress-mobile/gutenberg-mobile#1442
⏳ Send backspace event to JS in more scenarios wordpress-mobile/gutenberg-mobile#1517
⏳ Generate i18n files for WPAndroid and WPiOS to use wordpress-mobile/gutenberg-mobile#1520
⏳ shouldInteractWithURL will return always false to avoid crashes wordpress-mobile/gutenberg-mobile#1523
⏳ Include the block title in unsupported blocks wordpress-mobile/gutenberg-mobile#1533
⏳ Support copy of url in clipboard. wordpress-mobile/gutenberg-mobile#1537
⏳ Remove custom paragraph options for media-text wordpress-mobile/gutenberg-mobile#1538
⏳ Implement client-defined media options. wordpress-mobile/gutenberg-mobile#1539
⏳ Show new block indicator in default appender too wordpress-mobile/gutenberg-mobile#1542
⏳ Media & Text alignment options wordpress-mobile/gutenberg-mobile#1546
⏳ Prevents selection after ZWSP character wordpress-mobile/gutenberg-mobile#1552
⏳ Fix paste in title wordpress-mobile/gutenberg-mobile#1575

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@hypest hypest added the Gutenberg Editing and display of Gutenberg blocks. label Nov 11, 2019
@hypest hypest added this to the 13.7 milestone Nov 11, 2019
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 11, 2019 •
edited
Loading

You can trigger an installable build for these changes by visiting CircleCI here.

@hypest hypest mentioned this pull request Nov 11, 2019
Merged
4 tasks
@hypest hypest added Gutenberg Editing and display of Gutenberg blocks. and removed Gutenberg Editing and display of Gutenberg blocks. labels Nov 11, 2019
@hypest hypest marked this pull request as ready for review November 12, 2019 08:10
@hypest hypest requested review from daniloercoli and Tug November 12, 2019 08:10
@Tug Tug mentioned this pull request Nov 12, 2019
Merged
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 12, 2019 •
edited
Loading

Warnings
⚠️ Localizable.strings should only be updated on release branches because it is generated automatically.

Generated by 🚫 dangerJS

@hypest hypest added Gutenberg Editing and display of Gutenberg blocks. and removed Gutenberg Editing and display of Gutenberg blocks. labels Nov 13, 2019
@SergioEstevao
Merge pull request #12934 from wordpress-mobile/gutenberg/enable_pref…
c3f0b1d 
…ormated_block

Enable Preformatted block in Gutenberg.
etoledom and others added 19 commits November 14, 2019 10:34
@etoledom
[Gutenberg] Adding files app source to media picker
559ff3a
@etoledom
[Gutenberg] Adding FilesApp media picker
79c0d83
@etoledom
[Gutenberg] Rename filesAppMediaSource
f354260
@etoledom
Update gutenberg ref
9595897
@etoledom
Update release notes
f996fc0
@SergioEstevao
Update colors for pre and quote.
1c1feca
@SergioEstevao
Merge branch 'gutenberg/release-1.17.0' into update_aztec_editor
c343c7a 
# Conflicts:
#	Podfile
#	Podfile.lock
#	WordPress/Classes/ViewRelated/Aztec/ViewControllers/AztecPostViewController.swift
#	WordPress/WordPressShareExtension/ShareExtensionEditorViewController.swift
@etoledom
Update gutenberg ref
34f8e6e
@hypest
Update Gutenberg ref
a0868ad
@etoledom
Update gutenberg ref
0f046c3
@etoledom
Merge pull request #12883 from wordpress-mobile/gutenberg/other-apps-…
c58f019 
…media-option

[Gutenberg] Implement "Other Apps" media source option
@hypest
Update Gutenberg ref
88aafd2
@hypest
Merge branch 'gutenberg/release-1.17.0' into update_aztec_editor
9b02736
@hypest
Update Gutenberg ref
e32e88d
@hypest
Merge pull request #12929 from wordpress-mobile/update_aztec_editor
a2e6327 
Update Aztec-Editor to 1.12 and add block editor paragraph alignment
@hypest
Update Gutenberg ref
ca7dc44
@hypest
Update Gutenberg ref
48a37a2
@hypest
Update Gutenberg ref
a10befc
@hypest
Merge branch 'develop' into gutenberg/release-1.17.0
8b9cf4a
@hypest
Copy link
Contributor Author

hypest commented Nov 15, 2019 •
edited
Loading

Tested:

✅ Send backspace event to JS in more scenarios wordpress-mobile/gutenberg-mobile#1517
✅ Include the block title in unsupported blocks wordpress-mobile/gutenberg-mobile#1533
✅ Support copy of url in clipboard. wordpress-mobile/gutenberg-mobile#1537
✅ Implement client-defined media options. wordpress-mobile/gutenberg-mobile#1539
✅ Show new block indicator in default appender too wordpress-mobile/gutenberg-mobile#1542
✅ Media & Text alignment options wordpress-mobile/gutenberg-mobile#1546
✅ Prevents selection after ZWSP character wordpress-mobile/gutenberg-mobile#1552
✅ Fix paste in title wordpress-mobile/gutenberg-mobile#1575

mchowning
mchowning approved these changes Nov 15, 2019
View reviewed changes
Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested all the changes and did some general smoke testing. Everything looks good!

@etoledom
Copy link
Contributor

✅ Activate Preformatted block wordpress-mobile/gutenberg-mobile#1442

  • Found an edge case: Merging a para block into a preformatted block, the new lines on the preformatted block are lost. This also happens on Web.

✅ Send backspace event to JS in more scenarios wordpress-mobile/gutenberg-mobile#1517
✅ shouldInteractWithURL will return always false to avoid crashes wordpress-mobile/gutenberg-mobile#1523
✅ Include the block title in unsupported blocks wordpress-mobile/gutenberg-mobile#1533
✅ Support copy of url in clipboard. wordpress-mobile/gutenberg-mobile#1537
✅ Remove custom paragraph options for media-text wordpress-mobile/gutenberg-mobile#1538
✅ Implement client-defined media options. wordpress-mobile/gutenberg-mobile#1539
✅ Show new block indicator in default appender too wordpress-mobile/gutenberg-mobile#1542
✅ Media & Text alignment options wordpress-mobile/gutenberg-mobile#1546
✅ Prevents selection after ZWSP character wordpress-mobile/gutenberg-mobile#1552
✅ Fix paste in title wordpress-mobile/gutenberg-mobile#1575

etoledom
etoledom approved these changes Nov 15, 2019
View reviewed changes
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cameronvoell cameronvoell merged commit 9bdcc4d into develop Nov 15, 2019
@SergioEstevao SergioEstevao deleted the gutenberg/release-1.17.0 branch May 11, 2020 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etoledom etoledom etoledom approved these changes

@mchowning mchowning mchowning approved these changes

@daniloercoli daniloercoli Awaiting requested review from daniloercoli

@Tug Tug Awaiting requested review from Tug

Assignees
No one assigned
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Milestone
13.7
Development

Successfully merging this pull request may close these issues.
6 participants
@hypest @etoledom @mchowning @cameronvoell @Tug @SergioEstevao