-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Preformatted block in Gutenberg. #12934
Merged
SergioEstevao
merged 4 commits into
gutenberg/release-1.17.0
from
gutenberg/enable_preformated_block
Nov 13, 2019
Merged
Enable Preformatted block in Gutenberg. #12934
SergioEstevao
merged 4 commits into
gutenberg/release-1.17.0
from
gutenberg/enable_preformated_block
Nov 13, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can trigger an installable build for these changes by visiting CircleCI here. |
1 task
Add reference to support for preformatted block.
We detected this before in testing and decided to move forward anyway because it's happening on the web version too.
Here is the ticket in Gutenberg: WordPress/gutenberg#18476
|
koke
approved these changes
Nov 13, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, the integration works well, so let's merge this one and handle the bug separately
Error TypeError
Dangerfile
Generated by 🚫 dangerJS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables the preformatted block in iOS for release 1.17.0
To test:
Update release notes:
RELEASE-NOTES.txt
if necessary.