Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Preformatted block in Gutenberg. #12934

Merged

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Nov 12, 2019

Enables the preformatted block in iOS for release 1.17.0

To test:

  • Start a post using Gutenberg
  • Add a preformatted block to the post
  • See if it works correctly and interacts correctly with other blocks.

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@SergioEstevao SergioEstevao added the Gutenberg Editing and display of Gutenberg blocks. label Nov 12, 2019
@SergioEstevao SergioEstevao added this to the 13.7 milestone Nov 12, 2019
@SergioEstevao SergioEstevao requested a review from koke November 12, 2019 22:48
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 12, 2019

You can trigger an installable build for these changes by visiting CircleCI here.

@koke
Copy link
Member

koke commented Nov 13, 2019

See if it works correctly and interacts correctly with other blocks

Everything else looked good, but I spotted an ugly bug. If you press backspace at the start of a paragraph block after preformatted, when they merge all the newlines in the preformatted block are gone:

Screen Recording 2019-11-13 at 13 36 48

@SergioEstevao
Copy link
Contributor Author

SergioEstevao commented Nov 13, 2019 via email

Copy link
Member

@koke koke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, the integration works well, so let's merge this one and handle the bug separately

@SergioEstevao SergioEstevao merged commit c3f0b1d into gutenberg/release-1.17.0 Nov 13, 2019
@SergioEstevao SergioEstevao deleted the gutenberg/enable_preformated_block branch November 13, 2019 16:01
@peril-wordpress-mobile
Copy link

Fails
🚫

Danger failed to run /app/danger-0.aj3bcejhqx5.ts.

Error TypeError

Cannot read property 'modified_files' of undefined
TypeError: Cannot read property 'modified_files' of undefined
    at Object.exports.default (/app/danger-0.aj3bcejhqx5.ts:22:48)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Dangerfile

17|         const nonGutenbergMatches = matches.filter(m => !m.includes("gutenberg"));
18|         if (nonGutenbergMatches.length > 0) {
19|             fail("Podfile: reference to a commit hash");
20|         }
21|     }
--------------------------------------------------^
22| 
23|     // If changes were made to the release notes, there must also be changes to the AppStoreStrings file.
24|     const hasModifiedReleaseNotes = danger.git.modified_files.some(f => f.endsWith("Resources/release_notes.txt"));
25|     const hasModifiedAppStoreStrings = danger.git.modified_files.some(f => f.includes("Resources/AppStoreStrings.po"));

Generated by 🚫 dangerJS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants