Generate i18n files for WPAndroid and WPiOS to use #1520

Tug · 2019-10-30T20:12:08Z

Fixes #939

This PR adds 2 scripts to generate translation files for Wordpress-Android (as a strings.xml file) and WordPress-iOS (as a .swift file containing static strings). Those files will be generated and committed in the bundle folder as:

bundle/android/strings.xml for android
bundle/ios/GutenbergNativeTranslations.swift for iOS

This process will require a script on each app repository so those 2 files are read and included in the glotpress input file and thus the gutenberg mobile translations will be available in glotpress:

For Android: Automate updating gutenberg translations WordPress-Android#10719
For iOS: Automate updating gutenberg translations WordPress-iOS#12811

Note that only the strings that are in .(native|ios|android).js files are considered and those that are already part of gutenberg glotpress project (web) are excluded as well.

These scripts stopped working because the gutenberg project changed to only obtain translations from files in the build folder after the project was built. As a result, gutenberg is not getting translations for any *.native.js files. This addresses that by: 1. Performing a gutenberg build and obtaining a pot file from `gutenberg/build/`. 2. Generating a gutenberg-mobile pot file based on the contents of `./src/*.js` and `./gutenberg/*.native.js`, while also excluding anything already contained in the gutenberg pot file that was generated in step 1.

hypest · 2019-11-04T11:57:42Z

👋

I know this is still WIP so, feel free to ignore this question: gutenberg-native.strings seems largely identical to the stings.xml so, I wonder if one or the other will get removed from the PR in favor of a single file.

…nd-android-files

Tug · 2019-11-07T15:09:45Z

Hi @hypest, thanks for having a look!
Indeed gutenberg-native.strings is a file that needed to be removed. It's done now :)

Tug · 2019-11-07T15:13:03Z

bundle/ios/GutenbergNativeTranslations.swift

+let string77 = NSLocalizedString("hello %s", comment: "")
+let string78 = NSLocalizedString("cheeseburger", comment: "")
+let string79 = NSLocalizedString("%d cat", comment: "")
+let string79Plural = NSLocalizedString("%d cats", comment: "")


Is there a way to have those grouped so glotpress knows string79Plural is the plural version of string79? Not sure who to ping to answer this 🤔 Any idea @hypest ?

We don't have support for plurals yet 😞 wordpress-mobile/WordPress-iOS#6327

I see. So I guess it's not worth sending those as extra strings for translations as they won't be picked up by glotpress as the plural version of other strings 🤔 Yeah in that case we should probably remove those

mchowning · 2019-11-07T18:27:56Z

bin/po2android.js

+		const potFileName = process.argv[ 2 ];
+		const destination = process.argv[ 3 ];
+		const potFileContent = fs.readFileSync( potFileName );
+		const swiftOutput = po2Android( potFileContent, process.argv[ 3 ] );


Perhaps something like "xmlOutput" here instead 😄

mchowning · 2019-11-07T18:50:33Z

package.json

@@ -68,7 +68,7 @@
    "prebundle": "yarn i18n-cache:force",
    "prebundle:android": "yarn patch-metro-no-file-watch",
    "postbundle:android": "yarn un-patch-metro-no-file-watch",
-    "bundle": "yarn bundle:android && yarn bundle:ios",
+    "bundle": "yarn bundle:android && yarn bundle:ios && yarn clean:pot && yarn genstrings",


If there is no "gutenberg*.pot" file, then yarn clean:pot will fail and prevent yarn genstrings from executing. I think adding the -f flag to the rm command in yarn clean:pot would be one way to fix this.

Weird it's not failing for me when there is no pot file, I think this might be because of the wildcard?
I can add -f if it fixes it for you 👍

Maybe worth moving this to prebundle with the rest of the i18n work

mchowning · 2019-11-07T18:55:53Z

With these changes running yarn bundle will build gutenberg, which runs npm install inside gutenberg, and the the node_modules directory is generated inside gutenberg and remains after this script is run. For me locally, having the node_modules directory inside gutenberg causes the mobile gutenberg tests (yarn test) to fail. Maybe this is something unique to my local setup, but if it's not, we might want to update this script to clean up after itself so that someone doesn't run yarn bundle and then later not realize why all their tests are failing.

Of course, this probably won't be an issue once we move to the monorepo.

Tug · 2019-11-08T06:52:58Z

Thank you for reviewing @mchowning
I addressed the issues you mentioned, could you have another look :)?

koke · 2019-11-08T06:58:38Z

bin/po2swift.js

+		const potFileContent = fs.readFileSync( potFileName );
+		const swiftOutput = po2Swift( potFileContent, process.argv[ 3 ] );
+		fs.writeFileSync( destination, swiftOutput );
+	} else {


Can you explain what the non-TTY variant is for? I'm not that familiar with node on the cli, and I don't understand why there are two variants

This is so the script can work with pipes: cat gutenberg.pot | node bin/po2swift.js.
I started with this approach because it was easier to test, and I wasn't sure which one I was going to use in package.json. It's not needed anymore so we could remove it but I figured it would be a nice addition

koke

I think this looks good. I'd be careful to avoid plurals in native JS files, since I don't think those will work on iOS yet wordpress-mobile/WordPress-iOS#6327

Tug · 2019-11-08T09:57:32Z

@koke thanks for reviewing :)
Indeed they won't work. I'll remove the plurals for iOS and check the ci failing test on android 👍

mchowning and others added 2 commits October 28, 2019 13:36

Generate a translation file for Android and iOS

05ce8c7

Tug self-assigned this Oct 30, 2019

Tug added 3 commits October 31, 2019 11:36

Add property for android tools to ignore unused resources

9b38f5d

Rename android output

99a4f83

Update android strings file

018a11b

This was referenced Oct 31, 2019

Automate updating gutenberg translations wordpress-mobile/WordPress-iOS#12811

Merged

Automate updating gutenberg translations wordpress-mobile/WordPress-Android#10719

Merged

Tug added 5 commits November 4, 2019 16:12

Merge remote-tracking branch 'origin/develop' into fix/i18n-gen-ios-a…

9a4f381

…nd-android-files

Use spaces for indent

5ccaf48

Update translation files

48cf12e

Fix indents for plurals

69914b4

Remove obsolete file

ed4af83

Tug requested review from mchowning, hypest and koke November 7, 2019 14:51

Fix eslint errors

3c92760

Tug marked this pull request as ready for review November 7, 2019 15:09

Tug added the App Integration label Nov 7, 2019

Tug commented Nov 7, 2019

View reviewed changes

mchowning reviewed Nov 7, 2019

View reviewed changes

Tug added 2 commits November 8, 2019 07:28

Fix variable naming

f4d396e

Clean node_modules in gutenberg repo

282cc85

koke reviewed Nov 8, 2019

View reviewed changes

koke approved these changes Nov 8, 2019

View reviewed changes

Tug added 2 commits November 8, 2019 11:11

Exclude plural strings for ios

bb3deca

Update GutenbergNativeTranslations.swift

24a5406

Tug merged commit 5dd9708 into develop Nov 8, 2019

Tug deleted the fix/i18n-gen-ios-and-android-files branch November 8, 2019 10:41

This was referenced Nov 11, 2019

Release v1.17 #1566

Merged

Gutenberg: Update to v1.17.0 wordpress-mobile/WordPress-iOS#12917

Merged

Gutenberg: Update to v1.17.0 wordpress-mobile/WordPress-Android#10769

Merged

This was referenced Nov 15, 2019

Automate updating gutenberg translations (void) wordpress-mobile/WordPress-Android#10807

Merged

Automate updating gutenberg translations (Take 2) wordpress-mobile/WordPress-Android#10810

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Generate i18n files for WPAndroid and WPiOS to use #1520

Generate i18n files for WPAndroid and WPiOS to use #1520

Tug commented Oct 30, 2019 •

edited

Loading

hypest commented Nov 4, 2019

Tug commented Nov 7, 2019

Tug Nov 7, 2019

koke Nov 8, 2019

Tug Nov 8, 2019

mchowning Nov 7, 2019 •

edited

Loading

mchowning Nov 7, 2019 •

edited

Loading

Tug Nov 8, 2019

koke Nov 8, 2019

mchowning commented Nov 7, 2019

Tug commented Nov 8, 2019

koke Nov 8, 2019

Tug Nov 8, 2019

koke left a comment

Tug commented Nov 8, 2019

Generate i18n files for WPAndroid and WPiOS to use #1520

Generate i18n files for WPAndroid and WPiOS to use #1520

Conversation

Tug commented Oct 30, 2019 • edited Loading

hypest commented Nov 4, 2019

Tug commented Nov 7, 2019

Tug Nov 7, 2019

Choose a reason for hiding this comment

koke Nov 8, 2019

Choose a reason for hiding this comment

Tug Nov 8, 2019

Choose a reason for hiding this comment

mchowning Nov 7, 2019 • edited Loading

Choose a reason for hiding this comment

mchowning Nov 7, 2019 • edited Loading

Choose a reason for hiding this comment

Tug Nov 8, 2019

Choose a reason for hiding this comment

koke Nov 8, 2019

Choose a reason for hiding this comment

mchowning commented Nov 7, 2019

Tug commented Nov 8, 2019

koke Nov 8, 2019

Choose a reason for hiding this comment

Tug Nov 8, 2019

Choose a reason for hiding this comment

koke left a comment

Choose a reason for hiding this comment

Tug commented Nov 8, 2019

Tug commented Oct 30, 2019 •

edited

Loading

mchowning Nov 7, 2019 •

edited

Loading

mchowning Nov 7, 2019 •

edited

Loading